Giter Site home page Giter Site logo

Comments (14)

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024 2

Ok guys,

there was an issue when the filepath had parentheses in the filename, e.g foobar (test).
I have fixed it in the latest commit and is available in the master.

This was a special case and there should be no other issues now.
I do not know if you guys had any parentheses or special chars in your filenames, but another issue
could be that you had bugged ( invalid/old ) config settings in the Spider Monkey Panel properties settings
or in your georgia-reborn-config.jsonc file.

Anyways, all should be good now if you download the master version and replace your files.
Thanks for reporting the issue!

-TT

from georgia-reborn.

GhostwalkerGamma avatar GhostwalkerGamma commented on June 12, 2024 1

I tested the master version on standarad installation of foobar and country flags showed up properly now, cheers.

image

Thanks for quick response!

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

Hi @Helios-2429,

I did not change anything related to the country flags since RC1.
The default tag is "artist_country": "%artistcountry%",
That means users need to tag their files with the %artistcountry% tag to successfully load them.

If you now change them to "artist_country": "%country%", you will need to use the %country% tag to be able to display them. If there is no metadata ( no tag used ) available, how would the theme know what flag to load?

It has been always like this and there is no issue.

-TT

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

P.S There was an issue with country flags but ONLY when using the Compact layout. This has been fixed in the latest master version. So if you are using the Compact layout, you would need to download the master version from here and replace your files.

from georgia-reborn.

Helios-2429 avatar Helios-2429 commented on June 12, 2024

Changing %artistcountry% to %country% in the config file was a tip I picked up from some forum post years ago, from someone who like myself had a collection already tagged that way. It's worked for me for as long as I've been using GR.

That said, even if I turn back the change in the config file, and test with a file I've added an 'artistcountry' tag to for testing, it still does not display the flag.

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

flags
flags2

As you see it works as it should. Maybe you have deactivated displaying the country flags?
Check top menu Options > Player controls > Lower bar > Show artist country flags

If you want to display the artist country flags in the metadata grid in Details:
And top menu Options > Details > Metadata grid > Show artist country flags
With top menu Options > Details > Metadata grid > Show artist

Be sure that you have tagged your albums with the %artistcountry% or whatever tag you defined in your config.
The metadata value accepts either two digit country code, i.e US or full name, i.e United States.

P.S If you change the tag in your config file, you need to reload/restart your player.

-TT

from georgia-reborn.

Helios-2429 avatar Helios-2429 commented on June 12, 2024

All of those are set as described, and I've double-checked that Help>Theme>Status>Flag images found is checked as well. I've also performed a fresh portable install of Foobar with a fresh install of GR, and tested with songs that have the country in the %artistcountry% tag.

Clearly something on my end is messing it up, I just wish I knew what it was...

from georgia-reborn.

Helios-2429 avatar Helios-2429 commented on June 12, 2024

Just did another test install, this time on a different computer. Same procedure, same settings, flags everywhere. This just keeps getting more confusing.

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

As I have mentioned before, there is an issue when using the RC-1/RC-2 versions BUT ONLY in the Compact layout
( Options > Layout > Compact ), all other layouts ( Default, Artwork ) do work though.
This issue was fixed in the master version here, otherwise it should work just fine.

A possibility could be that you are using an old/bugged georgia-reborn-config.jsonc or your SMP panel properties are bugged. Before you do anything, first make a backup your old georgia-reborn-config.jsonc file and THEN delete it
( will be recreated after foobar startup/reload). Clean your SMP panel properties ( while in Playlist panel -> Shift + right click > Panel properties... <- it is at the bottom. Then click on the Clear button and OK ).

P.S When deleting the georgia-reborn-config.jsonc file, all settings in the new file will have default values.
That means if you use another tag than the default %artistcountry% tag, you will need to modify it to your tag again.
Also be sure to use correct country names and or correct two digit country codes.

-TT

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

@Helios-2429, I'm closing this now as there is no further activity...

from georgia-reborn.

GhostwalkerGamma avatar GhostwalkerGamma commented on June 12, 2024

I'm having the same issue on windows 11 and latest foobar version, just update to newer version of georgia after a long time and flags no longer showing.
I tried everything mentioned above, include enabling the option to show country flags, update to the master version, uninstall / reinstall foobar and georgia,... but nothing seems to work.

image

image

image

from georgia-reborn.

TT-ReBORN avatar TT-ReBORN commented on June 12, 2024

Hi @GhostwalkerGamma,

this is really weird since I can not reproduce this issue and for most users it is working...

I do not know if this is a Windows 11 issue ( which I highly doubt ) or something in the latest version ( I checked the code and can not find any issues ). I'm using Windows 10 with the master version and there are no problems.
It is possible that maybe there is a file path issue?
Are you using portable or standard foobar installation?


To further investigate this issue, can you do some tests?

Make two new portable foobar installs on your desktop with following directory names:
foobar2000_new and install the latest master version from here.
foobar2000_old and install the old v2.0.3b version from here.

When you start foobar2000_old the first time, you need to select Columns UI in the popup.


Both versions should display the artist country flags if the track has the %ARTISTCOUNTRY% tag with its value.
But maybe there could be an issue in the latest version and you can verify with this test IF it is working properly.

Please report your findings, thanks!

-TT

from georgia-reborn.

GhostwalkerGamma avatar GhostwalkerGamma commented on June 12, 2024

I'm using standard installation.

I tested with portable installation like you recomended, and country flags work fine in both version.

image

image

from georgia-reborn.

Helios-2429 avatar Helios-2429 commented on June 12, 2024

For me, the issue occurs on Windows 10 and a portable installation, so I don't think it's a Windows 11 issue, at least...

from georgia-reborn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.