ttt-2/ttt2-role_siki

This is the "Sidekick" role for TTT2

ttt2-role_siki's Issues

Sidekick Radar Issue

The sidekick is shown as innocent to traitors even if he was a traitor before. This can be changed by using this hook: TTT2ModifyRadarRole

Sidekick Mod #2

The Sidekick can't win alone, so if the Jackal dies and the Sidekick is still alive, the Team Jackal can't win anymore.

Sidekick still shows up as original role in scoreboard

When you shoot a Traitor using your sidekick deagle. he will still show as traitor on the scoreboard to his old traitor teammates. same goes for jester if you shoot a jester he will still show as jester to all traitors.

did you maybe forget SendFullStateUpdate() ?

Sidekick Body unable to be identified if generated by certain means

Description:
If a sidekick is generated by means that isn't a 'normal method'(For Example: Clairvoyant or Jackal's Sidekick Deagle), the body is unable to be identified.

List of Known ways to trigger this bug:

• Claiming a sidekick role from a dead body as the Amnesiac.
• Stealing a Sidekick Role as the Doppleganger.

Notes:

• Likely additional ways to trigger this issue with other role interactions, only mentioning the ones I know.
• When a sidekick is created via these means, their Role displays a Black color behind the "Sidekick Title", instead of their team color.
• Searching the body of a sidekick with this issue will allow you to view the info as normal, however the body will never be labeled as identified on the scoreboard or on the body itself.

Credits

If you kill your mate, you will receive 1 credit!

Error when firing

[ERROR] addons/ttt2-role_siki-master/lua/weapons/weapon_ttt2_sidekickdeagle.lua:98: attempt to index upvalue 'ttt2_sidekick_deagle_refill_conv' (a nil value)

1. unknown - addons/ttt2-role_siki-master/lua/weapons/weapon_ttt2_sidekickdeagle.lua:98

When shooting a player

Sidekick who was previously a Detective still appears as a Detective to Innocents

If the Jackal shoots a Detective with a Sidekick Gun, they become a sidekick, which is perhaps a bit overpowered. More importantly however, the Sidekick will still be listed as a Detective in the GUI. This essentially gives the Sidekick plot armor, as no Innocent in their right minds would believe that the Detective is evil. I would prefer it if either the Detective cannot become a Sidekick, or they are at least they stop showing up as a Detective if they are turned.

SidekickDeagle can't be bought

Sometimes, you are unable to buy the SidekickDeagle

Sidekick is put on the Traitor Team if the Jackal is Killed under Sidekick Mode 2 (Sidekick receives targets)

If the sidekick mode is 2, the Sidekick does not become a Jackal if they are killed, but instead receives targets which they can kill for credits. However, if the Jackal is killed in this mode, the Sidekick appears to switch to the Traitor's side. This is pretty strange in my eyes. I originally added the Jackal to the server because it was a cool 3rd party group, but its ability to one-hit convert players to its team combined with the Sidekick's swaying loyalties makes it a bit OP. Under sidekick mode 1 the Jackal can convert multiple people to its team through strategic deaths, and under sidekick mode 2 the Sidekick can switch to the traitor's team, which often gives too much of an advantage to the traitors.

Can it be changed so that if the Jackal is killed, the Sidekick instead becomes a Jackal, but does not receive a Sidekick Gun (under sidekick mode 2)?

error

[ERROR] addons/ttt2-role_siki-master/gamemodes/terrortown/entities/weapons/weapon_ttt2_sidekickdeagle.lua:206: attempt to perform arithmetic on local 'timeLeft' (a nil value)

1. func - addons/ttt2-role_siki-master/gamemodes/terrortown/entities/weapons/weapon_ttt2_sidekickdeagle.lua:206
2. unknown - lua/includes/extensions/net.lua:32

ERROR

[ERROR] Warning! A net message (TTT2SyncSikiColor) is already started! Discarding in favor of the new message! (StartDrowning)

1. StartDrowning - gamemodes/terrortown/gamemode/shared/sh_player_ext.lua:760
2. unknown - gamemodes/terrortown/gamemode/shared/sh_main.lua:193
   L 01/26/2020 - 19:29:17: Lua Error:
   [ERROR] addons/ttt2-role_siki-master/lua/terrortown/entities/roles/sidekick/shared.lua:292: bad argument #1 to 'WriteUInt' (number expected, got nil)
3. WriteUInt - [C]:-1
4. fn - addons/ttt2-role_siki-master/lua/terrortown/entities/roles/sidekick/shared.lua:292
   3. Call - addons/ulib/lua/ulib/shared/hook.lua:109
   4. IdentifyBody - gamemodes/terrortown/gamemode/server/sv_corpse.lua:111
   5. ShowSearch - gamemodes/terrortown/gamemode/server/sv_corpse.lua:301
   6. unknown - gamemodes/terrortown/gamemode/server/sv_player.lua:593