tullamods/tullacc

Minimal addon for displaying cooldown text on buttons

tullacc's Issues

TullaCC acting like omniCC

hey im not a programer what so ever but i have noticed sence yesterday or early today that tullaCC have been acting like omniCC in the manner of that i can still see a countdown on enemy debuffs it occures on both classic wow and retail wow. I noticed when i last updated the addon and i would love if tullaCC to work like it used to thanks in advance and keep up the good job.

Incorrect font when also using TellMeWhen

I'm using tekticles to change my global game fonts, which tullaCC picks up nicely.
However, I've noticed that tullaCC displays cooldowns using Blizzard's default font (FritzQuadrata I think?) when I've also enabled TellMeWhen.

Is there something that can be done about this? It's probably more a TMW issue than tullaCC but I couldn't figure out why this would happen at all.

LUA error, breaks the addon

The LUA error below breaks the addon completely. It happened immediately after I joined a group, and a reload UI didn't work. All of a sudden sometime in the middle of the Mythic+ dungeon, the timers worked again.

4084x tullaCC\cooldown.lua:126: attempt to index local 'style' (a nil value) tullaCC\cooldown.lua:126: in function UpdateStyle'
tullaCC\cooldown.lua:152: in function <tullaCC\cooldown.lua:149>

Locals:
self = Grid2iconbuffs0105 {
0 =
_tcc_start = 0
_tcc_duration = 0
}
style = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'style' (a nil value)"
Addon =

{
PLAYER_LOGOUT = defined @tullaCC\main.lua:33
CleanupDatabase = defined @tullaCC\config.lua:47
eventHandler = {
}
SetupDatabase = defined @tullaCC\config.lua:33
Config = {
}
ResetDatabase = defined @tullaCC\config.lua:188
PLAYER_LOGIN = defined @tullaCC\main.lua:28
OnEvent = defined @tullaCC\main.lua:21
Timer = {
}
Display = {
}
Cooldown = {
}
GetDatabaseDefaults = defined @tullaCC\config.lua:54
}
`

timeMod variable

I've noticed that the cooldown frames behave somewhat odd when various time passage mechanics are involved, I belive Madness: Desynchronized uses it as well as global CDR effects to some extent.

I think the minDuration doesn't work well with but not only, I've noticed some odd interactions where the spell goes on cooldown but the frame doesn't update properly until a second or so later.

I'm not sure if that is in some way related to timeMod returned by _Aura or if it needs to be at all referenced by cooldowns.

MIN_SCALE isn't working

Seems that some CDs bypass the MIN_SCALE check in Timer_OnSizeChanged, I 'solved' it by adding the following under Timer_OnUpdate

if(self:GetParent():GetWidth() / ICON_SIZE < MIN_SCALE) then
self.text:Hide()
self:SetScript('OnUpdate', nil)
return;
end;

[bug] Elvui ActionBars only show text if `Show Numbers for Cooldowns` is enabled

Give us a clear and concise description of the problem, and what you expect to happen

ElvUI ActionBars only show a cooldown text if the option Show Numbers for Cooldowns in the Interface/ActionBars options is enabled (only Buttons with charges show durations). The problem which comes up with that is that all WeakAuras have 2 duration texts, which is not so easy to read :)

The ElvUI Cooldown Text is disabled. The ElvUI option Force Hide Blizzard Text is disabled (seems to disable Interface/ActionBars/Show Numbers for Cooldowns)

Do you have any steps to reproduce this issue?

1. Enable ElvUI ActionBars
2. Set Interface/ActionBars/Show Numbers for Cooldowns to off
3. All ElvUI ActionButtons cooldown durations are missing (besides ActionButtons with charges)
4. Set Interface/ActionBars/Show Numbers for Cooldowns to on
5. ElvUI ActionButtons now have a cooldown duration text; WeakAuras now have 2 duration texts on top of each other

Are you getting any error messages?

No error messages!

What version of tullaCC are you running?

9.0.0 (2020-10-13)

What version of World of Warcraft are you on?

[1]="9.0.5", 
[2]="38134", 
[3]="Mar 29 2021", 
[4]=90005

What other addons are you running?

Error occurs with all addons disabled besides tullaCC, WeakAuras and ElvUI

Consider using self:GetWidth instead of self:GetSize in Display:CalculateSizeRatio

Back in version 7.2.0 the font size for any given cooldown was calculated based on the width of the icon it was displayed on:

function Timer.OnSizeChanged(self, width, height)
	local fontScale = round(width) / ICON_SIZE

ad0dff9 changed the calculation to use the icons size via GetSize instead:

function Display:CalculateSizeRatio()
    local sizeRatio = round(min(self:GetSize())) / ICON_SIZE

GetSize however causes the calculation to use the icons height instead.

The cooldown icons above the floating enemy health bars are much wider than they are high - in my case 20 wide by 14 high.

The old calculation using width resulted in a sizeRatio of ca. 20 / 36 = 0.55, which was quite readable:

The new calculation however leads to a sizeRatio of ca. 14 / 36 = 0.38, making the font way too small imho:

Would it be possible to change the calculation so the icons width / self.GetWidth() is used to determine the font size (again)?

Square icons would be unaffected by this change and to my knowledge there are no other non square icons with cooldowns in the game.

Thanks in advance for your time!

Using tullacc with ElvUI

Whenever I use something in my bags (like a flask) I get these .lua errors (got them from BugGrabber abd Bugsack). Maybe I should submit these on ElvUI site come to think of it, if that is the case, apologies.

22x tullaCC-5.4.1\cc.lua:77: attempt to index field "updater" (a nil value)
tullaCC-5.4.1\cc.lua:77: in function "Stop"
tullaCC-5.4.1\cc.lua:174: in function <tullaCC\cc.lua:155>


FrameXML\Cooldown.lua:4: in function "CooldownFrame_SetTimer"
ElvUI-6.94\modules\bags\bags.lua:141: in function "UpdateSlot"
ElvUI-6.94\modules\bags\bags.lua:370: in function "Layout"
ElvUI-6.94\modules\bags\bags.lua:433: in function <ElvUI\modules\bags\bags.lua:426>

Locals:
cd = ElvUI_ContainerFrameBag2Slot11Cooldown {
0 =
SetCooldown = defined =[C]:-1
timer = {
}
isHooked = true
}
start = 0
duration = 0
charges = nil
maxCharges = nil
remainingCharges = 0
timer = {
nextUpdate = -3.7029385599463e-009
fontScale = 0.75
text = {
}
0 =
}
MIN_DURATION = 3
Timer =

{
UpdateText = defined @interface\AddOns\tullaCC\cc.lua:83
Stop = defined @interface\AddOns\tullaCC\cc.lua:70
SetNextUpdate = defined @interface\AddOns\tullaCC\cc.lua:61
Start = defined @interface\AddOns\tullaCC\cc.lua:155
OnSizeChanged = defined @interface\AddOns\tullaCC\cc.lua:107
Create = defined @interface\AddOns\tullaCC\cc.lua:127
ForceUpdate = defined @interface\AddOns\tullaCC\cc.lua:100
}
MIN_SCALE = 0.6

Incorrect timer

tullaCC Version: 4.3.1
WoW Version: 4.3.3(15354)
Bug: Incorrect timer on 'Unhatched Jubling Egg'(http://www.wowhead.com/item=19462) from quest 'Spawn of Jubjub'(http://www.wowhead.com/quest=7946)
Screenshot: http://i.imgur.com/esVuA.jpg

Timer missing after using Ascendance

When I'm casting Ascendance on my (elemental) shaman, I lose the cooldown timer. The spiral is still there but no timings.
If I then remove the spell from my bars (Dominos) and put it back into the same slot, the cooldown magically pops up. It seems the cooldown only starts after the effect of the spell wears off.

This is rather annoying as it's a major CD for shamans of any spec.

Text showing up twice

A small white cooldown text is showing up in front of the normal TullaCC cooldown text. It doesn't appear on blizzards default bar but it does show on dominos and bartender in my testing.

http://i.imgur.com/xIAkW.jpg

buff time in frames not working

Hi, i'm using shadowed unit frames and the count is stuck, for example if i have 46 min left in a buff tulla still shows 56, i reinstall the addon but nothing change. Thankyou!

Edit: i made more tests and apparently the issue can be solved if you unselect "disable blizzard cooldown count" in the general options of shadowed unit frames

Hovering over a button that's on cooldown removes the timer from it

Not sure if this is still 'supported' but since 7.1 if you hover over a button that's on CD the timer gets removed.

Cooldown spiral

Previous version of omnicc had the ability to hide the spiral, is it possible to do in tullacc, I tried setting cd:SetAlpha(0) but that also hides the cooldown frame.

Cooldown timer (number) is incorrect

The cooldown timer gets 'confused' at times, I noticed it with Avenger Shield which has a cooldown reset mechanic. It seems to be related to the reset mechanic, where the timer doesn't get 'reset' correctly when the skill becomes available and instead gets carried over somehow.

PS. to clarify this is after the rewrite commit.

Spiral / shading on charge cooldowns

A previous version I was using had abilities that were recharging with more than one charge showing as grayed out with a spiral, the new version no longer does that and only shows the CD timer.

Is there a way to change this behaviour either with an option or perhaps someway to change the code?

Improvement: Blacklist

This is very nice and lightweight, but it really needs a blacklist so i can stop it from showing on Plater auras :(

Non-functional on anything other then castbars since 7.1

I've disabled all addons except for tcc and it still only show on the actionbars. Prior to 7.1 it would display on SUF ,TMW, and WA. I've tried adjusting the minscale and reducing it to .01 and it still only appears on actionbars. If I use omnicc everything appears correctly.

Durationtimer for Grid2 (de)buffs

Hi. I can't get the duration timer to work from Grid2's buffs/debuffs with TullaCC.

It does work with OmniCC, but I do like TullaCC better, and want it to work with it as well. Can you please check this? Thank you.

[bug] Shows Cooldown Text on WeakAuras if disabled after reload

Give us a clear and concise description of the problem, and what you expect to happen

Reloading while a WeakAura with the option Hide Cooldown Text is showen, makes the duration visible regardless of the WA setting.

Do you have any steps to reproduce this issue?

1. Create WeakAura with option Hide Cooldown Text
2. Trigger WeakAura to show it
3. Reload
4. Duration text is showen regardless of option

Are you getting any error messages?

No error messages!

What version of tullaCC are you running?

9.0.0 (2020-10-13)

What version of World of Warcraft are you on?

[1]="9.0.5", 
[2]="38134", 
[3]="Mar 29 2021", 
[4]=90005

What other addons are you running?

Error occurs with all addons disabled besides tullaCC and WeakAuras

string.format vs SetFormattedText

It's probably better in terms of garbage generation to return 3 parameters from getTimeText the first being the format string, and later use SetFormattedText. Since SetFormattedText is coded in C and isn't subject to lua garbage collection issue which string.format is.

Performance in beta with the new Dominos

Seems like the newest version of Dominos causes some performance regression with tullacc.
This is with the previous beta

this one is with the new version

To be more specific, old refers to 9.0 beta and new to 9.0 beta1 on wowinterface.