Comments (2)
I think the reason was to avoid setting Turbolinks-Location
when redirection hasn't occurred. I think it's conceptually simpler if we always set it, though, which would remove our dependency on the session. Turbolinks.Visit.followRedirect could then check to see whether the location differs from the current location and only replace history if it does.
from turbolinks-rails.
Ah, I see now. Thank you.
from turbolinks-rails.
Related Issues (20)
- Shouldn't the default visit option still be `advance`? HOT 3
- Do not split assets into separate gem
- "respond_with" via responders ignores JavaScript redirections
- Problems with server-side rendering after upgrading from classic HOT 4
- Turbolinks JavaScript object not available in production HOT 3
- Usage when the assets pipeline is disabled HOT 2
- Provide "source url" on rubygem.org
- Redirection bug if your controller defines `location` HOT 3
- Add dependency on coffee-rails HOT 3
- PR #25 Did not include require statement for added rendering file. HOT 1
- How to avoid redirecting to a single route when using `remote: true` link from two different pages HOT 2
- Cache is not cleared with `advance` redirect HOT 1
- undefined method `get?' for 302:Integer HOT 1
- Add supports for `render` in controllers HOT 24
- suggestion to have gem without javascript dependency HOT 1
- assert_redirected_to behaving oddly with Rails 6 HOT 2
- redirect_to in rspec failing
- 5.0.0.beta2 / redirect_to with turbolinks action 'change' renders {"action":"replace"} instead of { change: [...] } HOT 1
- Is this version going to support Rails 3.2? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turbolinks-rails.