Giter Site home page Giter Site logo

turbolinks-rails's Introduction

Turbolinks is no longer under active development

Please note that Turbolinks is no longer under active development. It has been superseded by a new framework called Turbo, which is part of the Hotwire umbrella.

Turbolinks

Turbolinks® makes navigating your web application faster. Get the performance benefits of a single-page application without the added complexity of a client-side JavaScript framework. Use HTML to render your views on the server side and link to pages as usual. When you follow a link, Turbolinks automatically fetches the page, swaps in its <body>, and merges its <head>, all without incurring the cost of a full page load.

Turbolinks

Features

  • Optimizes navigation automatically. No need to annotate links or specify which parts of the page should change.
  • No server-side cooperation necessary. Respond with full HTML pages, not partial page fragments or JSON.
  • Respects the web. The Back and Reload buttons work just as you’d expect. Search engine-friendly by design.
  • Supports mobile apps. Adapters for iOS and Android let you build hybrid applications using native navigation controls.

Supported Browsers

Turbolinks works in all modern desktop and mobile browsers. It depends on the HTML5 History API and Window.requestAnimationFrame. In unsupported browsers, Turbolinks gracefully degrades to standard navigation.

Installation

Turbolinks automatically initializes itself when loaded via a standalone <script> tag or a traditional concatenated JavaScript bundle. If you load Turbolinks as a CommonJS or AMD module, first require the module, then call the provided start() function.

Installation Using Ruby on Rails

Your Ruby on Rails application can use the turbolinks RubyGem to install Turbolinks. This gem contains a Rails engine which integrates seamlessly with the Rails asset pipeline.

  1. Add the turbolinks gem, version 5, to your Gemfile: gem 'turbolinks', '~> 5.2.0'
  2. Run bundle install.
  3. Add //= require turbolinks to your JavaScript manifest file (usually found at app/assets/javascripts/application.js).

The gem also provides server-side support for Turbolinks redirection, which can be used without the asset pipeline.

Installation Using npm

Your application can use the turbolinks npm package to install Turbolinks as a module for build tools like webpack.

  1. Add the turbolinks package to your application: npm install --save turbolinks.

  2. Require and start Turbolinks in your JavaScript bundle:

    var Turbolinks = require("turbolinks")
    Turbolinks.start()

The npm package alone does not provide server-side support for Turbolinks redirection. See Following Redirects for details on adding support.

Table of Contents

Navigating with Turbolinks

Building Your Turbolinks Application

Advanced Usage

API Reference

Contributing to Turbolinks

Navigating with Turbolinks

Turbolinks intercepts all clicks on <a href> links to the same domain. When you click an eligible link, Turbolinks prevents the browser from following it. Instead, Turbolinks changes the browser’s URL using the History API, requests the new page using XMLHttpRequest, and then renders the HTML response.

During rendering, Turbolinks replaces the current <body> element outright and merges the contents of the <head> element. The JavaScript window and document objects, and the HTML <html> element, persist from one rendering to the next.

Each Navigation is a Visit

Turbolinks models navigation as a visit to a location (URL) with an action.

Visits represent the entire navigation lifecycle from click to render. That includes changing browser history, issuing the network request, restoring a copy of the page from cache, rendering the final response, and updating the scroll position.

There are two types of visit: an application visit, which has an action of advance or replace, and a restoration visit, which has an action of restore.

Application Visits

Application visits are initiated by clicking a Turbolinks-enabled link, or programmatically by calling Turbolinks.visit(location).

An application visit always issues a network request. When the response arrives, Turbolinks renders its HTML and completes the visit.

If possible, Turbolinks will render a preview of the page from cache immediately after the visit starts. This improves the perceived speed of frequent navigation between the same pages.

If the visit’s location includes an anchor, Turbolinks will attempt to scroll to the anchored element. Otherwise, it will scroll to the top of the page.

Application visits result in a change to the browser’s history; the visit’s action determines how.

Advance visit action

The default visit action is advance. During an advance visit, Turbolinks pushes a new entry onto the browser’s history stack using history.pushState.

Applications using the Turbolinks iOS adapter typically handle advance visits by pushing a new view controller onto the navigation stack. Similarly, applications using the Android adapter typically push a new activity onto the back stack.

Replace visit action

You may wish to visit a location without pushing a new history entry onto the stack. The replace visit action uses history.replaceState to discard the topmost history entry and replace it with the new location.

To specify that following a link should trigger a replace visit, annotate the link with data-turbolinks-action="replace":

<a href="/edit" data-turbolinks-action="replace">Edit</a>

To programmatically visit a location with the replace action, pass the action: "replace" option to Turbolinks.visit:

Turbolinks.visit("/edit", { action: "replace" })

Applications using the Turbolinks iOS adapter typically handle replace visits by dismissing the topmost view controller and pushing a new view controller onto the navigation stack without animation.

Restoration Visits

Turbolinks automatically initiates a restoration visit when you navigate with the browser’s Back or Forward buttons. Applications using the iOS or Android adapters initiate a restoration visit when moving backward in the navigation stack.

Restore visit action

If possible, Turbolinks will render a copy of the page from cache without making a request. Otherwise, it will retrieve a fresh copy of the page over the network. See Understanding Caching for more details.

Turbolinks saves the scroll position of each page before navigating away and automatically returns to this saved position on restoration visits.

Restoration visits have an action of restore and Turbolinks reserves them for internal use. You should not attempt to annotate links or invoke Turbolinks.visit with an action of restore.

Canceling Visits Before They Start

Application visits can be canceled before they start, regardless of whether they were initiated by a link click or a call to Turbolinks.visit.

Listen for the turbolinks:before-visit event to be notified when a visit is about to start, and use event.data.url (or $event.originalEvent.data.url, when using jQuery) to check the visit’s location. Then cancel the visit by calling event.preventDefault().

Restoration visits cannot be canceled and do not fire turbolinks:before-visit. Turbolinks issues restoration visits in response to history navigation that has already taken place, typically via the browser’s Back or Forward buttons.

Disabling Turbolinks on Specific Links

Turbolinks can be disabled on a per-link basis by annotating a link or any of its ancestors with data-turbolinks="false".

<a href="/" data-turbolinks="false">Disabled</a>

<div data-turbolinks="false">
  <a href="/">Disabled</a>
</div>

To reenable when an ancestor has opted out, use data-turbolinks="true":

<div data-turbolinks="false">
  <a href="/" data-turbolinks="true">Enabled</a>
</div>

Links with Turbolinks disabled will be handled normally by the browser.

Building Your Turbolinks Application

Turbolinks is fast because it doesn’t reload the page when you follow a link. Instead, your application becomes a persistent, long-running process in the browser. This requires you to rethink the way you structure your JavaScript.

In particular, you can no longer depend on a full page load to reset your environment every time you navigate. The JavaScript window and document objects retain their state across page changes, and any other objects you leave in memory will stay in memory.

With awareness and a little extra care, you can design your application to gracefully handle this constraint without tightly coupling it to Turbolinks.

Working with Script Elements

Your browser automatically loads and evaluates any <script> elements present on the initial page load.

When you navigate to a new page, Turbolinks looks for any <script> elements in the new page’s <head> which aren’t present on the current page. Then it appends them to the current <head> where they’re loaded and evaluated by the browser. You can use this to load additional JavaScript files on-demand.

Turbolinks evaluates <script> elements in a page’s <body> each time it renders the page. You can use inline body scripts to set up per-page JavaScript state or bootstrap client-side models. To install behavior, or to perform more complex operations when the page changes, avoid script elements and use the turbolinks:load event instead.

Annotate <script> elements with data-turbolinks-eval="false" if you do not want Turbolinks to evaluate them after rendering. Note that this annotation will not prevent your browser from evaluating scripts on the initial page load.

Loading Your Application’s JavaScript Bundle

Always make sure to load your application’s JavaScript bundle using <script> elements in the <head> of your document. Otherwise, Turbolinks will reload the bundle with every page change.

<head>
  ...
  <script src="/application-cbd3cd4.js" defer></script>
</head>

If you have traditionally placed application scripts at the end of <body> for performance reasons, consider using the <script defer> attribute instead. It has widespread browser support and allows you to keep your scripts in <head> for Turbolinks compatibility.

You should also consider configuring your asset packaging system to fingerprint each script so it has a new URL when its contents change. Then you can use the data-turbolinks-track attribute to force a full page reload when you deploy a new JavaScript bundle. See Reloading When Assets Change for information.

Understanding Caching

Turbolinks maintains a cache of recently visited pages. This cache serves two purposes: to display pages without accessing the network during restoration visits, and to improve perceived performance by showing temporary previews during application visits.

When navigating by history (via Restoration Visits), Turbolinks will restore the page from cache without loading a fresh copy from the network, if possible.

Otherwise, during standard navigation (via Application Visits), Turbolinks will immediately restore the page from cache and display it as a preview while simultaneously loading a fresh copy from the network. This gives the illusion of instantaneous page loads for frequently accessed locations.

Turbolinks saves a copy of the current page to its cache just before rendering a new page. Note that Turbolinks copies the page using cloneNode(true), which means any attached event listeners and associated data are discarded.

Preparing the Page to be Cached

Listen for the turbolinks:before-cache event if you need to prepare the document before Turbolinks caches it. You can use this event to reset forms, collapse expanded UI elements, or tear down any third-party widgets so the page is ready to be displayed again.

document.addEventListener("turbolinks:before-cache", function() {
  // ...
})

Detecting When a Preview is Visible

Turbolinks adds a data-turbolinks-preview attribute to the <html> element when it displays a preview from cache. You can check for the presence of this attribute to selectively enable or disable behavior when a preview is visible.

if (document.documentElement.hasAttribute("data-turbolinks-preview")) {
  // Turbolinks is displaying a preview
}

Opting Out of Caching

You can control caching behavior on a per-page basis by including a <meta name="turbolinks-cache-control"> element in your page’s <head> and declaring a caching directive.

Use the no-preview directive to specify that a cached version of the page should not be shown as a preview during an application visit. Pages marked no-preview will only be used for restoration visits.

To specify that a page should not be cached at all, use the no-cache directive. Pages marked no-cache will always be fetched over the network, including during restoration visits.

<head>
  ...
  <meta name="turbolinks-cache-control" content="no-cache">
</head>

To completely disable caching in your application, ensure every page contains a no-cache directive.

Installing JavaScript Behavior

You may be used to installing JavaScript behavior in response to the window.onload, DOMContentLoaded, or jQuery ready events. With Turbolinks, these events will fire only in response to the initial page load, not after any subsequent page changes. We compare two strategies for connecting JavaScript behavior to the DOM below.

Observing Navigation Events

Turbolinks triggers a series of events during navigation. The most significant of these is the turbolinks:load event, which fires once on the initial page load, and again after every Turbolinks visit.

You can observe the turbolinks:load event in place of DOMContentLoaded to set up JavaScript behavior after every page change:

document.addEventListener("turbolinks:load", function() {
  // ...
})

Keep in mind that your application will not always be in a pristine state when this event is fired, and you may need to clean up behavior installed for the previous page.

Also note that Turbolinks navigation may not be the only source of page updates in your application, so you may wish to move your initialization code into a separate function which you can call from turbolinks:load and anywhere else you may change the DOM.

When possible, avoid using the turbolinks:load event to add other event listeners directly to elements on the page body. Instead, consider using event delegation to register event listeners once on document or window.

See the Full List of Events for more information.

Attaching Behavior With Stimulus

New DOM elements can appear on the page at any time by way of Ajax request handlers, WebSocket handlers, or client-side rendering operations, and these elements often need to be initialized as if they came from a fresh page load.

You can handle all of these updates, including updates from Turbolinks page loads, in a single place with the conventions and lifecycle callbacks provided by Turbolinks’ sister framework, Stimulus.

Stimulus lets you annotate your HTML with controller, action, and target attributes:

<div data-controller="hello">
  <input data-target="hello.name" type="text">
  <button data-action="click->hello#greet">Greet</button>
</div>

Implement a compatible controller and Stimulus connects it automatically:

// hello_controller.js
import { Controller } from "stimulus"

export default class extends Controller {
  greet() {
    console.log(`Hello, ${this.name}!`)
  }

  get name() {
    return this.targets.find("name").value
  }
}

Stimulus connects and disconnects these controllers and their associated event handlers whenever the document changes using the MutationObserver API. As a result, it handles Turbolinks page changes the same way it handles any other type of DOM update.

See the Stimulus repository on GitHub for more information.

Making Transformations Idempotent

Often you’ll want to perform client-side transformations to HTML received from the server. For example, you might want to use the browser’s knowledge of the user’s current time zone to group a collection of elements by date.

Suppose you have annotated a set of elements with data-timestamp attributes indicating the elements’ creation times in UTC. You have a JavaScript function that queries the document for all such elements, converts the timestamps to local time, and inserts date headers before each element that occurs on a new day.

Consider what happens if you’ve configured this function to run on turbolinks:load. When you navigate to the page, your function inserts date headers. Navigate away, and Turbolinks saves a copy of the transformed page to its cache. Now press the Back button—Turbolinks restores the page, fires turbolinks:load again, and your function inserts a second set of date headers.

To avoid this problem, make your transformation function idempotent. An idempotent transformation is safe to apply multiple times without changing the result beyond its initial application.

One technique for making a transformation idempotent is to keep track of whether you’ve already performed it by setting a data attribute on each processed element. When Turbolinks restores your page from cache, these attributes will still be present. Detect these attributes in your transformation function to determine which elements have already been processed.

A more robust technique is simply to detect the transformation itself. In the date grouping example above, that means checking for the presence of a date divider before inserting a new one. This approach gracefully handles newly inserted elements that weren’t processed by the original transformation.

Persisting Elements Across Page Loads

Turbolinks allows you to mark certain elements as permanent. Permanent elements persist across page loads, so that any changes you make to those elements do not need to be reapplied after navigation.

Consider a Turbolinks application with a shopping cart. At the top of each page is an icon with the number of items currently in the cart. This counter is updated dynamically with JavaScript as items are added and removed.

Now imagine a user who has navigated to several pages in this application. She adds an item to her cart, then presses the Back button in her browser. Upon navigation, Turbolinks restores the previous page’s state from cache, and the cart item count erroneously changes from 1 to 0.

You can avoid this problem by marking the counter element as permanent. Designate permanent elements by giving them an HTML id and annotating them with data-turbolinks-permanent.

<div id="cart-counter" data-turbolinks-permanent>1 item</div>

Before each render, Turbolinks matches all permanent elements by id and transfers them from the original page to the new page, preserving their data and event listeners.

Advanced Usage

Displaying Progress

During Turbolinks navigation, the browser will not display its native progress indicator. Turbolinks installs a CSS-based progress bar to provide feedback while issuing a request.

The progress bar is enabled by default. It appears automatically for any page that takes longer than 500ms to load. (You can change this delay with the Turbolinks.setProgressBarDelay method.)

The progress bar is a <div> element with the class name turbolinks-progress-bar. Its default styles appear first in the document and can be overridden by rules that come later.

For example, the following CSS will result in a thick green progress bar:

.turbolinks-progress-bar {
  height: 5px;
  background-color: green;
}

To disable the progress bar entirely, set its visibility style to hidden:

.turbolinks-progress-bar {
  visibility: hidden;
}

Reloading When Assets Change

Turbolinks can track the URLs of asset elements in <head> from one page to the next and automatically issue a full reload if they change. This ensures that users always have the latest versions of your application’s scripts and styles.

Annotate asset elements with data-turbolinks-track="reload" and include a version identifier in your asset URLs. The identifier could be a number, a last-modified timestamp, or better, a digest of the asset’s contents, as in the following example.

<head>
  ...
  <link rel="stylesheet" href="/application-258e88d.css" data-turbolinks-track="reload">
  <script src="/application-cbd3cd4.js" data-turbolinks-track="reload"></script>
</head>

Ensuring Specific Pages Trigger a Full Reload

You can ensure visits to a certain page will always trigger a full reload by including a <meta name="turbolinks-visit-control"> element in the page’s <head>.

<head>
  ...
  <meta name="turbolinks-visit-control" content="reload">
</head>

This setting may be useful as a workaround for third-party JavaScript libraries that don’t interact well with Turbolinks page changes.

Setting a Root Location

By default, Turbolinks only loads URLs with the same origin—i.e. the same protocol, domain name, and port—as the current document. A visit to any other URL falls back to a full page load.

In some cases, you may want to further scope Turbolinks to a path on the same origin. For example, if your Turbolinks application lives at /app, and the non-Turbolinks help site lives at /help, links from the app to the help site shouldn’t use Turbolinks.

Include a <meta name="turbolinks-root"> element in your pages’ <head> to scope Turbolinks to a particular root location. Turbolinks will only load same-origin URLs that are prefixed with this path.

<head>
  ...
  <meta name="turbolinks-root" content="/app">
</head>

Following Redirects

When you visit location /one and the server redirects you to location /two, you expect the browser’s address bar to display the redirected URL.

However, Turbolinks makes requests using XMLHttpRequest, which transparently follows redirects. There’s no way for Turbolinks to tell whether a request resulted in a redirect without additional cooperation from the server.

To work around this problem, send the Turbolinks-Location header in the final response to a visit that was redirected, and Turbolinks will replace the browser’s topmost history entry with the value you provide.

The Turbolinks Rails engine sets Turbolinks-Location automatically when using redirect_to in response to a Turbolinks visit.

Redirecting After a Form Submission

Submitting an HTML form to the server and redirecting in response is a common pattern in web applications. Standard form submission is similar to navigation, resulting in a full page load. Using Turbolinks you can improve the performance of form submission without complicating your server-side code.

Instead of submitting forms normally, submit them with XHR. In response to an XHR submit on the server, return JavaScript that performs a Turbolinks.visit to be evaluated by the browser.

If form submission results in a state change on the server that affects cached pages, consider clearing Turbolinks’ cache with Turbolinks.clearCache().

The Turbolinks Rails engine performs this optimization automatically for non-GET XHR requests that redirect with the redirect_to helper.

Setting Custom HTTP Headers

You can observe the turbolinks:request-start event to set custom headers on Turbolinks requests. Access the request’s XMLHttpRequest object via event.data.xhr, then call the setRequestHeader method as many times as you wish.

For example, you might want to include a request ID with every Turbolinks link click and programmatic visit.

document.addEventListener("turbolinks:request-start", function(event) {
  var xhr = event.data.xhr
  xhr.setRequestHeader("X-Request-Id", "123...")
})

API Reference

Turbolinks.visit

Usage:

Turbolinks.visit(location)
Turbolinks.visit(location, { action: action })

Performs an Application Visit to the given location (a string containing a URL or path) with the specified action (a string, either "advance" or "replace").

If location is a cross-origin URL, or falls outside of the specified root (see Setting a Root Location), or if the value of Turbolinks.supported is false, Turbolinks performs a full page load by setting window.location.

If action is unspecified, Turbolinks assumes a value of "advance".

Before performing the visit, Turbolinks fires a turbolinks:before-visit event on document. Your application can listen for this event and cancel the visit with event.preventDefault() (see Canceling Visits Before They Start).

Turbolinks.clearCache

Usage:

Turbolinks.clearCache()

Removes all entries from the Turbolinks page cache. Call this when state has changed on the server that may affect cached pages.

Turbolinks.setProgressBarDelay

Usage:

Turbolinks.setProgressBarDelay(delayInMilliseconds)

Sets the delay after which the progress bar will appear during navigation, in milliseconds. The progress bar appears after 500ms by default.

Note that this method has no effect when used with the iOS or Android adapters.

Turbolinks.supported

Usage:

if (Turbolinks.supported) {
  // ...
}

Detects whether Turbolinks is supported in the current browser (see Supported Browsers).

Full List of Events

Turbolinks emits events that allow you to track the navigation lifecycle and respond to page loading. Except where noted, Turbolinks fires events on the document object.
Note that when using jQuery, the data on the event must be accessed as $event.originalEvent.data.

  • turbolinks:click fires when you click a Turbolinks-enabled link. The clicked element is the event target. Access the requested location with event.data.url. Cancel this event to let the click fall through to the browser as normal navigation.

  • turbolinks:before-visit fires before visiting a location, except when navigating by history. Access the requested location with event.data.url. Cancel this event to prevent navigation.

  • turbolinks:visit fires immediately after a visit starts.

  • turbolinks:request-start fires before Turbolinks issues a network request to fetch the page. Access the XMLHttpRequest object with event.data.xhr.

  • turbolinks:request-end fires after the network request completes. Access the XMLHttpRequest object with event.data.xhr.

  • turbolinks:before-cache fires before Turbolinks saves the current page to cache.

  • turbolinks:before-render fires before rendering the page. Access the new <body> element with event.data.newBody.

  • turbolinks:render fires after Turbolinks renders the page. This event fires twice during an application visit to a cached location: once after rendering the cached version, and again after rendering the fresh version.

  • turbolinks:load fires once after the initial page load, and again after every Turbolinks visit. Access visit timing metrics with the event.data.timing object.

Contributing to Turbolinks

Turbolinks is open-source software, freely distributable under the terms of an MIT-style license. The source code is hosted on GitHub. Development is sponsored by Basecamp.

We welcome contributions in the form of bug reports, pull requests, or thoughtful discussions in the GitHub issue tracker.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms.

Building From Source

Turbolinks is written in TypeScript. To build from source, first make sure you have the Yarn package manager installed. Then issue the following commands to build the distributable files in dist/:

$ yarn install
$ yarn build

Include the resulting dist/turbolinks.js file in your application’s JavaScript bundle.

Running Tests

Turbolinks is tested with the Intern testing library.

To run the test suite, follow the instructions for Building From Source above, then run:

$ yarn test

If you are testing changes to the Turbolinks source, remember to run yarn build before each test run. Or, run yarn watch to build automatically as you work.


© 2019 Basecamp, LLC.

turbolinks-rails's People

Contributors

dhh avatar georgeclaghorn avatar guilleiguaran avatar javan avatar jeremy avatar mrhead avatar rafaelfranca avatar sstephenson avatar y-yagi avatar ypresto avatar yskkin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

turbolinks-rails's Issues

redirect_to in rspec failing

I'm having the same issue as listed here - turbolinks/turbolinks#398 - and my controller and tests are basically identical. I'm not sure what configuration I'd need to change to prevent this, but I'm happy to provide config info if it's needed. My turbolinks version is 5.2.1, rails is 5.2.3, rspec is 3.8.2, rspec-rails is 3.8.2

Cache is not cleared with `advance` redirect

Hi!

When redirecting with turbolinks: :advance, clearCache is called before visit, and current page remains in cache after visit is finished. So history.back() shows outdated page.

How to avoid redirecting to a single route when using `remote: true` link from two different pages

Sorry, I've tried to find the answer to this question but I haven't been able to find it anywhere. In my Rails app, I use <%= link_to ... remote: true %> to perform AJAX create/update requests. However, I'm trying to call the same controller action from two different pages, which means, in one scenario it's redirecting to the wrong place. I'd like for the page to simply refresh itself once the call has finished successfully, but instead, it currently redirects to the location that the controller specifies. The whole point of using the link_to ... remote: true syntax is that it's quick and easy, so I hope to find a simple/supported way to do this. Thanks!

Why not request.fullpath?

From what I can tell, xhr request still includes the Turbolinks-Referrer header even when redirecting, so instead of storing redirect url in session, isn't it simpler to just use request.fullpath when setting the header? Is there specific reason to not do it?

# lib/turbolinks/redirection.rb#L43
if request.headers["Turbolinks-Referrer"].present?
  response.headers["Turbolinks-Location"] = request.fullpath
end

(unfortunately I don't have testable app - I'm realizing this when using turbolinks from non-ruby app and reimplementing the integration)

undefined method `get?' for 302:Integer

This issue has been reported on stackoverflow and I see that it has not yet been addressed:

https://stackoverflow.com/questions/49294119/undefined-method-get-for-302integer

From SO:

describe 'DELETE /salesman/:id' do
  let!(:salesman) { create :salesman }
  subject(:request) do
    delete salesman_path(salesman), headers: auth_headers
  end

  it 'redirects to index' do
    expect(request).to redirect_to company_salesmen_path(salesman.company)
  end
end
Failure/Error: expect(request).to redirect_to company_salesmen_path(salesman.company)

NoMethodError:
    undefined method `get?' for 302:Integer
  # /Users/dennish/.rvm/gems/ruby-2.5.0/gems/turbolinks-5.1.0/lib/turbolinks/assertions.rb:37:in `turbolinks_request?'
  # /Users/dennish/.rvm/gems/ruby-2.5.0/gems/turbolinks-5.1.0/lib/turbolinks/assertions.rb:6:in `assert_redirected_to'
  # ./spec/requests/salesmen_spec.rb:206:in `block (3 levels) in <top (required)>'

"respond_with" via responders ignores JavaScript redirections

When rendering a form with remote: true, one can replace the form with an error-rendered state via AJAX. However, using the very popular "responders" conventions, like Devise does, you find that the success response looks like:

respond_with resource, location: after_sign_up_path_for(resource)

while the error response looks like

respond_with resource

The problem here being that the turbolinks-rails handling of the redirection in the success case never happens. In fact, no attempt at redirection is made. It simply tries to render a JS template for the action.

I'm not sure if a fix really belongs inside turbolinks-rails, but this issue is of course specific to turbolinks-rails. So if anyone else is pondering about the same problem, here's a simple fix:

# config/initializers/responders.rb
module ActionController
  class Responder

    # Default implementation of `to_js` is just `default_render` but if there's no errors and
    # we pass a location then I expect to be redirected via Turbolinks JS
    def to_js
      if !has_errors? && options[:location].present?
        redirect_to options[:location]
      else
        default_render
      end
    end

  end
end

Do not split assets into separate gem

I'd love to package the turbolinks for Fedora, but the way how the assets are split into separate gem makes the whole matter quite unfortunate. Let me explain.

turbolinks is now independent js/coffee script library. So I should take it and package as js-turbolinks package. There is the turbolinks gem, i.e. this library. I should package it as rubygem-turbolinks in Fedora. Up until here, everything looks OK.

However, you split the JS assets into independent turbolinks-source gem and here it becomes interesting. Historically, for various reasons, we tried to unbundle everything in Fedora, that means that the turbolinks-source should depend on js-turbolinks and the .js library should by just filesystem system symlink. But, the thing is that in theory, the js-turbolinks might be of different version then the rubygem-turbolinks-source. That in turn means, that the version which is reported by turbolinks-source might not match the version of actual turbolinks.js. I might fix it by very strict version dependencies, but that has disadvantages as well, e.g:

  • we have to always update js-turbolinks together with rubygem-turbolink-source,
  • somebody might decide to update one library, but the other library can't be updated due to other version restrictions.

In this case, our live would be much easier, if the actual asset files were included directly into turbolinks. I see almost no disadvantages on your side, while it would make our life much easier.

Just FTR, I have been previously in the similar position with therubyracer gem, which used to bundled v8. This was unfortunate (because it is bundling) but we could unbundle the v8 and move on. Once the libv8 was introduced as dependency of therubyracer, we could not really move on with update.

I'd be very grateful if you can discontinue the turbolinks-source. Thanks for considering this 'weird' request.

Usage when the assets pipeline is disabled

Is it possible to use this gem without the assets? I'm using the Turbolinks npm package, but would like to use the redirection stuff from this gem.

I have a --skip-sprockets project which outputs this on rails s:

rescue in block (2 levels) in require': There was an error while trying to load the gem 'turbolinks'. (Bundler::GemRequireError)
Gem Load Error is: undefined method `assets' for #<Rails::Engine::Configuration:0x007fcf51d04350>

Add supports for `render` in controllers

I published a gem that adds support for render in Rails controllers when using Turbolinks.

I think this should be officially supported by Turbolinks and I am willing to work on that PR.
I would include a comprehensive suite of tests as part of the PR, and I am willing to follow any guideline or consideration you may have. I just don't want to do the work if there is no hope to have it used.

As mentioned in this comment:

I think the situation right now is inconsistent and can be really confusing:

  • Rails 5 adds Turbolinks by default
  • Forms are remote by default
  • render won't work with the defaults mentioned above.

The fact that forms in scaffolds are generated with local: true in Rails 5.2 looks like an smell to me. The vanilla code generated by Rails won't use its own defaults!

assert_redirected_to behaving oddly with Rails 6

We have a bunch of tests that make xhr requests and used assert_redirected_to.

Attempting to update to Rails 6, the same tests that passed before, fail with:

Schools::Parents::UploadsControllerTest#test_requires_superadmin [/Users/bhilkert/code/bark/test/controllers/schools/parents/uploads_controller_test.rb:47]:
Expected response to be a <3XX: redirect>, but was a <200: OK>
Response body: Turbolinks.clearCache()
Turbolinks.visit("http://bark.test/schools/dashboard", {"action":"replace"})

rails test test/controllers/schools/parents/uploads_controller_test.rb:39

It should use Turbolink's version of assert_redirected_to, however it's not because the check is return false because response.content_type from Rails 6 is text/javascript; charset=utf-8 instead of the checked condition (text/javascript).

Is this the expected response type for Rails 6 and if so, should this be adjusted to check for the presence of text/javascript instead of the exact string? If so, I can make a PR, but just want to confirm we don't have something configured wrong.

Shouldn't the default visit option still be `advance`?

I noticed the default visit option changed from advance to replace, I don't understand in which use case that would be desirable.

To my understanding visit_location_with_turbolinks is only executed for xhr requests which aren't GETs , thus never triggered by Turbolinks.visit.
That means that calling Turbolinks.visit(location, "replace") will override the history location of the XHR request with the redirection target and navigating back will skip the page that issued the XHR request.
I would expect the default to still be advance, because the location of the XHR call is never put in the browser location history.

Add dependency on coffee-rails

I recently removed the coffee-rails gem from my Rails app Gemfile as a bit of housekeeping as I was not using CoffeeScript anywhere directly. What I didn't notice at the time was that the turbolinks 2.2 gem still depended on coffee-rails and so everything kept working fine.

When I updated turbolinks from 2.5 to 5.0 it broke the app because coffee-rails was no longer present. Some time between 2.5 and 5.0 the gem dependency on coffee-rails was removed.

It would seem sensible to add it back here to prevent other obsessive-compulsive dependency cleaners like myself from tripping up on this.

Distribute un-minified version?

I've been messing with the source in the main Turbolinks repository, using blade and whatnot, to obtain an un-minified version of the Turbolinks source.

Since 90% of Rails users will be using the asset pipeline, distributing an unminified version will give most users more visibility in development mode.

Redirection bug if your controller defines `location`

Took a day finding the issue with a bug we had :P Eventually leading to TurboBoost.

This is Turboboost's redirect method.

def redirect_to(url = {}, options = {})
  turbolinks = options.delete(:turbolinks)

  super.tap do
    if turbolinks != false && request.xhr? && !request.get?
      visit_location_with_turbolinks(location, turbolinks) # Bug happens here
    else
      if request.headers["Turbolinks-Referrer"]
        store_turbolinks_location_in_session(location)
      end
    end
  end
end

Our controller for Locations with a quite common "find-object pattern"

class LocationsController < InheritedResources::Base

  def show
    @location = location.decorate
  end

  private

  def location
    @location ||= @current_company.locations.find(params[:id])
  end

end

This happened to override location inside your redirect_to method.

redirect_to with turbolinks option failing

I have an issue with cross domain redirects and Turbolinks not working as expected. Although I should admit at this point that this expectation is set using the README on turbolinks/turbolinks-classic since this repo doesn't have one. :]

If I add 'data-turbolinks' => false to the HTML link that triggers a redirect, then the redirection happens fine and no errors are printed to the JavaScript console. However, if I remove that data tag, and instead add the turbolinks: false option to the redirect_to call, then I get the initial XHR request, followed by the No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin ... is therefore not allowed access. error printed to the JavaScript console, followed by the HTML redirection request, which then succeeds.

I was under the impression that adding turbolinks: false to a redirect_to call would cause the browser to redirect normally, and therefore no Access-Control-Allow-Origin error would be printed to the log.

A little more context

We have an SSO service that all our apps communicate with. Each app has both a prominent sign on/off link, as well as automatic sign in if a user is already signed in to one of the other apps using the service. Adding the data-turbolinks tag to the links works fine, but it's the automatic sign in that is generating the Access-Control-Allow-Origin error. The way this works is that some business logic runs in a before_action in the application controller, and if it's determined that a user can be automatically signed in then a redirect happens using redirect_to to our SSO service that is hosted on a different domain.

Steps to reproduce

You can recreate the behaviour I'm seeing with this very simple example:

# controller.rb
class Controller < ApplicationController
  def google
    redirect_to('http://google.com', turbolinks: false)
  end
end

# routes.rb
get 'google', to: 'sessions#google'

# index.html.erb
<%= link_to("Google", google_path) %>

Expected behavior

The response served to the browser would cause it to redirect normally and not attempt to load the contents of the redirection via XHR.

Actual behavior

An attempt to redirect via XHR is triggered, followed by...

No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin ... is therefore not allowed access.

...followed by a normal redirection.

System configuration

Rails version: Rails 5.0.0.beta3

Ruby version: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]

5.0.0.beta2 / redirect_to with turbolinks action 'change' renders {"action":"replace"} instead of { change: [...] }

Steps to reproduce

I have this view with turbolinks and would like to have a partial update of the div #result through serverside turbolinks.

<div id="result" data-turbolinks-temporary>
  <% if flash[:new] %>
      Created new mock. Send your requests to <%= link_to flash[:new] %>.
  <% end %>
</div>
<div>
  <%= form_for @new_mock, :remote => true do |f| %>
      <%= f.label :statuscode %>:
      <%= f.text_field :statuscode %><br />
...
      <%= f.submit %>
  <% end %>
</div>

And its backed by this controller

class MocksController < ApplicationController

  def index
    @new_mock = Mock.new
  end

  def create
    mock = Mock.new(mock_params)
    mock.save
    flash[:new] = mock

    redirect_to mocks_path, change: ['result']
  end

  private
...
end

Expected behavior

When submitting the form, i would expect the response of the POST to be

Turbolinks.clearCache()
Turbolinks.visit("http://localhost:3000/mocks", { change: ['result'] })

Actual behavior

But i get

Turbolinks.clearCache()
Turbolinks.visit("http://localhost:3000/mocks", {"action":"replace"})

System configuration

Rails version: 5.0.0.beta4
Turbolinks-rails version: 5.0.0.beta2

Ruby version: 2.3.0

Problems with server-side rendering after upgrading from classic

I have a Rails 4.2.7.1 app and upgraded Turbolinks only:

gem 'turbolinks', github: 'turbolinks/rails'

P.S. App doesn't use any partial replacement.

I have a jQuery ajax call e.g.

$.get({ url: url, dataType: 'script' })

In my Rails controller I have a:

render :new, turbolinks: true

I see that render has not be modified in this version of lib/turbolinks/redirection.rb as with the classic version.

But even if I replace render :new, turbolinks: true with redirect_to the overridden redirect_to did not kick in and do a Turbolinks.visit().

  1. Are there plans to port over classic's lib/turbolinks/redirection.rb with render support? I have bunch of places where render :***** , turbolinks: true is called.
  2. Is there something I need to add to the $.get({ url: url, dataType: 'script' }) call for the Turbolinks.visit to kick in?

README and Upgrading to Turbolinks 5?

@sstephenson I'm testing out the beta and this has me fairly confused. Can we get a README that clarifies what exactly is happening here and, preferably, how to upgrade from Turbolinks Classic to Turbolinks 5? If there's a guide already out there, I can't find it.

Turbolinks JavaScript object not available in production

When I'm developing, Turbolinks works fine. The Turbolinks JavaScript object is available in my JavaScript console as expected.

development

When I deploy to production, the Turbolinks object isn't defined properly. The Turbolinks object isn't available in the JavaScript console, and my site does full page loads instead of Turbolinks page loads.

production

Upon further inspection of my production environment, the application.js asset is getting compiled and served. jQuery is accessible. Turbolinks appears in the minified JavaScript:

source

My application.js:

//= require jquery
//= require bootstrap
//= require jquery_ujs
//= require turbolinks
//= require_tree .

To me, it seems like Turbolinks is properly setup, but after going through asset compilation for the production environment it's not available in the window for usage.

Gemfile.lock

    turbolinks (5.0.1)
      turbolinks-source (~> 5)
    turbolinks-source (5.0.0)
    uglifier (3.0.2)
      execjs (>= 0.3.0, < 3)

config/environments/production.rb

  # Compress JavaScripts and CSS.
  config.assets.js_compressor = :uglifier
  # config.assets.css_compressor = :sass

  # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb

  # Enable serving of images, stylesheets, and JavaScripts from an asset server.
  # config.action_controller.asset_host = 'http://assets.example.com'

FWIW I'm deploying on Heroku and relying on them to do asset precompilation, and using the rails_12factor gem. To me it seems like Turbolinks is included correctly in the asset pipeline, but the Turbolinks JavaScript is somehow getting mangled by the precompliation/minification process.

Thanks for all the hard work you put into Turbolinks. My team is extremely excited about it.

–Ben

Is this version going to support Rails 3.2?

Hey, thx for this awesome gem!
Is it meant to support Rails 3.2?

Bundling works but starting the rails server fails with this error:

/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:89:in `rescue in block (2 levels) in require': There was an error while trying to load the gem 'turbolinks'. (Bundler::GemRequireError)
Gem Load Error is: undefined method `assets' for #<Rails::Engine::Configuration:0x007feb93786f50>
Backtrace for gem load error is:
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/railtie/configuration.rb:85:in `method_missing'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/turbolinks-5.0.0.beta2/lib/turbolinks.rb:17:in `<class:Engine>'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/turbolinks-5.0.0.beta2/lib/turbolinks.rb:14:in `<module:Turbolinks>'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/turbolinks-5.0.0.beta2/lib/turbolinks.rb:5:in `<top (required)>'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:86:in `require'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:86:in `block (2 levels) in require'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `each'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `block in require'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `each'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `require'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler.rb:102:in `require'
/Users/gambo/Sites/Boxes/config/application.rb:13:in `<top (required)>'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:53:in `require'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:53:in `block in <top (required)>'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:50:in `tap'
/Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:50:in `<top (required)>'
bin/rails:10:in `require'
bin/rails:10:in `<main>'
Bundler Error Backtrace:
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:85:in `block (2 levels) in require'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `each'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:81:in `block in require'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `each'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler/runtime.rb:70:in `require'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.12.5/lib/bundler.rb:102:in `require'
    from /Users/gambo/Sites/Boxes/config/application.rb:13:in `<top (required)>'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:53:in `require'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:53:in `block in <top (required)>'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:50:in `tap'
    from /Users/gambo/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/railties-3.2.22.2/lib/rails/commands.rb:50:in `<top (required)>'
    from bin/rails:10:in `require'
    from bin/rails:10:in `<main>'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.