Giter Site home page Giter Site logo

Comments (9)

steveklabnik avatar steveklabnik commented on July 18, 2024

Yeah something is seriously messed up. FX, Chrome, and Safari, links are all bad.

from curriculum.

 avatar commented on July 18, 2024

Using Firebug I disabled the display: table attribute inside the file screen.css :

.group:after, body > header:after, body > nav:after, body > footer:after, body #content > article:after, body #content > div > article:after, body #content > div > section:after, body nav.pagination:after, aside.sidebar:after {
    clear: both;
    content: "";
    display: table;
}

and links worked. Hope it helps.

from curriculum.

 avatar commented on July 18, 2024

Disabling the property position: relative on screen.css inside body > footer works on Chrome, Safari and FF. Don't know if it breaks something.

from curriculum.

steveklabnik avatar steveklabnik commented on July 18, 2024

Thanks! I'll try to apply one or the other of those later today, and double check what things look like.

from curriculum.

jcasimir avatar jcasimir commented on July 18, 2024

I temporarily fixed it by just removing the footer markup.

from curriculum.

kytrinyx avatar kytrinyx commented on July 18, 2024

@jcasimir Should this issue be closed, or do you want to add the footer back in with a CSS fix?

from curriculum.

jcasimir avatar jcasimir commented on July 18, 2024

The footer should get reinstated (or reimplemented or whatever) because it is where the license was displayed. Currently you could claim, looking at the rendered HTML, that there's no expressed copyright where it should really be CC-NC.

Here's the source file: https://github.com/JumpstartLab/curriculum/blob/master/source/_includes/custom/footer.html

I guess the fix would probably be to add it back into the layout, verify that the CSS problem is still there (all links are unclickable), the debug or delete/rebuild the CSS.

from curriculum.

steveklabnik avatar steveklabnik commented on July 18, 2024

@burtlo since you're good at CSS ( 😉 ) do you want to check into this?

from curriculum.

blairanderson avatar blairanderson commented on July 18, 2024

Looks like the footer has been added to all page views. I think this can be closed

from curriculum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.