turnermm/newpagetemplate

Updated version of newpagetemplate for handling new template Events

newpagetemplate's Issues

Looking for new maintainer

Would you be able to adopt this plugin? After many years with DW I am no longer playing an active role, and I am looking for users to take over my plugins. You can check on GitHub at turnermm.
https://forum.dokuwiki.org/d/21534-retiring

Originally posted by @turnermm in #11 (comment)

Update: Version 2023-10-14 Downloading and updating directly in the wiki does not work.

Update: Version 2023-10-14
Downloading and updating directly in the wiki does not work.

Messages in DokuWiki deprecated log

Messages in DokuWiki deprecated log:
require(action.php) is deprecated. It was called from require() in /var/www/dokuwiki/lib/plugins/newpagetemplate/action.php:20 Autoloading should be used instead!

• newpagetemplate Plugin version: 2022-02-05;
• DokuWiki version: 2023-04-04a "Jack Jackrum";
• PHP 8.2;

The plugin eliminates a lot of routine. I really, really hope it's still maintained.

Update of new version 2015-10-05 not possible

Running Update at the Extension Manager (Dokuwiki Hrun) doesn't update the plugin

• run Update

• Shows success

• Update still available

Is it a problem of the Dokuwiki? A problem of GitHub? The plugin? Something else?
https://www.dokuwiki.org/plugin:newpagetemplate

XSS vulnerability in write_msg()

See http://php-grinder.com/vulns/view/1193317

$_REQUEST['newpagetemplate'] is output without escaping.

Default branch ?

Looking at the source code, I was a bit confused because the default master branch did not reflect the latest changes.

To avoid that, I would suggest to merge the cli branch into master, or to change the default branch to cli.

Thanks

Implementation of @CURNS@

Hi!

According to https://www.dokuwiki.org/plugin:addnewpage#new-page_templates the addnewpage plugin enables possibility of inlcuding custom templates via newpagetemplate. Therefore, following syntax results in expected behaviour, because newpagetemplate explicitly does not support @CURNS@ substitution by default as documented:

===== @CURNS@ does not work =====
{{NEWPAGE>:custom:namespace#:custom:template}}

===== @CURNS@ works with default __template.txt =====
{{NEWPAGE>:custom:namespace}}

As described here I manually adapted newpagetemplate to process @CURNS@ replacement according to default namespace templates which is handled inside inc/common.php.

The adaption inside lib/plugin/newpagetemplate/action.php: I added the 4 lines between @NS@ and @FILE@ and also 4 lines in array below respectively, currently at line 94. Please note that the $ID is written in capitals here what is different from default inc/common.php:

$tpl = str_replace(array(
                              '@ID@',
                              '@NS@',
                              '@CURNS@',
                              '@!CURNS@',
                              '@!!CURNS@',
                              '@!CURNS!@',
                              '@FILE@',
                              '@!FILE@',
                              '@!FILE!@',
                              '@PAGE@',
                              '@!PAGE@',
                              '@!!PAGE@',
                              '@!PAGE!@',
                              '@USER@',
                              '@NAME@',
                              '@MAIL@',
                              '@DATE@',
                              '@EVENT@'
                           ),
                           array(
                              $ID,
                              getNS($ID),
                              curNS($ID),
                              \dokuwiki\Utf8\PhpString::ucfirst(curNS($ID)),
                              \dokuwiki\Utf8\PhpString::ucwords(curNS($ID)),
                              \dokuwiki\Utf8\PhpString::strtoupper(curNS($ID)),
                              $file,
                              utf8_ucfirst($file),
                              utf8_strtoupper($file),
                              $page,
                              utf8_ucfirst($title),
                              utf8_ucwords($title),
                              utf8_strtoupper($title),
                              $_SERVER['REMOTE_USER'],
                              $INFO['userinfo']['name'],
                              $INFO['userinfo']['mail'],
                              $conf['dformat'],
                              $event->name ,
                           ), $tpl);

So far, this little adaption seems to work as expected. It is of great worth in our school environment as part of our customized dokuwiki.

I am not a php coder (yet) nor this is a real issue. Maybe this quick hack to enable the @CURNS@ functionality could be implemented inside this plugin quite easily.

Anyways, thank you for beautiful software!

Why is the required permission not AUTH_READ but AUTH_CREATE?

Hello

When I used this plugin at first, I saw the error "You do not have access to the template …" (while logging out from the superuser account)
Then I found that this is because the ACL of the template was 'read' (I don't want to allow users to change the template) and the required permission was 'create' (Line 151 of action.php)
I think that the permission check might be enough with 'AUTH_READ.'

Could you cope with it? (Tell me if there is a security risk I'm overlooking.)