tvbarthel/cameracolorpicker

Camera Color Picker is an Android application that lets you capture, in real time, the colors around you using the camera of your device

cameracolorpicker's Issues

Activating the flash stops the color preview.

On some devices, activating the flash of the device's camera stops the color preview.

Camera Not Responding

Every second time Camera Crash

publish to F-Droid

I have no idea how publishing to F-Droid works, but I just noticed that the resolution of #33 is not published there. It would be nice to have that in F-Droid.

How do I import this project

Clone to gradle

How can I import the project into the build.gradle (app)

Suggestion: Big color preview

Hi!
Maybe you could add the feature that, when you are in "capture mode" and you captured a color and press the colored circle in the lower left, a bigger preview of the color opens.

That way you can quickly get a good impression of the color.

Added es (Spanish) translation

I have translated your application into es (Spanish). Here is the xml:

<!-- File "strings.xml" -->
<?xml version="1.0" encoding="utf-8"?>
<resources>

    <!-- General -->
    <string name="app_name">Kids Camera Color Picker</string>
    <string name="contact_us_default_subject">[Camera Color Picker] Sugerencia</string>

    <!-- Main activity -->
    <string name="activity_main_error_not_enough_colors">Necesita al menos 2 colores para crear una paleta.</string>
    <string name="activity_main_view_pager_title_color">Color</string>
    <string name="activity_main_view_pager_title_palette">Paleta</string>
    <string name="activity_main_view_pager_title_unknown">Desconocido</string>

    <!-- Color picker activity -->
    <string name="activity_color_picker_label">Elegir un color</string>
    <string name="activity_color_picker_confirm_save_message">Color guardado</string>

    <!-- Color detail activity -->
    <string name="activity_color_detail_label">Detalle</string>
    <string name="activity_color_detail_edit_text_dialog_fragment_title">Editar el nombre del color</string>
    <string name="activity_color_detail_edit_text_dialog_fragment_positive_button">Editar</string>

    <!-- License activity -->
    <string name="activity_license_label">Contenido y licencias</string>

    <!-- Palette creation activity -->
    <string name="activity_palette_creation_label">Nueva paleta</string>

    <!-- Palette detail activity -->
    <string name="activity_palette_detail_label">Detalle</string>
    <string name="activity_palette_detail_edit_palette_name_dialog_title">Editar el nombre de la paleta</string>
    <string name="activity_palette_detail_edit_palette_name_dialog_hint">Su espectacular paleta</string>
    <string name="activity_palette_detail_edit_palette_name_dialog_positive_action">Editar</string>

    <!-- About dialog fragment -->
    <string name="fragment_dialog_about_version_name">Versión %1$s</string>
    <string name="fragment_dialog_about_message">Camera Color Picker es una aplicación para Android libre y de fuente abierta que le permite capturar los colores a su alrededor usando la cámara de su dispositivo.</string>
    <string name="fragment_dialog_about_made_by">Hecho en Francia con amor por tbarthel &amp; vbarthel.</string>

    <!-- Main menu -->
    <string name="menu_main_action_contact_us">Contactar</string>
    <string name="menu_main_action_licenses">Contenido y licencias</string>
    <string name="menu_main_action_about">A cerca de</string>

    <!-- Color detail menu -->
    <string name="menu_color_detail_action_share">Compartir</string>
    <string name="menu_color_detail_action_edit">Editar</string>
    <string name="menu_color_detail_action_delete">Borrar</string>

    <!-- Palette detail menu -->
    <string name="menu_palette_detail_action_share">Compartir</string>
    <string name="menu_palette_detail_action_edit">Editar</string>
    <string name="menu_palette_detail_action_delete">Borrar</string>

    <!-- Color picker menu -->
    <string name="menu_color_picker_action_flash">Flash</string>

    <!-- Color clip -->
    <string name="color_clip_success_copy_message">Copiado al portapapeles.</string>
    <string name="color_clip_color_label_hex">Vale hexadecimal del color del elemento.</string>
    <string name="color_clip_color_label_rgb">Valor RGB del color del elemento.</string>
    <string name="color_clip_color_label_hsv">Valor HSV del color del elemento.</string>

    <!-- View color item list page -->
    <string name="view_color_item_list_page_empty_view">No tiene colores :(\n
  \n
  Capture un color con el botón inferior derecho.</string>

    <!-- View palette list page -->
    <string name="view_palette_list_page_empty_view">No tiene paletas :(\n
  \n
  Cree una paleta con el botón inferior derecho.</string>

</resources>

<!-- File "support.xml" -->
<?xml version="1.0" encoding="utf-8"?>
<resources>

    <!-- Color !-->
    <color name="support_transparent_black">#22000000</color>
    <color name="support_bar_progress">#ff397d3d</color>
    <color name="support_bar_background">#22000000</color>
    <color name="support_card_background">#55000000</color>
    <color name="support_card_background_pressed">#22000000</color>
    <color name="support_title_background">#4CAF50</color>
    <color name="support_text">#EEEEEE</color>

    <!-- Style -->
    <style name="SupportTheme.ProgressBar" parent="android:Widget.ProgressBar.Horizontal">
        <item name="android:progressDrawable">@drawable/support_progress_bar</item>
        <item name="android:minHeight">10dip</item>
        <item name="android:maxHeight">20dip</item>
    </style>

    <!-- String !-->
    <string name="activity_support_label">Apoyo a desarrolladores</string>
    <string name="support_title">Apoye aplicaciones de contenido libre y ayúdenos a dar vida a nuestros proyectos de fuente abierta.</string>
    <string name="support_error">Fallo al cargar la lista de café.\n
  Compruebe la conexión a red, por favor.</string>
    <string name="support_thanks_positive_btn">¡Gracias!</string>
    <string name="support_has_supported_us">¡Gracias por el apoyo!</string>
    <string name="support_thanks">¡Agradecemos mucho su apoyo!\n
  ¡Estos %1$s nos ayudarán a desarrollar más aplicaciones de contenido libre!</string>
    <string name="support_bar_text">%1$d %%</string>
    <string name="support_menu_support_item_support">Cómprenos un café</string>
    <string name="support_menu_thanks_item_thanks">¡Gracias!</string>

    <!-- Dimens !-->
    <dimen name="support_list_divider_height">10dp</dimen>
    <dimen name="support_list_padding">16dp</dimen>
    <dimen name="support_horizontal_margin">16dp</dimen>
    <dimen name="support_vertical_margin">16dp</dimen>
    <dimen name="support_entry_padding">8dp</dimen>
</resources>

<!-- File "strings2.xml" -->
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <string name="app_name">Kids Camera Color Picker</string>
    <string name="activity_main_error_not_enough_colors">Necesita al menos 2 colores para crear una paleta.</string>

    <!-- Palette creation activity -->
    <string name="activity_palette_creation_default_palette_name">Paleta %d</string>
</resources>

<!-- File "strings3.xml" -->
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <!-- Delete color dialog fragment -->
    <string name="fragment_dialog_delete_color_title">Aviso</string>
    <string name="fragment_dialog_delete_color_message">¿Borrar el color de su teléfono?</string>

    <!-- Delete palette dialog fragment -->
    <string name="fragment_dialog_delete_palette_title">Aviso</string>
    <string name="fragment_dialog_delete_palette_message">¿Borrar la paleta %1$s de su teléfono?</string>

    <!-- Palette creation activity -->
    <string name="activity_palette_creation_instruction">Para añadir colores a su paleta, simplemente haga clic en la lista de abajo.</string>
    <string name="activity_palette_creation_edit_text_dialog_fragment_title">Crear su paleta</string>
    <string name="activity_palette_creation_edit_text_dialog_fragment_hint">Mi espectacular paleta nueva</string>
    <string name="activity_palette_creation_edit_text_dialog_fragment_positive_button">Crear</string>

</resources>

---

Translation made with Stringlate.

Gradle compilation fails

:app:compileFossAdultReleaseSources
:app:lintVitalFossAdultRelease
/CameraColorPicker_tvbarthel/CameraColorPicker/app/src/main/res/values/strings.xml:6: Error: "main_activity_title" is not translated in "fr" (French) [MissingTranslation]
    <string name="main_activity_title">@string/app_name</string>
            ~~~~~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "MissingTranslation":
   If an application has more than one locale, then all the strings declared
   in one language should also be translated in all other languages.

   If the string should not be translated, you can add the attribute
   translatable="false" on the <string> element, or you can define all your
   non-translatable strings in a resource file called donottranslate.xml. Or,
   you can ignore the issue with a tools:ignore="MissingTranslation"
   attribute.

   By default this detector allows regions of a language to just provide a
   subset of the strings and fall back to the standard language strings. You
   can require all regions to provide a full translation by setting the
   environment variable ANDROID_LINT_COMPLETE_REGIONS.

   You can tell lint (and other tools) which language is the default language
   in your res/values/ folder by specifying tools:locale="languageCode" for
   the root <resources> element in your resource file. (The tools prefix
   refers to the namespace declaration http://schemas.android.com/tools.)

1 errors, 0 warnings
:app:lintVitalFossAdultRelease FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalFossAdultRelease'.
> Lint found fatal errors while assembling a release target.
  
  To proceed, either fix the issues identified by lint, or modify your build script as follows:
  ...
  android {
      lintOptions {
          checkReleaseBuilds false
          // Or, if you prefer, you can continue to check for errors in release builds,
          // but continue the build even when errors are found:
          abortOnError false
      }
  }
  ...

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Tag for release 0.0.7 missing

There is a release of version 0.0.7 of Camera Color Picker in Play Store that has no tag here on GitHub. In order to release the app on F-Droid it would be nice to have tags for every version that should be released (every stable version). The process could then be automated.

Thanks!

Color not well seen when to close to the background.

A trick (might be a shadow?) must be found to allow color close to the background one (basically light color) to be seen effortless.

Single line comments are not following Javadoc Standard

Hi,
For single line comments, you are using this pattern

/**
 * Single line comment.
 */

But it should be like this:
/** Single line comment. */

according to https://source.android.com/source/code-style#use-javadoc-standard-comments

Thanks.

How do I get left top color.

I wrote below code for getting top left color but it is not working as expected.

addColorFromYUV420(data, mSelectedTopLeftColor, (i * POINTER_RADIUS + j + 1),
POINTER_RADIUS, POINTER_RADIUS, mPreviewSize.width, mPreviewSize.height);

When I turn on the flash in the dark and then do color sampling, it can only collect black

Describe the bug
I found that when I put the phone on the table and turn on the flash before sampling the color, I can only collect black

Context

• Device: [galaxy a6s]
• OS version: [Android 8.1.0]
• App version: [0.0.7]

How to reproduce
Steps to reproduce the behavior:

1. Install CameraColorPicker and open
2. Click the sampling button in the lower right corner
3. put the phone on the table
4. Turn on the flashlight
5. Sampling color

Expected behavior
The color should be sampled as normally as when the flashlight is not on.

Screenshots
Recorded video see attachment (This is a comparison video. The first half is when the flashlight is not on, and the second half is when the flashlight is on)
20191218152301.zip

[Palette] drop touch when color number >=2

you must stay on the palette page + FAB bounce when color number >= 2 in order to indicate you how to create a palette.

Implement openintents PICK_COLOR action

Using your camera to pick a color is a great capability that could be utilized by other apps. The pull request #32 is one way to do that implementation that does not get in the way of the existing behavior of CameraColorPicker. Should that be merged in, or is there a better solution?

Make gradlew executable

cd CameraColorPicker/
$ ./gradlew clean build
-bash: ./gradlew: Permission denied

Trying to compile with Eclips

I have errors with styles.xml
Compiling with Android 5.0.1

<style name="CCPTheme.Light" parent="Theme.AppCompat.Light.DarkActionBar"> No resource found and ALL items in error <style name="CCPTheme.NoActionBar" parent="CCPTheme.Light"> OK ALL items in error <style name="CPPTheme.AlertDialog" parent="Theme.AppCompat.Light.Dialog"> No resource found and ALL items in error