tvinke/bulletproof

Groovy AST transformations, such as @ValueObject and @NonNull, which makes constructing an instance more bullet-proof.

bulletproof's Issues

Consider allowing the default Map constructor also to have null-checks performed

Have the default Map constructor also check for null values.

@tvinke.bulletproof.transform.NonNull
class Person {
    String name
}
new Person() // should also throws IllegalArgumentException: "Name can not be null"

Feature idea: annotation to add setters to ValueObject that return new immutable object

Just read your post on Java Code Geeks.

In my own code, I designed an immutable class not using the @Immutable annotation because I didn't think it allowed one to add setters to an immutable object:

public class Person {
   String name;
   int age;

   // setter
   Person setName(String newName) {
      new Person(newName, age)
   }

Would you be interested in adding these "immutable setters" (not sure what else to call them) or some Groovy counterpart to @ValueObject? Or perhaps adding another annotation that combines ValueObject with this idea? I would roll my own annotation, but I haven't yet learned how to do that myself.

Rename @Value to @ValueObject

I got a comment from @daviddawson on the Groovy Slack channel that

purely from an from an API usage point of view, @Value seems like a generic term, I wouldn't know what it meant if I came across that in code.

May be @Value should be renamed to @ValueObject, inspite of being inspired by Lombok similarly-named annotation, to clearly indicate it's role.

Do not generate null-checker for primitives

For the class

@Immutable
@NonNull
class Person {
  String name
  int age /* primitive */
}

no null check need to be performed for age since it's a primitive.