twho/loading-buttons-ios

A collection of loading buttons and their stylings written in Swift.

loading-buttons-ios's Issues

showLoader() hideLoader() bug

If you call showLoader() and hideLoader() in quick succession (less than 0.18 seconds apart) the hideLoader() function will not be executed due to the transition animation of 0.2 seconds you've put. This should not happen and a smooth transition should be granted no matter what.
There are workarounds to this using the showLoader closure but I think it should be fixed and taken into account anyways.

Other than this, great work on the repo! Good job!

I am using this pod by assign loading button class in storyBoard but some time loading progress indicator not end And other issue which I am facing when click on button progress indicator start but button title not removed

Start loading in GoogleMap function

extension homeViewController: GMSMapViewDelegate
{
    func mapView(_ mapView: GMSMapView, idleAt position: GMSCameraPosition) {
        
        if self.textFieldname == "pickup"
        {
            if confirmPickUpbtn.isLoading
            {
                
            }
            else
            {
                confirmPickUpbtn.isLoading = true
                confirmPickUpbtn.showLoader(userInteraction: false)
            }
            
            
        }
        else if self.textFieldname == "dropoff"
        {
            if confirmDropoffbtn.isLoading
            {
                
            }
            else
            {
                confirmDropoffbtn.isLoading = true
                confirmDropoffbtn.showLoader(userInteraction: false)
            }
             
        }
        //        let camera = GMSCameraPosition.camera(withLatitude: (position.target.latitude), longitude: (position.target.longitude), zoom: 18.0 , bearing: 0, viewingAngle: 0)
        //        self.mapView?.animate(to: camera)
        reverseGeocodeCoordinate(position.target)
        
    }
}

End in reverseGeocodeCoordinate function

    private func reverseGeocodeCoordinate(_ coordinate: CLLocationCoordinate2D) {
        
        // 1
        let geocoder = GMSGeocoder()
        
        // 2
        geocoder.reverseGeocodeCoordinate(coordinate) { response, error in
            guard let address = response?.firstResult(), let lines = address.lines else {
                return
            }
            
            // 3
            if self.textFieldname == "pickup"
            {
               ###  if self.confirmPickUpbtn.isLoading
                {
                    self.confirmPickUpbtn.isLoading = false
                    self.confirmPickUpbtn.hideLoader()
                    self.confirmPickUpbtn.backgroundColor = UIColor(hexString: "#FFCF00")
                }
                current_lat = coordinate.latitude
                current_long = coordinate.longitude
                self.startLocTextF.text = lines.joined(separator: "\n")
                self.locationManager.stopUpdatingLocation()
            }
            else if self.textFieldname == "dropoff"
            {
                if self.confirmDropoffbtn.isLoading
                {
                    self.confirmDropoffbtn.isLoading = false
                    self.confirmDropoffbtn.hideLoader()
                    self.confirmDropoffbtn.backgroundColor = UIColor(hexString: "#FFCF00")
                }
                desition_lat = coordinate.latitude
                desition_long = coordinate.longitude
                self.endLocTextF.text = lines.joined(separator: "\n")
                self.locationManager.stopUpdatingLocation()
                
            }
            
            
            // 4
            UIView.animate(withDuration: 0.25) {
                self.view.layoutIfNeeded()
            }
        }
    }

Button Action code

@IBAction func conformpickup(_ sender: LoadingButton) {
        sender.isLoading ? sender.hideLoader() : sender.showLoader(userInteraction: true)
        DispatchQueue.main.async {
            self.confirmPickUpbtn.backgroundColor = UIColor(hexString: "#FFCF00")
        }
}

Looks like with iOS 13, calling hideLoader and showLoader crashes if not called from main thread.

STEPS

1. Call hideLoader from background thread. aka when you return from an API async

specifically these 2 lines:

EXPECTED:

• hideLoader's UI calls would be wrapped in a DispatchQueue.main.async { } , so that the callers don't need to do that?

ACTUAL:

• they're not, so it crashes if not called from the main thread

SwiftUI Version

Wouldn't happen to have a working SwiftUI version? Great job by the way 👍

Build and archive problem

It works fine in Simulator,When trying to build and archive with generic ios device,it's giving the following error
Could not find module 'LoadingButtons' for target 'arm64-apple-ios'; found: x86_64-apple-ios-simulator, x86_64.Added x86_64 in valid architectures but it's not working

button background color change

Hi,
I am using this pod when i click the button background color is changed but i don't want change the background
color