Comments (12)
I see that cnum+1 is no longer used in trac 1.0 and from what I see, we use trac 1.0.1
https://github.com/edgewall/trac/blob/trunk/trac/ticket/model.py#L313
so we need to update the trac-post-commit-hook
I think that the latest script is called commit_updated
Trac upgrade documentation state
Note that if you were using the `trac-post-commit-hook`, ''you're strongly advised to upgrade it'' to the new hook documented in the above references and [TracWorkflow#Howtocombinethetracopt.ticket.commit_updaterwiththetestingworkflow here], as the old hook will not work with anything else than the default repository and even for this case, it won't trigger the appropriate notifications.
See full doc here https://twistedmatrix.com/trac/wiki/TracUpgrade
So to fix this I think that we should use the new commit hook
What do you think?
from trac-config.
from trac-config.
OK. So all steps, beside step 5 were done ? I have no idea what is the progress of trac upgrade and how can I help.
Any tips are much appreciated.
Thanks!
from trac-config.
OK. So all steps, beside step 5 were done ?
Unfortunately, I don't know the answer to that question. I wasn't directly involved in the migration. @glyph or @dreid perhaps know.
from trac-config.
@adiroiban as far as I know, all the steps were done.
However, the Subversion repository is on a different host, so if step 5 (copying static website content!?) is what is supposed to update the post-commit hook, perhaps we need to copy it to a different server.
from trac-config.
On the wiki page linked by Tom Prince, step 5 is
- Updates post-commit hook.
From what I can see in this repo and errors on svn.twistedmatrix.com the old hook is still used.. the one using cnum... the old hook is also present in this repo.
It needs to be updated with a newer version like https://github.com/edgewall/trac/blob/eb4c4b586628b3d1262465cce7474346a213a27a/tracopt/ticket/commit_updater.py as documented in Trac Upgrade doc https://twistedmatrix.com/trac/wiki/TracUpgrade
I took a look at this repo but could not find out how the hook is copied and where the hook is copied... there are so many repos in twisted-infa project, that I am lost :(
from trac-config.
I took a look at this repo but could not find out how the hook is copied and where the hook is copied...
The setup of the wolfwood (the vcs server, also known as svn.twistedmatrix.com
or code.twistedmatrix.com
) was never automated. The svn hooks live here (in bzr still).
The post commit hook calls trac-post-commit-pb-client. That uses PB to talk to a server (started here) that calls trac's post-commit hook. The last is based on the old upstream hook, but customized to add some more fields and recognize the commit format we use.
there are so many repos in twisted-infa project, that I am lost :(
Sorry about that. When I was writing much of the automation, I think most of the documentation end up more as notes to myself, rather than as something that makes it easy for other people to pick-up. 😦 Feel free to ask questions, either here or on #twisted-admin
and I'll answer as I can.
from trac-config.
Thanks for the info. For my point of view I should not about the whole chain based on which trac-post-commit-hook is called. I am happy to know that it is called.
Since this is based on on old version, it needs to be updated.
The git history does not help me https://github.com/twisted-infra/trac-config/commits/master/trac-post-commit-hook
Is there a list with those "more fields" ? Is there any info regarding what is different in Twisted commit format ?
AFAIK twisted uses the standard commit format fixes #1111 / ref #2344 being recognized by the script.
I will try to find the upstream old version and then compare with current one to see what was changed... so that I can apply the same changes on current upstream version.
from trac-config.
The git history does not help me https://github.com/twisted-infra/trac-config/commits/master/trac-post-commit-hook
If the history is not in git, it might be in bzr. Or maybe not. Before braid existed, not all of twisted's infrastructure was version controlled.
Is there a list with those "more fields" ? Is there any info regarding what is different in Twisted commit format ?
There is at least the branch and author handling, for new branches.
from trac-config.
I got it http://bazaar.launchpad.net/~twisted-dev/twisted-trac-integration/trunk/view/head:/trac-hooks/trac-post-commit-hook ... but it does not have a great history.
I should be able to find the upstream hook and compare the changes.
Will come back with a patch.
Thanks!
from trac-config.
Made some progress. I think that this is the source... there is also re-open action. https://raw.githubusercontent.com/edgewall/trac/0.11-stable/contrib/trac-post-commit-hook
from trac-config.
moved to twisted-infra/braid#123
from trac-config.
Related Issues (14)
- clearly indicate to users where they should file bugs for operational issues HOT 2
- display a link to a "coverage report" in ticket summary so we can look at code coverage for a branch in review easily HOT 1
- site meter icon doesn't load under HTTPS HOT 1
- Tickets cannot be unassigned HOT 10
- Set author and remove review when a branch is merged HOT 2
- Migrate / clean Launchpad project HOT 3
- use HTML-form-based authentication HOT 1
- use database-backed password storage instead of file-backed HOT 5
- Show the review requestor name and review request date in report15 HOT 3
- upgrade trac HOT 3
- weekly bug summary email config is missing HOT 1
- trac.restart is unreliable, leaves trac not running HOT 1
- ticket delete admin function breaks timeline if deleted ticket had attachment HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trac-config.