twisted-infra/trac-config

DISUSED. See twisted-infra/braid.

trac-config's Issues

Tickets cannot be unassigned

There is no longer an empty entry in the "assign to" dropdown on the ticket metadata form. This seems to make it impossible to make a ticket owned by no one. This breaks the ticket workflow (which is for tickets up for review to be assigned to no one).

upgrade trac

We are using a super old version of Trac.

There are many issues with it, and with its plugins.

I don't know if upgrading Trac would actually let us address any of those issues directly - commenters on this issue are encouraged to help build up a list of links to those things - but a more recent version would allow us to more productively work with the Trac team to get some of these things addressed.

ticket delete admin function breaks timeline if deleted ticket had attachment

the result of deleting a ticket which had an attachment is that /trac/timeline (at least) begins to start rendering as a 404 announcing that the deleted ticket does not exist.

this is caused by the existence of a row in the attachments table for the deleted ticket

clearly indicate to users where they should file bugs for operational issues

Copied from https://bugs.launchpad.net/twisted-website/+bug/1140776

Right now the only thing on the web site suggesting a way to report a problem - with Twisted, with the web site, with the software itself - is the "new ticket" link in the navbar. The fact that one should use the Twisted website for reporting issues with the Twisted website is further reinforced by the presence of the open "website" component.

As per this discussion: http://twistedmatrix.com/trac/ticket/6329?#comment:5 we should really indicate that issues with Trac-as-deployed should be in github:twisted-infra.

Also, the website component should be closed so that folks don't file new bugs in it.

weekly bug summary email config is missing

the cron job that sends this email isn't configured by braid

also the cron job uses chronic which isn't installed by braid

trac.restart is unreliable, leaves trac not running

(TwistedAdmin)exarkun@top:~/Projects/braid$ fab trac.restart
No hosts found. Please specify (single) host string for connection: twistedmatrix.com
[twistedmatrix.com] run: ~/bin/stop
[twistedmatrix.com] run: ~/bin/start
[twistedmatrix.com] out: Another twistd server is running, PID 29236
[twistedmatrix.com] out:
[twistedmatrix.com] out: This could either be a previously started instance of your application or a
[twistedmatrix.com] out: different application entirely. To start a new one, either run it in some other
[twistedmatrix.com] out: directory, or use the --pidfile and --logfile parameters to avoid clashes.
[twistedmatrix.com] out:
[twistedmatrix.com] out:

Fatal error: run() received nonzero return code 1 while executing!

Requested: /bin/start
Executed: /bin/bash -l -c "/bin/start"

Aborting.
Disconnecting from [email protected]... done.

use HTML-form-based authentication

We're currently using HTTP basic auth, which is terrible for a bunch of reasons, one of them being that browsers make "logout" challenging, and another is that password managers don't work well with them. I think we can just get rid of TwistedAuthenticator entirely when we do that.

site meter icon doesn't load under HTTPS

https://twistedmatrix.com/trac/ at the bottom right in the footer there is a 404 image

display a link to a "coverage report" in ticket summary so we can look at code coverage for a branch in review easily

It's too easy to miss coverage changes when doing a review.

https://twistedmatrix.com/pipermail/twisted-python/2014-May/028287.html

Show the review requestor name and review request date in report15

Report 15 doesn't include the name of the user who submitted the review nor the date the review was submitted.
Additionally any change to the ticket causes it to be pushed to the bottom of the review list.

Here is a modified version of report 15 query which includes that info using a postgres specific SELECT DISTINCT ON clause.

New fields:

• modified (display the ticket last modified time)
• review_requestor (the trac user who last added the review keyword)
• review_count (the number of times the ticket has had the review keyword added)
• review_request_time (the time when the review keyword was last added to the ticket)

I've tested it on a very small trac instance here and it seems to work.

Can someone try it on a backup of the full twistedmatrix.com database to make sure it returns reasonably fast before we change the live site.

-- ## 15: Review Tickets, By Order You Should Review Them In ## --

-- Review tickets in this order.

SELECT
       p.value AS __color__,
       t.id AS ticket,
       summary,
       component,

       -- Hidden columns which will show up in rss and csv report
       version as _version,
       milestone as _milestone,

       t.type AS type,
       owner,
       status,
       t.time AS created,
       t.changetime as modified,
       tc.author as review_requestor,
       tc2.review_count as review_count,
       TIMESTAMP 'epoch' + INTERVAL '1 second' * tc.time as review_request_time,

       -- Hidden columns which will show up in rss and csv report
       t.changetime AS _changetime,
       description AS _description

FROM (
     SELECT * FROM
            ticket
     WHERE
           keywords LIKE '%review%'
           AND status <> 'closed'
) AS t

INNER JOIN
      enum AS p ON (p.name = t.priority AND p.type = 'priority')

LEFT JOIN (
     -- Select the row-wise maximum review request ticket change
     -- grouped on ticket id
     -- http://www.postgresql.org/docs/8.4/interactive/queries-select-lists.html#QUERIES-DISTINCT
     SELECT DISTINCT ON (ticket) * FROM
          ticket_change
     WHERE
           field = 'keywords'
           AND oldvalue NOT LIKE '%review%'
           AND newvalue LIKE '%review%'
     ORDER BY ticket, time DESC
) AS tc

ON
   (t.id = tc.ticket)

LEFT JOIN (
     -- Join ticket change again, this time to get the count which
     -- doesn't seem to be allowed with DISTINCT ON in the query
     -- above.
     SELECT
          ticket, count(*) AS review_count
     FROM
          ticket_change
     WHERE
           field = 'keywords'
           AND oldvalue NOT LIKE '%review%'
           AND newvalue LIKE '%review%'
     GROUP BY ticket
) AS tc2

ON
   (t.id = tc2.ticket)

ORDER BY
   review_request_time ASC

Set author and remove review when a branch is merged

As commit messages should be in the format

Merge <branch name>: Brief description

Author: <comma_separated_names>
Reviewer: <comma_separated_names>
Fixes: #<ticket number>

we should be able to extract the author from commit message.

I assume that we can change the doc to state that main author should be listed first.

I assume that I will need to work on this

https://github.com/twisted-infra/trac-config/blob/master/trac-post-commit-hook

---

Is there a staging trac/svn instance where we can test this?

For my project I have a staging trac instance so I can use it during development and testing and will write unit tests

Fix post commit hook when saving trac ticket changes

I see this the log

I think that in some cases cnum is int instead of string... will investigate

+ /svn/Twisted/hooks/trac-post-commit-pb-client 43738 adiroiban 'Branching to core-test-names-7666.' twistedmatrix.com 38159
2015-01-24 10:27:36-0700 [-] Log opened.
2015-01-24 10:27:36-0700 [-] Starting factory <twisted.spread.pb.PBClientFactory instance at 0x8ccaf2c>
2015-01-24 10:27:37-0700 [Broker,client] postCommit result Traceback (most recent call last):
2015-01-24 10:27:37-0700 [Broker,client]   File "/srv/trac/config/trac-post-commit-hook", line 188, in __init__
2015-01-24 10:27:37-0700 [Broker,client]     ticket.save_changes(self.author, self.msg, self.now, db, cnum+1)
2015-01-24 10:27:37-0700 [Broker,client]   File "/srv/trac/.local/lib/python2.7/site-packages/trac/ticket/model.py", line 366, in save_changes
2015-01-24 10:27:37-0700 [Broker,client]     return int(cnum.rsplit('.', 1)[-1])
2015-01-24 10:27:37-0700 [Broker,client] AttributeError: 'int' object has no attribute 'rsplit'
2015-01-24 10:27:37-0700 [Broker,client] Unexpected error while processing ticket ID 7666
2015-01-24 10:27:37-0700 [Broker,client] 
2015-01-24 10:27:37-0700 [Broker,client] Stopping factory <twisted.spread.pb.PBClientFactory instance at 0x8ccaf2c>

Migrate / clean Launchpad project

From #14 (comment)

Already in the plan: https://bugs.launchpad.net/twisted-trac-integration/+bug/1312424

https://github.com/termie/lp2gh is a good place to start.

Also see: #14 (comment)

The most of the stuff remaining in twisted-trac-integration probably doesn't actually want to be in trac-config (except maybe the weekly bug report script). That repo has/had a bunch of stuff, some which has already been migrated (and I think that everything that has has been deleted. It still contains the svn-hooks, for example.

use database-backed password storage instead of file-backed

https://trac-hacks.org/wiki/AccountManagerPlugin says we can keep password data in the trac database rather than in a text file. Given that we keep having this problem where our htaccess file gets overwritten, it would be great to just not have an htaccess file at all.