twitchplayspokemon/pokemonanniversaryred

Anniversary Red dissassembly

pokemonanniversaryred's Issues

Issue with building

I've followed the steps left by Hitomi perfectly yet I'm having troubled building. Whenever I use make I get this error

File "/home/KebabTheLama/pokemonAnniversaryRed/extras/pokemontools/gfx.py", line 73
tiles = sorted(enumerate(tiles), key= lambda (i, tile): i % width)
^
SyntaxError: invalid syntax
make: *** [Makefile:79: red/audio.o] Error 1

Wrong dialogue before battling Blue/Gary/rival in Indigo Plateau (before final boss battle only)

After modifying some code and building the ROM, the after battle dialogue of the rival/Blue/Gary is printed both before and after battle. This issue doesn't appear in the 4.7.2 IPS patch released by ProjectRevoTPP nor on the 4.7.2 build.

The text that is being printed out at the wrong time is shown below (taken from /text/maps/champion.asm):

_GaryText_76103:: ; 8632f (21:632f)
    text "Why?"
    line "Why did I lose?"

    para "I never made any"
    line "mistakes raising"
    cont "my #MON..."

    para "Darn it! You're"
    line "the new #MON"
    cont "LEAGUE champion!"

    para "Although I don't"
    line "like to admit it."
    done

This affects the GaryText1 method in /scripts/gary.asm.

I already notified Pigu via Reddit about this issue and is currently investigating the issue.

EDIT: This issue appears to only affect the game if the player has completed the Pokédex, received the diploma from the Game Director, and defeated all 8 Gym Leaders in rematches. I've tested a save file from TPP Red (from season one) that was provided to me by Pigu and found out that the before and after battle texts printed out in the correct order

Compile Stack Trace

I am trying to build pokemon red anniversary from source

I git cloned this project and then git clone
https://github.com/pret/pokemon-reverse-engineering-tools/tree/698b0fc7e63d3dadf07247015e230bce145cc500

and rename the folder to "extras" since the first git clone does not automatically pull the "extras" folder.
then I follow the instructions located here:
https://github.com/TwitchPlaysPokemon/pokemonAnniversaryRed/blob/master/INSTALL.md

git clone git://github.com/iimarckus/pokered.git
cd pokered
git submodule init
git submodule update
sudo pip install -r extras/requirements.txt

the last step fails from this error:

Obtaining pypng from git+git://github.com/drj11/pypng.git@master#egg=pypng (from -r ./extras/requirements.txt (line 1))
  Cloning git://github.com/drj11/pypng.git (to master) to ./src/pypng
  Could not find a tag or branch 'master', assuming commit.
error: pathspec 'master' did not match any file(s) known to git.
Command "git checkout -q master" failed with error code 1 in /home/user/Downloads/pokemonAnniversaryRed/src/pypng

so I had to manually clone https://github.com/drj11/pypng.git and install it with 'sudo python setup.py install'
once all this is done I return to the root directory and run 'make' and I get this giant stack trace:
Traceback (most recent call last):

  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/red.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/red.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/red.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/red.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/blue.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/blue.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/blue.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/blue.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/yellow.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/yellow.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/yellow.asm'
Traceback (most recent call last):
  File "extras/pokemontools/scan_includes.py", line 51, in <module>
    main()
  File "extras/pokemontools/scan_includes.py", line 46, in main
    includes.update(scan_file(filename))
  File "extras/pokemontools/scan_includes.py", line 26, in scan_file
    for inc in scan_file("src/" + include):
  File "extras/pokemontools/scan_includes.py", line 17, in scan_file
    with open(filename) as f:
IOError: [Errno 2] No such file or directory: 'src/yellow.asm'
Traceback (most recent call last):
  File "extras/pokemontools/gfx.py", line 7, in <module>
    from . import png
ValueError: Attempted relative import in non-package
Makefile:79: recipe for target 'red/text.o' failed
make: *** [red/text.o] Error 1

Does anyone know what I'm doing wrong?

I'm using rgbds 0.3.8 (https://github.com/rednex/rgbds/releases/tag/v0.3.8) because the latest version as of writing this post causes a different build error.

Vending Machine script is broken

This problem is caused by one of the changes during the run about adding NPCs who sells all of TMs. As a result, you can't progress the game normally unless you hacked in your inventory or used Pokemon Stadium to manually transfer the drinks. Moreover, this problem caused a recall of Patch 4.7.2 cartridges.

More information here.

Game freezes when you read sign in Celadon Dept. Store 4F

I discovered this serious but not game-breaking bug just recently while I was doing a normal gameplay test run of TPP Version 4.7.3 and it never happened before this patch. This affects both the clean copy of the patch and my 4.8 patch.

Looks like we have to impeach Revo again! Kappa

Edit: I posted pictures of the glitch and the same sign's original behavior here

Build Error

Getting the following build error:

rgbasm -h -o red/main.o red/main.asm
ERROR: red/main.asm(2) -> main.asm(15) -> home.asm(171) -> home/overworld.asm(1982):
    syntax error
error: Assembly aborted (1 errors)!
Makefile:79: recipe for target 'red/main.o' failed
make: *** [red/main.o] Error 1

I used 'make' in the source directory

Teh Urn credits desynchronized with music

The new 4.7.3 patch works perfectly without any flaws so far, except TEH URN credits aren't really syncronized with the music. The music ended way before the screen shows "Thanks for watching!" (Around the Special Thanks screen)

To solve this, I adjusted the delay time between scrollers from 300 to 260 at line 354 of 151hack/animations.asm to make the "Thanks for watching" image to appear roughly at the right time like in previous versions. Please make a new commit to fix this minor error.