Unavoidable "[Importer$] Expected to find just 1 match" warnings in sbt sub-project builds

[rtyley]

Unavoidable "[Importer$] Expected to find just 1 match" warnings in sbt sub-project builds

[muuki88]

Next scrooge sbt version will have a setting to disable this

scroogeThriftIncludeRoot := false

[felixbr]

Until the fix (#345) is merged and released, you can use the same workaround I used in our internal sbt-plugin to at least silence the warning:

  private val importerLogger = java.util.logging.Logger.getLogger("com.twitter.scrooge.frontend.Importer$")
  importerLogger.setLevel(java.util.logging.Level.OFF)

It's hacky but the best solution I could find for the time being 🙂

[jstultz]

I am not sure that the issue here is really that the root folder is included by default, but rather with the way absolute paths are handled. Any DirImporter will successfully resolve an absolute path, and when compiling a thrift file, it is the first file that the importer(s) resolve, and is going to be an absolute path. So while not including the root directory as an importer will solve this for some projects, it will still result in spurious warnings any time that a project has scroogeThriftIncludes with more than one entry (which would, I believe, be any project that has any dependencies in the thrift configuration?)

I believe conditioning the warning on a check like this would suffice to solve the problem more generally:

scrooge/scrooge-generator/src/main/scala/com/twitter/scrooge/frontend/Importer.scala

Lines 87 to 88 in 76504ba

	val file = new File(filename)
	if (file.isAbsolute)

[jstultz]

(if others agree, I'd be happy to submit a PR)

[csaltos]

I've added Compile / scroogeThriftIncludeRoot := false to the Thrift configuration subprojects and it's working for me ... thank you very much for the fix and workarounds.

[niodice]

Also seeing this quite a bit. I tend to ignore it and I always see the correct behavior in the generated code. This makes me think that @jstultz is correct in that these are spurious warnings.

Anyone maintainers have more context here?