scrooge-generator: Update Apache Thrift `Processor.process` signature

[Marcono1234]

scrooge-generator: Update Apache Thrift `Processor.process` signature

[jyanJing]

Added some documentation to Scrooge doc, Github should be able to update the doc soon. thank you again for your suggestion!

[mosesn]

Thanks, we've updated the documentation! https://twitter.github.io/scrooge/CodeGenDep.html We're going to close this ticket for now, but it's still on our radar to upgrade the version of Thrift that we're targeting in the future.

[jyanJing]

Hi @Marcono1234, thanks for reaching out to us! Our internal version for Apache Thrift is 0.10.0, upgrading the version to 0.13.0 will be a big effort especially given the breaking changes in the new API, so far I am not aware we have plans for the upgrade. Would you be able to work with Apache Thrift 0.10.0?

[Marcono1234]

Thanks for the fast response!
I mainly wanted to point this out in case you were not aware of these changes to the Thrift API. It is not blocking me.
Feel free to close this issue if you don't plan to upgrade the Thrift version used internally by you any time soon.

Edit: But maybe it would be good to mention this recommended Thrift version in the documentation. I did not notice it being mentioned anywhere. https://twitter.github.io/scrooge/CodeGenDep.html might be a good place to mention it.

[jyanJing]

Thank you for raising this issue to us, it is great to hear that you are not blocked, let's keep this open so it is on our radar!
Re: documentation, good point, I will have a patch to mention the version in the doc.