twostraws/hackingwithreact

The project source code for hackingwithreact.com

hackingwithreact's Issues

Chapter 20 unescaped <button> tag

In chapter 20 (http://www.hackingwithreact.com/read/1/20/refactoring-our-state-code-passing-parameters-in-onclick) There is an unescaped button tag which means the rest of the page is wrapped inside one massive button. Its just after "(Note: I split the ".

1 test failed

Routing broken in latest (~March 14th) iteration?

Steps to reproduce:

1. Clone, npm i, webpack-dev-server
2. Navigate to http://localhost:8080
3. Click the react link
4. Expect the react feed to load
5. Replace /react with /react-native in the address bar & hit Enter
6. Expect react native feed to load, but note that it does not

This just worked yesterday for me (I have links to /react, /react-native, and /jest on each page) and after updating this morning, it's no longer working. What has changed? I know a couple of dependencies were upgraded, could that be the issue?

I confirmed this in both my own app and a fresh clone of the author's (this) app.

Edit: I just found that if you follow the instructions to reproduce listed above, then click in the address bar and hit Enter again, the page reloads, loading the appropriate feed. It seems like something isn't getting fired when the user navigates to one of the feed pages for the first time for some reason.

manually calling a React.PropTypes function for the `path` prop on `Route`

Warning: You are manually calling a React.PropTypes validation function for the path prop on Route. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library.
See https://fb.me/react-warning-dont-call-proptypes for details

I understand that that is problem with react-router, i am using react-router 3.0.0 and react 15.3.2