txmodxoops/tdmcreate

tdmcreate-1.91

tdmcreate's Issues

generated pdf.php is full of errors

Several language constants are missing

Missing generic font name

Font property font-family does not have generic default at line 40:

font-family: Verdana, Tahoma;

Please change by adding: "sans-serif"

font-family: Verdana, Tahoma, sans-serif;

Default values for fields are not being saved

see https://github.com/txmodxoops/TDMCreate-1.91-alpha-1/issues/7

Bugs

I just tried to generate a module with the latest version from GitHub, but got bunch of errors (see below).

One of the issues was that TDMCreate generated this line in /admin/index.php:

include header .'/.php';

( ! ) Notice: Use of undefined constant header - assumed 'header' in C:\wamp64\www\257tdmc191\modules\zumba5\admin\index.php on line 22
Call Stack

Time Memory Function Location

1 0.0004 275528 {main}( ) ...\index.php:0

( ! ) Warning: include(header/.php): failed to open stream: No such file or directory in C:\wamp64\www\257tdmc191\modules\zumba5\admin\index.php on line 22
Call Stack

Time Memory Function Location

1 0.0004 275528 {main}( ) ...\index.php:0

( ! ) Warning: include(): Failed opening 'header/.php' for inclusion (include_path='.;c:\php\includes;C:\wamp64\www\zend1\library\Zend;C:\wamp64\www\symfony1\lib;C:\wamp64\www\symfony1\data\bin') in C:\wamp64\www\257tdmc191\modules\zumba5\admin\index.php on line 22
Call Stack

Time Memory Function Location

1 0.0004 275528 {main}( ) ...\index.php:0

( ! ) Notice: Undefined variable: topicsHandler in C:\wamp64\www\257tdmc191\modules\zumba5\admin\index.php on line 25
Call Stack

Time Memory Function Location

1 0.0004 275528 {main}( ) ...\index.php:0

( ! ) Fatal error: Call to a member function getCount() on null in C:\wamp64\www\257tdmc191\modules\zumba5\admin\index.php on line 25
Call Stack

Time Memory Function Location

1 0.0004 275528 {main}( ) ...\index.php:0

Wrong link to forum support

Wrong link to forum support

tdmcreate/templates/admin/tdmcreate_footer.tpl
line 6

replace:

<a href='http://xoops.org/forums/newbb' title='Visit Support Forum' class='tooltip' rel='external'>Support Forum</a></div>

with:

<a href='http://xoops.org/modules/newbb/' title='Visit Support Forum' class='tooltip' rel='external'>Support Forum</a></div>

Thanks! :-)

editorHandler in xoops_version.php

// Editor Array xoops_load('xoopseditorhandler'); editorHandler = XoopsEditorHandler::getInstance();

The '$' is missing for 'editorHandler'

Fatal error: Class 'TDMCreateFormTabTray'

Module tab patient not editable

Using TDMCreate I create a module name eclinic. Everything created and installed fine without error. eclinic a simple module with 4 fields. I can add new record. I added 3 records, but when I try to edit a record. It shows the add new record.

Reference mismatch, copy will be dispatched into function

See here:
http://jpauli.github.io/2014/06/27/references-mismatch.html

Undefined function update_system_v10 (in /include/update.php

Missing "switch"

Duplicate License entry in xoops_version.php

'license' => "GPL 2.0 or later",
'help' => "page=help",
'license' => "GNU GPL 2.0",

wrong code generated for class

During code generation, the value of $ucfTableFieldname is missing here:
public function get{$ucfTableFieldname}FromId(${$tableFieldname}Id)

so you're getting this:

Also, please replace intval() with (int)

Use XoopsRequest

Instead of:

$id = isset($_GET['id']) ? (int) ($_GET['id']) : 0;

let's use:

$id = XoopsRequest::getInt('id', 0, 'GET');

Errors when attempting to build a module

I very much appreciate your efforts to develop this module, but as we've talked about it before, you need to improve your testing.
Have you installed it as a new module and tested it? It's possible that it was working on your installation that you had, but it's important that you install it fresh on another XOOPS installation and test it there.
And think "Codeception" :)

include/common.php

Hi

an example of a module I created with tdmcreate:
`if (!defined('WGXPIWIK_MODULE_PATH')) {
define('XOOPS_ICONS32_PATH', XOOPS_ROOT_PATH . '/Frameworks/moduleclasses/icons/32');
define('XOOPS_ICONS32_URL', XOOPS_URL . '/Frameworks/moduleclasses/icons/32');
define('WGXPIWIK_DIRNAME', 'wgxpiwik');
define('WGXPIWIK_PATH', XOOPS_ROOT_PATH.'/modules/'.WGXPIWIK_DIRNAME);
define('WGXPIWIK_URL', XOOPS_URL.'/modules/'.WGXPIWIK_DIRNAME);
define('WGXPIWIK_ICONS_PATH', WGXPIWIK_PATH.'/assets/icons');
define('WGXPIWIK_ICONS_URL', WGXPIWIK_URL.'/assets/icons');
define('WGXPIWIK_IMAGE_PATH', WGXPIWIK_PATH.'/assets/images');
define('WGXPIWIK_IMAGE_URL', WGXPIWIK_URL.'/assets/images');
define('WGXPIWIK_UPLOAD_PATH', XOOPS_UPLOAD_PATH.'/'.WGXPIWIK_DIRNAME);
define('WGXPIWIK_UPLOAD_URL', XOOPS_UPLOAD_URL.'/'.WGXPIWIK_DIRNAME);
define('WGXPIWIK_ADMIN', WGXPIWIK_URL . '/admin/index.php');
$local_logo = WGXPIWIK_IMAGE_URL . '/wedega.png';
define('WGXPIWIK_PIWIK_CONFIG_INI', WGXPIWIK_PATH.'/piwik/config/config.ini.php');

}`

now two questions:

1. WGXPIWIK_MODULE_PATH will not be define within the if-condition, so this if-block will always be executed
   a) we can remove the condition, or
   b) we use in the condition a defined var (eg. WGXPIWIK_PATH instead of WGXPIWIK_MODULE_PATH

2. if you have more than one module created by tdmcreate, you get the notice "Constant XOOPS_ICONS32_PATH already defined....
   we should use
   if (!defined('XOOPS_ICONS32_PATH')) define('XOOPS_ICONS32_PATH', XOOPS_ROOT_PATH . '/Frameworks/moduleclasses/icons/32'); if (!defined('XOOPS_ICONS32_URL')) define('XOOPS_ICONS32_URL', XOOPS_URL . '/Frameworks/moduleclasses/icons/32');

print.php

tdmcreate creates a print.php on module level. If you look into the code you can see
`// Verify that the article is published

$testtables = $1->get($ttId);

// Verify permissions`

can someone tell me what should be there instead of '1'

Single quotes

Let's use single and double quotes when appropriate. If we’re not evaluating anything in the string, let's use single quotes.
So this:

will become this:

I'll have to do the same in other modules, as in the past I didn't pay attention to it.

delete code in admin pages

when creating the php code of admin pages function getXoopsCodeCaseDelete is used instead of function getAdminPhpCodeDelete

getXoopsCodeCaseDelete has errors inside
getAdminPhpCodeDelete has no errors

Wrong links to spinner.gif

in /tdmcreate/admin/modules.php

you have a wrong link to the spinner.gif image resulting in this:

You need to change from this:

//        $GLOBALS['xoopsTpl']->assign('sysPathIcon32', $sysPathIcon32);

to this:

$GLOBALS['xoopsTpl']->assign('modPathIcon16', TDMC_URL.'/'.$modPathIcon16);

getConfig() error

Hi,
I have created one table as category and one is standard.
With the category everything works fine. When I try to create a item in the second table i get following error
Notice: Undefined variable: countdown in file /modules/module1/admin/footer.php line 24
Error: Error: Call to a member function getConfig() on null in file /modules/module1/admin/footer.php line 24
This occurs after you create the first item.

I am using xoops 2.5.9

Permissions are not saved

I set permissions, save them, receive a message that they are saved, but when I open it again, the permissions are empty again.

Typos in function names

Also lack of consistency in naming functions: Here we have:

zumba_MygetItemIds

while in others places we have:

ZUMBA_MygetItemIds

Roadmap: Alpha 3 Bootstrap Templates

Alpha 3 Implements Bootstrap Code in Templates Modules

templates system_bookmarks.tpl and system_fbcomments.tpl

Hi

If I create a new module, the templates system_bookmarks.tpl and system_fbcomments.tpl will be implemented in ..._footer.tpl by

<{if $bookmarks != 0}>
<{include file="db:system_bookmarks.html"}>
<{/if}>

<{if $fbcomments != 0}>
<{include file="db:system_fbcomments.html"}>
<{/if}>

but normally in the current xoops core system these templates are not available.

How to solve?

Undefined function ZUMBA_MygetItemIds in visit.php

missing define to be added

There are 3 missing define:

1 - Donation Amount

tdmcreate/include/functions.php
Line 116 and line 123

2 - is maintained by the

tdmcreate/template/admin/tdmcreate_footer.tpl
Line 5:
<strong><{$module_name}></strong> is maintained by the

3 - Support Forum

tdmcreate/template/admin/tdmcreate_footer.tpl
Line 6:
<a href='http://xoops.org/forums/newbb' title='Visit Support Forum' class='tooltip' rel='external'>Support Forum</a></div>

Test in various ways

I need to know how the modules are created with database or not, and what kind of module you want to create.

I need a hand to create the pages of the file in front-end type of bootstrap code.

Most likely all the files that contain the same codes will be merged into one or at least one that contains several functions or methods in the same file.

They welcome suggestions for improving this module 🎱

Tabs used in source

Please do not use tabs in source code. We need to follow PSR-2 code style

Run you code through CS-Fixer before you upload it to GitHub:
https://github.com/FriendsOfPHP/PHP-CS-Fixer

bug in admin/settings.php

save "setting" returns error: Undefined index: set_type in file /modules/tdmcreate/admin/settings.php line 135
in the form is not defined what set_type should be?????

Bugs in generated templates for tables

For table news the code generated in: /mymodule/templates/mymodule_news.tpl
line 11: <{foreach item= from=$news}>
line 14: <{include file="db:zumba_news_list.tpl" list=$}>
line 17: <{if $.count eq $divideby}>

Missing names for variables

It seems like that when I don't use prefixes for tables, you're missing names in the variables:

C:\wamp64\www\257tdmc191\modules\zumba3\print.php

C:\wamp64\www\257tdmc191\modules\zumba3\index.php