Giter Site home page Giter Site logo

mongorecord's People

Contributors

tyohan avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

mongorecord's Issues

Small bug in getConnection

Line 30 of MongoDbConnection:
$this->_dbConnection->$db->authenticate($this->_user, $this->_password);
Should be:
$this->_dbConnection->db->authenticate($this->_user, $this->_password);

PHP: 5.3.3-7
Yii: 1.1.8

Am I right, or am I missing something?

Best regards,

Niels

Few critical issues

Hey, i've found that You have few critical issues...

in MongoRecord::getAttributes
You're returning $this->$doc witch is actually implicit array to string conversion...

in MongoRecord::insert and update you forgot about firing event beforeSave() user defined beforeSave method will never be executed because of this

in MongoRecord::instantiate you're firing afterFind event on wrong model $this in this scope is a search model, instead of $this->afterFind() you should fire $model->afterFind(), otherwise user defined afterFind method will modify wrong data!

and hint for MongoRecord::getCollection you can use shorthand syntax: return $this->db->{$this->collectionName}; instead of allocating new var

Best Regards,
Darius

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.