typicms/core

Core

This is the core of TypiCMS, a multilingual CMS based on the Laravel framework.

core's Issues

FileObserver saving() method

I'm not sure if you can replicate this at all, but for me, with most modules, FileObserver()'s saving method is getting called erratically.

updated and deleted are getting called consistently, just not saving for some reason.
I tried disabling caching, but that didn't have any noticeable effect.

For example with the Pages module, saving isn't called when content from the wysiwyg editor is changed, but it is called when the no_cache val is changed.
And yet saving is called when the sort order of the pages is altered (from the admin index).

I'm stumped. Any advice would be appreciated.

Thanks.

Here's a quick video of what I'm seeing..
https://www.dropbox.com/s/yp60e3rek40mm3x/ObserverNotObserving.mov?dl=0

general question

Hi!

Thank you for all your work!
I've been going through your menu / menulink packages and really have been learning a lot from them,

I do have a question: in you repositories you use ...

        $query = $this->make($with);

        if (! $all) {
            $query->online();
        }

I do not understand the online() part.
Where is this coming from?

Thanks!

Migration File: 2022_06_04_035517_create_menus_tables.php

SQLSTATE[HY000]: General error: 1824 Failed to open the referenced table 'typicms_pages' (SQL: alter table `typicms_menulinks` add constraint `typicms_menulinks_page_id_foreign` foreign key (`page_id`) references `typicms_pages` (`id`) on delete cascade)

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:742
    738▕         // If an exception occurs when attempting to run a query, we'll format the error
    739▕         // message to include the bindings with SQL, which will make this exception a
    740▕         // lot more helpful to the developer instead of just the database's errors.
    741▕         catch (Exception $e) {
  ➜ 742▕             throw new QueryException(
    743▕                 $query, $this->prepareBindings($bindings), $e
    744▕             );
    745▕         }
    746▕     }

      +9 vendor frames 
  10  database/migrations/2022_06_04_035517_create_menus_tables.php:38
      Illuminate\Support\Facades\Facade::__callStatic()

      +33 vendor frames 
  44  artisan:37
      Illuminate\Foundation\Console\Kernel::handle()
      ```

Full page caching

Hi Samuel,
I was trying to make the full page caching work. I found how to switch it on in the config etc but didn't find how to actually use the cached pages. So I came up with this in the .htaccess:

# Handle Full Page Caching...
RewriteCond %{REQUEST_FILENAME} ^(.*/)(.*)$
RewriteRule ^(.*)$ - [E=BASE:%1]

# RewriteCond %{HTTP_COOKIE} !laravel_session=([^;]+)       # this can be used if you have a frontend login or something else which alters the layout
RewriteCond %{REQUEST_METHOD} GET                           # serve cached version only for GET requests
RewriteCond %{ENV:BASE}/html%{REQUEST_URI} -f               # check if there is a cached file which matches the request
RewriteRule ^ html%{REQUEST_URI} [L]

# RewriteCond %{HTTP_COOKIE} !laravel_session=([^;]+)       # this can be used if you have a frontend login or something else which alters the layout
RewriteCond %{REQUEST_METHOD} GET                           # serve cached version only for GET requests
RewriteCond %{ENV:BASE}/html%{REQUEST_URI}/index.html -f    # check if there is a cached index.html file which matches the request
RewriteRule ^ html%{REQUEST_URI}/index.html [L]
# Handle Full Page Caching...

Do you use another approach or does this look right?
Nasko

Migration File: 2022_06_04_035517_create_files_table.php

at database/migrations/2022_06_04_035517_create_files_table.php:26
22▕ $table->string('mimetype', 100)->nullable();
23▕ $table->unsignedInteger('width')->nullable();
24▕ $table->unsignedInteger('height')->nullable();
25▕ $table->unsignedInteger('filesize')->nullable();
➜ 26▕ $table->json('title')->default(new Expression('(JSON_OBJECT())')->default(new Expression('(JSON_OBJECT())')));
27▕ $table->json('description')->default(new Expression('(JSON_OBJECT())')->default(new Expression('(JSON_OBJECT())')));
28▕ $table->json('alt_attribute')->default(new Expression('(JSON_OBJECT())')->default(new Expression('(JSON_OBJECT())')));
29▕ $table->unsignedTinyInteger('focal_x')->nullable();
30▕ $table->unsignedTinyInteger('focal_y')->nullable();```

Call to undefined method Maatwebsite\Sidebar\SidebarManager::build() (View: */resources/views/vendor/core/admin/master.blade.php)

Hi,
after last composer update i have this error in every admin views (I installed TypiCms this morning and it worked before update)

Thanks

Laravel 5.2.16 breaks API

Not sure if you've ran composer update lately but after updating from laravel/framework v5.2.14 -> v5.2.16 I started getting this exception...

https://gist.github.com/eahrold/e60a70206696b772cf5e

In composer.json explicitly declaring "laravel/framework": "5.2.14", fixes the issue

Composer keeps publishing the core.

Wasn't sure exactly where to put this issue, figured here was as good a place as any.
I've published the Core module, which on the initial publish removed it from the vendor folder, as expected. But now when I run composer update, or add another package, it actually reinstalls the core package in the vendor folder, which ends up taking precedence over the published version.

I suspect it's due to the other modules having the "Core" required, and composer not detecting the published "core".