uber-common/larch

A reservoir sampling logging framework

larch's Issues

Remove the reservoir before bootstrap

Replacing logtron in a process with larch leads to some interesting issues during errors in the startup phase. Typically we disallow constructors to have global side-effects, which includes starting a timer. If an error occurs before larch is bootstrapped, any logs for that error get swallowed by larch.

I think it makes sense to remove the reservoir before bootstrap so that these logs can escape the process. In my use case I was synchronously validating a configuration file and logging the validation errors as part of the service constructor. The fact that larch swallows these logs resulted in me moving the validation to the init phase instead of the constructor, which is not ideal.

We need an appropriate way for these logs to escape the process. With logtron we can log to a file or stdout if opted for. I can live without any stateful backends being available before the logger is bootstrapped, but side-effects cannot be a prerequisite for logging any information.