Browserify transform in package.json causes build errors

[ubilabs]

Browserify transform in package.json causes build errors

[ro-ka]

Thanks, I knew there was a reason! Reverted it for now, but will leave this ticket open and review the build process later, no time right now. New (fixed) release is 1.3.0 on npm.

[zallek]

Adding reactify in dependencies leads that the package will be included in the final bundle whereas it's only needed for compilation.
Was working fine with reactify in devDependencies with webpack at least.

[ro-ka]

Already moved it back to the dependencies, update to 1.3.0. Will verify the build process and check how to preprocess this later.

[idolize]

@ro-ka Thanks!

@zallek Yes, having it in devDependencies is best, but the problem is that it will fail hard for anyone bundling their code with Browserify (webpack will work fine, but clearly not everyone out there uses the same build tools). Keeping it in dependencies is just a temporary workaround for a larger problem.

The best solution is to take the transform out of package.json, so Browserify never attempts to perform a transform after downloading it from npm (that feature is not needed here). The transform can still be performed as part of the build before publishing to npm through the prepublish section in scripts of package.json, or as part of the Gulp build task—at this point it will be safe to keep reactify in devDependencies instead of dependencies.

[idolize]

@ro-ka If you are looking for a good JSX transpilation tool to add to prepublish, I'd recommend Babel.

This script should replicate your current build structure without using reactify:

"scripts": {
  "prepublish": "babel ./src --out-dir ./dist",
},
"devDependencies": {
  "babel": "*"
}

Also, as an aside, you may want to add a .npmignore file to keep the src directory out of npm. More info on this subject here.

[ro-ka]

I know, using babel in many other projects. Just no time right now to change the build process. Will do so next week, hopefully!

[ro-ka]

Fixed and released as 1.4.0.

[idolize]

@ro-ka Thanks! Unfortunately, I'm getting errors trying to require this now with 1.4.0 released. First glance looks like it's because the main section of package.json points to "module/Geosuggest.js", but I don't see this file in my latest npm install.

Are you sure all compiled files were included in your npm publish?

[ro-ka]

Ah… https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package
Will fix, sorry!

[ro-ka]

Fixed in 1.4.1. Thanks for the feedback! Does it work now?

[idolize]

@ro-ka I updated and now I'm seeing a different error:

Cannot find module './GeosuggestItem.jsx' from '/node_modules/react-geosuggest/module'