Giter Site home page Giter Site logo

Comments (8)

ro-ka avatar ro-ka commented on July 18, 2024

When you install with npm, there should be a module folder which contains the code. Not the ES6 source code, but the ES5 compiled code.

I’m not sure why it shouldn’t work with React 0.14. Is there any error thrown?

There is no official changelog yet, so I won’t make changes now. But there will be an update when React 0.14 is released officially.

If you find out what causes the problems, let me know!

from react-geosuggest.

TylerBrock avatar TylerBrock commented on July 18, 2024

bump

from react-geosuggest.

ro-ka avatar ro-ka commented on July 18, 2024

Did someone fine out what’s wrong? The module folder should be in an npm install and be loaded.

from react-geosuggest.

leoasis avatar leoasis commented on July 18, 2024

I think the problem the user is having is when installing via npm with the path pointing to the forked repo url. Since the modules dir is not in git (is created in a task before publishing the package) it does not appear in node_modules after npm install. Also the rest of the files in .npmignore are, well, ignored as well so it only contains the package.json and some other files.

So, to sum up, it should work as is with React 0.14 (after a version bump in the peer dependencies, @ro-ka), and @boosh in your fork you need to add the modules folder as part of your git repo and push the built bundle.

from react-geosuggest.

ro-ka avatar ro-ka commented on July 18, 2024

So the peer dependency got bumped to 0.14.0. For me it is working… Can you confirm?

from react-geosuggest.

ro-ka avatar ro-ka commented on July 18, 2024

Suspect that it is working. Reopen, if not.

from react-geosuggest.

leoasis avatar leoasis commented on July 18, 2024

@ro-ka sorry for not reaching back, didn't actually use the released version until yesterday. Working fine for me! :D

from react-geosuggest.

ro-ka avatar ro-ka commented on July 18, 2024

Great to hear!

from react-geosuggest.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.