ucloud-fe/react-components

A React UI Library from UCloud.

react-components's Issues

DatePicker: Range be covered when placed in Modal

Current behavior
DatePicker.Range be covered when placed in Modal

Expected behavior
Show DatePicker.Range panel

To Reproduce
Steps to reproduce the behavior:

1. place DatePicker.Range into a Modal
2. open DatePicker.Range

Minimal demo
demo

Package version x.y.z
0.3.0

Screenshots
If applicable, add screenshots to help explain your problem.

Browser
All browsers where this could be reproduced (and Operating System if relevant), please complete the following information:

• OS: MacOS
• Browser: Chrome
• Version: 69

Additional context
None

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Select

Locale: add support of custom locale

Is your feature request related to a problem? Please describe.
Some locale in component is hard coding

Describe the solution you'd like
Extract hard coding locale to locale file, and add support of LocaleProvider

Describe alternatives you've considered
No

Additional context
No

Tooltip: wrong style of arrow

Current behavior
Style of arrow is wrong without reset style

Expected behavior
Display the right style

To Reproduce
Steps to reproduce the behavior:

1. use Tooltip

Minimal demo
demo

Package version
All

Screenshots

Browser
All

Additional context
None

Slider: add ratio, step to marks

Is your feature request related to a problem? Please describe.
Need to support multiple step and custom with of mark range

Describe the solution you'd like
Add ratio, step to marks

Describe alternatives you've considered
No

Additional context
No

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Upload

Test: fill test cases

Add some test cases, to increase test coverage.

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20ActionList

删除版权受限Icon

我们在使用的过程中发现 你的Icon框架中有版权受限的字体 @ucloud/[email protected] 既然开源那么 建议您考虑移除此依赖.

Develop: break in component demos

Current behavior
Develop with windows, the demo of components will break with error.

Expected behavior
Don't break

To Reproduce
Steps to reproduce the behavior:

1. exec npm run styleguide
2. open localhost:6080
3. click one of the components, like Icon
4. see the error in chrome console

Minimal demo
None

Package version x.y.z
0.3.0

Screenshots

Browser

• OS: Windows 7
• Browser: Chrome
• Version: 67

Additional context
It seems like cause by diff of windows and mac path format

Page not found

http://localhost:6080/#/Layout/%E2%9D%96%20%20FlexBox

Table component merge cell function

Is your feature request related to a problem? Please describe.
none

Describe the solution you'd like
加个单元格合并的功能吧😘😘😘😘

Describe alternatives you've considered
none

Additional context
none

Page not found

http://localhost:6080/#/Layout/%E2%9D%96%20%20FlexBox

rowSelection of Table need a Radio type

Now have only checkbox type，for projects that need to be single-selected is unfriendly.

Display of menuItem behind of subMenu

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.
add style of MenuItem to display difference of MenuItem in SubMenu

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20NumberInput

Tooltip: wrong display

Current behavior
Arrow of the Tooltip is wrong

Expected behavior
Display the right Arrow

To Reproduce
Steps to reproduce the behavior:

1. wrap content with Tooltip
2. scroll to let the position of Tooltip is out of window's border

Minimal demo
demo

Package version
All

Screenshots
If applicable, add screenshots to help explain your problem.

Browser
All

Additional context
None

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Layout/%E2%9D%96%20%20Box

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Layout/%E2%9D%96%20%20Grid

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Calendar

Theme: add theme provider

Is your feature request related to a problem? Please describe.
Need theme provider to control the theme of components.

Describe the solution you'd like
Add ThemeProvider to pass colors into the components

Describe alternatives you've considered

import { ThemeProvider, Button } from '@ucloud-fe/react-components';

class App extends React.Component {
    render() {
        return (
            <ThemeProvider theme={{
                font: 'red',
                primary: 'green'
            }}>
                <Button>this is a themed button</Button>
            </ThemeProvider>
        )
    }
}

Additional context
No

DatePicker component add popover props

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

UCloud React Components

add default order for Table

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.
add defaultOrder to control default order of Table

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Styleguide: add codepath support for md

Is your feature request related to a problem? Please describe.
When write demo in readme file which is not a demo for components, the codepath props in demo will not useful

Describe the solution you'd like
Want codepath props useful for all markdown files

Describe alternatives you've considered
None

Additional context
None

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Base/%E2%9D%96%20%20Button

Select Group 组件不支持多选

Current behavior
Select Group 组件传 multiple 参数会报错

Expected behavior
Describe what the behavior would be without the bug.

To Reproduce
Steps to reproduce the behavior:

Minimal demo
If the current behavior is a bug and you can reproduce with an example,
please provide a MINIMAL DEMO of the problem via
https://codesandbox.io/ or similar (you can use this template as a starting point: https://codesandbox.io/s/wnnv1op5yw).

Package version x.y.z
Check whether this is still an issue in the most recent stable.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser
All browsers where this could be reproduced (and Operating System if relevant), please complete the following information:

• OS: [e.g. MacOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

Slider: number precision is wrong when step is float

Current behavior
when step is float, number precision is wrong

Expected behavior
should show right number

To Reproduce
Steps to reproduce the behavior:

1. write a slider like <Slider min={1} max={10} defaultValue={3} step={0.3} />
2. drag to 1.9
3. see number in NumberInput

Minimal demo

Package version x.y.z
0.3.1

Screenshots

Browser
All browsers where this could be reproduced (and Operating System if relevant), please complete the following information:

All

Additional context

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Textarea

Test: add codecov

Is your feature request related to a problem? Please describe.
No codecov

Describe the solution you'd like
Add codecov to CircleCI

Describe alternatives you've considered
Or add to TravisCI

Additional context
No

RadioGroup

Current behavior
RadioGroup 设置为disabled, styleType为"button"或"text"时 无选中效果,而其他几种styleType就算设置为disabled 也有选中效果

Expected behavior
期望修复RadioGroup 设置为disabled, styleType为"button"或"text"时的选中效果

Input ’s value

Current behavior

<Input 
       onChange={value =>{
      console.log(value}}
    />

Expected behavior
Get the right input value

To Reproduce
Value is “ SyntheticEvent {dispatchConfig: {…}, _targetInst: FiberNode, _dispatchListeners: ƒ, _dispatchInstances:.. "

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Switch

UCloud React Components

https://ucloud-fe.github.io/react-components/#/%E7%BB%84%E4%BB%B6%E4%BB%8B%E7%BB%8D

Table Action的 exposeCount

Current behavior
当ActionList 的数量 正好比exposeCount多一个的时候, exposeCount是失效的,

不太清楚是有意这么做的,还是算个bug.
例子中,是期望将"删除"这个危险操作放在
中的

DatePicker: add display of Range

Is your feature request related to a problem? Please describe.
Want to hide the day, minute, and second of DatePicker.Range

Describe the solution you'd like
Add the display prop to DatePicker.Range

Describe alternatives you've considered
None

Additional context
None

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Radio

Travis: always timeout

Current behavior
When run Travis jobs, there is a common error like below:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

Expected behavior
No timeout error

To Reproduce

1. Just trigger a Travis job
2. Not 100% to see

Minimal demo
No

Package version x.y.z
No

Screenshots

Browser
No

Additional context

Table handleOrder

Current behavior
Describe how the bug manifests.
表排序的时候，点击了列的排序功能后无法恢复默认状态
具体见：https://github.com/UCloud-FE/react-components/blob/master/src/components/Table/Table.jsx#L354
order.state 为 none 时还是 "desc"

Expected behavior
Describe what the behavior would be without the bug.
点击时应该有降序/升序/默认状态

To Reproduce
Steps to reproduce the behavior:

1. Go to Table
2. Click on sort

Minimal demo
If the current behavior is a bug and you can reproduce with an example,
please provide a MINIMAL DEMO of the problem via
https://codesandbox.io/ or similar (you can use this template as a starting point: https://codesandbox.io/s/wnnv1op5yw).

Package version x.y.z
Check whether this is still an issue in the most recent stable.

Screenshots
If applicable, add screenshots to help explain your problem.

Browser
All browsers where this could be reproduced (and Operating System if relevant), please complete the following information:

• OS: [e.g. MacOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Checkbox

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Slider

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Layout/%E2%9D%96%20%20Combine

Cannot read property 'toFixed' of undefined

When I use ‘’formDecorator‘’ of ZForm to wrap “Slider“ component up ，getted the following error:
Cannot read property 'toFixed' of undefined·

第一个选中的值，会被分割

Current behavior
第一个选中的值，会被分割

Expected behavior
得到正常值

Minimal demo

const {controllerDecorator, formShape,formDecorator} = ZForm;

const { StyleType } = Checkbox;
const options = ["cn-bj2","北京","上海","广州"];
const ZCheckboxGroup = controllerDecorator({})(Checkbox.Group);

class Demo extends React.Component {
    render() {
    	let {form} = this.props;
        
        console.log(form.getFieldValue("RegionName"));

        return (
         <ZForm form={form}>
            <div>
             <Form.Group title="地域">
                    <ZCheckboxGroup
							zName="RegionName"
                                zOptions={{
                                    initialValue: options[0]
                                }}

                                 options={options.map(v => ({ value: v }))}
                                styleType="card"
                            />
              </Form.Group>
            </div>
            </ZForm>
        );
    }
}

Demo.propTypes = {
    form: formShape
};

const Demo1 = formDecorator()(Demo);

<Demo1 />;

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Input

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20DatePicker

Locale: Add locale provider

Is your feature request related to a problem? Please describe.
Need to globally set locale of components

Describe the solution you'd like
Add LocaleProvider like antd

Describe alternatives you've considered

import { LocaleProvider, Pagination } from '@ulcoud-fe/react-components';

class App extends React.Component {
    render() {
        return (
            <LocaleProvider locale={{}}>
                <Pagination total={100} showSizeChanger />
            </LocaleProvider>
        )
    }
}

Additional context

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Layout/%E2%9D%96%20%20Compact

DatePicker: hide the Select of Range

Is your feature request related to a problem? Please describe.
Want to hide the Select in front of DatePicker.Range

Describe the solution you'd like
Add a props to control the display of the Select

Describe alternatives you've considered
None

Additional context
None

UCloud React Components

https://ucloud-fe.github.io/react-components/#/Interactive/%E2%9D%96%20%20Menu