ucloud/terraform-provider-ucloud-old

(Deprecated) Please see official repository https://github.com/terraform-providers/terraform-provider-ucloud

terraform-provider-ucloud-old's Issues

Terraform Provider Development Program - Initial Review

Hi Team,

My name is Chris, I'm a member of the Partner team @ HashiCorp.

I’ve taken a look at the provider here and would like to say great work so far! I do have feedback outlined below that I’d like to see addressed before we move on to the next steps. I’m opening this issues as a sort of checklist for tracking items and discussion. The review was done on the master branch at git commit 8ce7f72.

• There are two tests that have consistently failed when running the make target testacc, the first appears to be a timeout error and possiblt an unauthoized update error. I've included the test output for both these tests. We will need to make sure all tests are passing.

=== RUN   TestAccUCloudLBRule_basic
--- FAIL: TestAccUCloudLBRule_basic (129.64s)
    testing.go:527: Step 0 error: Error applying: 1 error occurred:
        	* ucloud_lb_attachment.foo: 1 error occurred:
        	* ucloud_lb_attachment.foo: error in create lb attachment, cannot send request, Get https://api.ucloud.cn?Action=AllocateBackend&Port=80&ProjectId=org-xotkcf&PublicKey=XXXXXX%3D%3D&Region=cn-sh2&ResourceId=uhost-jror1a&ResourceType=UHost&ULBId=ulb-sai42l&VServerId=vserver-yoyhcd&Signature=XXXXXX: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

=== RUN   TestAccUCloudSubnet_basic
--- FAIL: TestAccUCloudSubnet_basic (13.72s)
    testing.go:527: Step 1 error: Error applying: 1 error occurred:
        	* ucloud_subnet.foo: 1 error occurred:
        	* ucloud_subnet.foo: do UpdateSubnetAttribute failed in update subnet subnet-orfnk5, api:
        [server.RetCodeError] 291 Action [UpdateSubnetAttribute], Type [DEFAULT] unauthorized error

• Make sure you have an open source license in the repository, preferably a MPL2 which is what we use across all our terraform providers.

The official docs in README can't be opened

Hi @yufeiminds ,
README中的这个官方文档貌似失效了
https://www.terraform.io/docs/providers/ucloud/index.html

Provider Review

Hello!

My name is Bill, I'm a member of the Terraform team @ HashiCorp.

I’ve taken a look at the provider here and would like to say great work so far! I do have feedback outlined below that I’d like to see addressed before we move on to the next steps. I’m opening this issues as a sort of checklist for tracking remaining items and discussion. The review was done on the git commit b60f089.

General

• Does resourceUCloudDiskCreate need to call resourceUCloudDiskUpdate? It doesn’t look like Update sets anything that Create doesn’t. It looks like this is a common pattern in the resource create functions. Is there post create updates that need to happen?
• Add import tests for resources which support importing. These can be included as part of the basic test if you would like.
• You might want to use a constant for some states like “pending” as they are regularly used.
• Errors should be checked when setting non-scalars like ip_set in resource_ucloud_eip to ensure the value is properly formatted and set.
• If the order of ip_set (and other TypeLists) could change, using TypeSet would be better than TypeList. The order of items matters in TypeList, but not in TypeSet.
• What happens if the instance tag argument is "" rather than "Default"?
• Translate arguments and attributes such as instance auto_renew into boolean values rather than using a string value which needs to be interpreted.
• In README.md, "Refer" looks like it should be "Reference"
• CHANGELOG.md needs to be added
• Check that data sources have arguments and attributes assigned correctly. It looks like the data source schemas may just be a copy of the resources, but some things like tags may not be an item that should be used for looking up instances.
• ForceNew is not needed for data sources.

Documentation

• List defaults in "Default: Value" format.
• If an int is expected, list the unit separately. eg "Size of disk in GB. 1-8000 for a cloud disk, or 1-4000 for an SSD cloud disk."
• Use backticks for values in docs. eg DataDisk instead of "DataDisk".
• General grammar proof reading in docs (also some in code comments, but less important there). There are some sentence syntax, capitalization, and punctuation issues.
• Check character use. instance resource docs contain "，" in place of a space.