udacity/aind2-rnn

Project materials for RNN segment of AIND nanodegree

aind2-rnn's Issues

Unit tests use incorrect parameter name for build_part1_RNN()

Correct specification of build_part1_RNN(): def build_part1_RNN(step_size, window_size)
Unit tests performed during udacity submit do not supply window_size, that leads to following error:

Failed Test: Step 2: Create a simple RNN model for regression

TypeError: build_part1_RNN() missing 1 required positional argument: 'window_size'

Unit test error during udacity submit

Units tests use cleaned_text from my_answers, while it named clean_text both in my_answers.py and RNN_project.ipynb

Udacity submit output:
Failed Test: Step 3: Clean up a large text corpus

NameError: name 'cleaned_text' is not defined

Requirements.txt file missing?

General Spelling/ Theory Improvements

1. Section 1.2 and 2.3 describe windows of length 5, but both discuss input vector of length 4 which seems like an error.
2. Beneath "dogs are great" gif analogous is spelt analaogous.
3. In section 2.3 "One-hot encoding characters" the first sentence reads:

There's just one last issue we have to deal with before tackle: machine learning algorithm deal with numerical data and all of our input/output pairs are characters

which doesn't make sense.

Happy to contribute to repo if required.

Syntax warning nb_epoch

The rest of the calls to fit use the updated api epochs

But one call toward the bottom get a deprecated syntax warning.

model.fit(Xlarge, ylarge, batch_size=500, nb_epoch=30,verbose = 1)

UserWarning: The nb_epoch argument in fit has been renamed epochs.

Should be updated to

model.fit(Xlarge, ylarge, batch_size=500, epochs=30,verbose = 1)

Goal inputs for `window_transform_series` do not match udacity_pa tests

In the notebook it shows that goal for window_transform_series(odd_nums) is displayed as:

--- the input X will look like ----
[[ 1  3]
 [ 3  5]
 [ 5  7]
 [ 7  9]
 [ 9 11]
 [11 13]]

But the project assistant seems to be looking for below and will fail if the output matches above.

[[ 1  3]
 [ 3  5]
 [ 5  7]
 [ 7  9]
 [ 9 11]]

Which is correct?

Thanks.

build_part2_RNN()

It is not called anywhere...