Giter Site home page Giter Site logo

ud864's People

Contributors

sudkul avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ud864's Issues

Autocomplete search box not limiting results to within map bounds

I came across an issue in the Autocomplete portion of the course. I was running my autocomplete code to display pizza restaurants and noticed that when I typed in 'pizza', it would zoom the map all the way out to show North America continent and show international listings instead of inside NYC area. It worked fine if I typed in 'pizza NYC' though. At first I thought I had made a mistake in my code, so I copied over the code sample from github repo. Same thing happened again with the code from github.

It's my understanding that in the code, when you call searchBox.setBounds(map.getBounds()) in the code, it would display searchBox results to be within NYC area, not internationally.

There is no 'setMarker' method

In the line 83 from 'Project_Code_3_WindowShoppingPart1.html' file, the method infowindow.setMarker(null); not exist.

The correct is set the attribute infowindow.marker = null; to unbound marker object of infowindow.

Info windows on marker won't reopen unless you click on another marker.

Project_Code_3_WindowShoppingPart1.html
line 77 if (infowindow.marker != marker) {

if you click on one marker to view the the title, close and try to reopen it won't open again unless you click on another marker.

Better solution ?
// Check to make sure the infowindow is not set to the same marker, but if it is, and the infowindow was close, reopen it.
if (infowindow.marker != marker || infowindow.setMarker == null) {

Suggest replace Marker.Image with Icon

To create the custom markers the code uses the Google Maps Marker.Image object -- but that has been replaced by the Google Maps Icon object. There is very little documentation about Marker.Image which can cause some confusion for students. Suggest that the code be refactored to use Icon which has better documentation.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.