ueno-llc/starter-kit-historical

ueno. Starter kit

starter-kit-historical's Issues

Re-usable components

Extracted some data from our previous projects and got a list of components that we usually make.

name	count	available
segment	8	X
container	8	X
hero	8
footer	8
button	7
header	7	X
navigation	7	X
app-layout	5	X
icon	4
modal	3
heading	3
grid	3
contact	3
carousel	3
logo	3
contact-form	2
page-copy	2
input	2
form	2
search-results	2
search	2
loading	2
quote	2
dropdown	2
list	2
page-title	2
jwplayer	1
share-dialog	1
shows-list	1
sign-up	1
social-bar	1
stay-in-the-loop	1
video-card	1
video-carousel	1
video-items-featured	1
video-items-grid	1
video-items-list	1
video-layout	1
case-study	1
well	1
google-analytics	1
mix-panel	1
summary	1
about-us	1
content-layout	1
faq	1
features	1
first-steps	1
hero-show	1
graph	1
in-the-press	1
investors	1
knob	1
mobile-navigation	1
nope	1
signup-form	1
signup-overlay	1
sprite	1
the-card	1
article-excerpt	1
audio-carousel	1
audio-player	1
badges	1
blockquote	1
blurb	1
book-appointment	1
business-card	1
collapse	1
community-stories	1
community	1
company-carousel	1
content-blocks	1
context	1
counter-segment	1
counter	1
descriptive-list	1
filter	1
form-field	1
grid-overlay	1
home-hero	1
job-listings	1
legal	1
level-up	1
map-section	1
map	1
media	1
meet-the-team	1
outreach	1
page-header	1
page-not-found	1
paging	1
pharmacy-details	1
product-list	1
review	1
search-bar	1
google-tag-manager	1
search-segment	1
originals	1
service-list	1
sitemap	1
slides-navigation	1
slides	1
solution-list	1
solutions	1
tabs	1
text-reveal	1
tooltip	1
video-player	1
bit	1
cookies	1
chevron-link	1
color-palette	1
country-color-palette	1
desktop-only	1
in-the-spotlight	1
playlist	1
hero-search	1
illustration-generator	1
illustration	1
image-list	1
layouts	1
nav-bar	1
next-up	1
page-list	1
pages	1
photo-modal	1
separator	1
about	1
account-details	1
alert	1
article	1
cart	1
cart-button	1
close-button	1
content-block	1
favourite-button	1
feature-segment	1
hero-segment	1
notification	1
page-heading	1
page-hero	1
press-card	1
product	1
product-hero	1
product-image	1
region-map	1
search-autosuggest	1
search-button	1
search-filter-list	1
search-nav	1
section-heading	1
sign-in-form	1
sticky	1
tag	1
usp	1
video-overlay	1
background-block	1
campaign	1
centercard	1
contact-alt	1
description	1
devices	1
example	1
experience	1
fadein	1
famous-is-there	1
fonts	1
gallery	1
hamburger	1
hero-alt	1
industries	1
info	1
layout	1
lefty	1
podcast-item	1
maps	1
modal-container	1
offset-block	1
page	1
para	1
perks	1
phone	1
phone-video	1
play-button	1
privacy	1
podcast-player	1
scroll-group	1
scroll-jacker	1
secret-hero	1
stats	1
styles	1
subnav	1
svg-icon	1
time	1
tinytext	1
transition-segment	1
two-phones	1
video	1
cards	1
col-section	1
columns	1
customers	1
divider	1
features-items	1
figure	1
image-group	1
label	1
laptop	1
logo-card	1
offcanvas	1
platform-icon	1
platform-items	1
pricing-faqs	1
pricing-list	1
ribbon	1
showcase	1
slick	1
stats-number	1
story-box	1
story-heading	1
story-quote	1
story-widget	1
testimonial	1
text-hero	1
text	1
thoughts	1
tryforfree	1
up-next	1
do-dont	1

Cannot complete build due to svg-loader error

npm run dev fails to complete due to svg-loader error linked to ueno-logo.svg

classnames & classnames-loader

We're currently using both pure classnames and classnames-loader in some of our projects. James and I discovered this just now and thought it was a mistake - className={s(s.myClass looks very much like a find-and-replace accident.

Can we agree on one approach and make it standard? In my opinion classnames-loader isn't obvious, and while it's a very simple package, it doesn't seem to be very heavily used or maintained. I'd definitely recommend sticking with classNames even though it requires an extra import line, because it's much more obvious and doesn't implicitly depend on webpack.

webpack hard codes NODE_ENV

The define plugin is hard coding the NODE_ENV env variable to whatever it is during build.
That means you cannot run a build in any other environment than the one it was built in.
See here:
https://github.com/ueno-llc/starter-kit/blob/master/webpack/make.js#L151

Single-quotes aren't properly escaped in __INITIAL_STATE__?

I've got some content with a ' character in it which isn't escaped in the window.__INITIAL_STATE__ = line. This might have to be window.__INITIAL_STATE__ = '${state.replace(/\\/g, '\\\\').replace(/'/g, "\\'")}'; or base64 en/decoded?