ueno-llc/styleguide

Ueno's code style guide and linter configs

styleguide's Issues

Add jsx-closing-tag-location

Add: "react/jsx-closing-tag-location": 0

We are using everywhere

<Component>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque a diam ultrices, pellentesque dolor sed, suscipit diam. Nunc fermentum maximus nunc ac cursus. Aliquam egestas aliquet arcu. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Vivamus porta mattis finibus. </Component>

Which fires a: Closing tag of a multiline JSX expression must be on its own line

[Tslint] Let's move to eslint's typescript config

Palantir maintaining tslint announced they will stop working on it as soon as eslint/tslint configs will be more mature. It's an agreement made between Microsoft (typescript) / eslint / palantir (tslint)

Cf:
https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/parser
https://medium.com/palantir/tslint-in-2019-1a144c2317a9?fbclid=IwAR0JfKT8leqEQhogOvmmPBESP5ZBrgYFFsrtpdox42pX_b-dWVgQvle14eQ

Observable linebreak

Instead of hardcoding @observable, have the rule configurable with array of strings to enforce newline.

That way we can easily add more properties like @computed, @action and so on.

Rule disable for the moment

We have to wait the next update of eslint-plugin-react to fix the use of the new params of this rule: jsx-eslint/eslint-plugin-react#1469

[Tslint] Remove rules on arrow-parens for single line/arg

CF https://github.com/buzinas/tslint-eslint-rules/blob/master/src/docs/rules/terArrowParensRule.md

Update eslint to v4.5

Have base config separate from react config

Wanted to use this in a non-react project so the react rules wouldn't apply. Should there be a base config separate from react and jsx rules like we do with react-native config?

Something like for base:

"extends": "@ueno"

and for react

"extends": "@ueno/eslint-config/react"