uklance/gradle-maven-share

Migrate from Maven to Gradle by sharing dependencies and more

gradle-maven-share's Issues

Task based architecture

Currently everything is happening in the configuration phase

New approach

1. MavenSharePlugin applies MavenShareRootPlugin
2. MavenShareRootPlugin creates shareRoot task
3. MavenSharePlugin creates shareProject task
4. javaCompile task dependsOn shareProject
5. shareProject depends on shareRoot

Publish to plugin portal & maven central

Task based architecture attempt 2

Configurations.all(Action<Configuration> action) applies the action to all configurations plus any future contributions added to the project
https://docs.gradle.org/current/javadoc/org/gradle/api/DomainObjectCollection.html#all%28org.gradle.api.Action%29

This could be used to wire the task into the DAG (configuration.dependsOn(task))
See issue #6 and the associated commit / revert

Fail for unsupported maven dependency attributes

1. Throw exception for type or systemPath in a maven dependency
2. Also throw exception for classifier where dependencyProject is not null

Suggest a solution

• exclude the dependcy
• Declare a custom DependencyResolver

Single project not working

Last time I tested, single project doesn't work

Possible causes:

• project.subprojects { Project subproject -> in the root plugin
• project.afterEvaluate { ... } block in the root plugin

ResolvedPom visitHierarchy should be visitAncestry

Rename visitHierarchy to visitAncestry

ResolvedPom changes

getPropertynames() should be getPropertyNames()
add getProperties() (ensure unmodifiable map)

Support classifiers

MavenShareRootPlugin.groovy

depNotation = [group: dep.groupId, name: dep.artifactId, version: dep.version]
if (dep.classifier) {
    depNotation['classifier'] = dep.classifier
}

final in ResolvedPom

Allows compilation in java < 1.8

final Map<String, Dependency> managementMap = new LinkedHashMap<>();