Giter Site home page Giter Site logo

Comments (18)

v3n avatar v3n commented on July 22, 2024 4

Hi all,

Quick update: We're got two fixes pending for this issue.

  1. A code change, which will take a few weeks to make it into LoR live due to our SDK integration timelines. This will permanently fix this issue for LoR, future games, and prevent config regressions (source of the issue here)
  2. A config change, which we're targeting for 02/18. It would be ideal to do it earlier to give y'all a chance to test, but unfortunately, we're a little constrained by tech at the moment. Apologies. However, when this config goes out, it will immediately take effect globally and enable the lancache behavior again.

-- Jonathan Howard // Riot Venia

from cache-domains.

v3n avatar v3n commented on July 22, 2024 3

You can disregard the above questions, I've identified the issue. :)

from cache-domains.

v3n avatar v3n commented on July 22, 2024 1

Hmm, this is definitely not intended.

To be clear, this is the intended behavior:

  1. LoR will reach out to bacon.secure.dyn.riotcdn.net/channels/public/releases/* over TLS to download a manifest.
  2. LoR will download additional files via bacon.dyn.riotcdn.net utilizing the TLS downgrade where applicable.

Can you confirm whether or not you're seeing the same behavior for ks-foundation.dyn.riotcdn.net and
lol.dyn.riotcdn.net?

More information so that we can build a repro would be super helpful:

  • Is this an IPv4, IPv6, or dual stack network?
  • DNS servers are set via DHCP option 6, right?
  • What platform are client machines running on?
  • What are the subnets of the cache and the client, respectively?

Thanks for bringing this to our attention!

from cache-domains.

ciarancrocker avatar ciarancrocker commented on July 22, 2024

Seeing no entries in normal cache access log, but requests to the following hosts during initial installation and subsequent patching:

bacon.secure.dyn.riotcdn.net
ks-foundation.secure.dyn.riotcdn.net

Looks like the bulk of the actual game download is coming from the bacon hostname, as once the client goes full screen to update most (if not all) SNIProxy requests are to that hostname.

from cache-domains.

Lepidopterist avatar Lepidopterist commented on July 22, 2024

Thanks @v3n .

Let us know when you believe the issue is resolved from your end, and we'll confirm from our PoV.

from cache-domains.

v3n avatar v3n commented on July 22, 2024

Will do. Unfortunately, it may require a new client version which could take a week or two.

How critical would you identify this issue being? (any significant LANs upcoming, impacted PC Cafes, etc)

from cache-domains.

Lepidopterist avatar Lepidopterist commented on July 22, 2024

It's not a showstopper, it's more mildly inconvenient at the moment.

We have a ~600 person LAN and a ~200 person LAN occurring on the weekend of Thurs 20th Feb - Mon 24th Feb, so it would be a 'nice to have' if it was available by then.

Thanks!

from cache-domains.

VibroAxe avatar VibroAxe commented on July 22, 2024

@v3n From a UK perspective I'm aware of Westlan on the 7th (not usually high riot traffic) and then StratLAN AND Epic.Lan on the 20th (Significant cache traffic)

Cannae comment on the rest of the world.

Edit: Beaten by @Lepidopterist

from cache-domains.

Lepidopterist avatar Lepidopterist commented on July 22, 2024

Just to add to this - DreamHack Anaheim is also the same weekend (around the 22nd Feb) so having this as a target to complete by does seem to make sense.

from cache-domains.

v3n avatar v3n commented on July 22, 2024

Apologies all, the fix for LoR (bacon.dyn.riotcdn.net) did not make it out for DreamHack Anaheim.

It will probably take ~2 more weeks for it to make it to live.

from cache-domains.

MathewBurnett avatar MathewBurnett commented on July 22, 2024

Thanks for taking the time to keep us up to date @v3n

from cache-domains.

egguy avatar egguy commented on July 22, 2024

There's the same problem with the LOL updater who stay in HTTPS and can't be cached.

The domain is: lol.secure.dyn.riotcdn.net

from cache-domains.

MathewBurnett avatar MathewBurnett commented on July 22, 2024

The LOL updater certainly can cache game content which is on lol.dye.riotcdn.net providing that your are correctly intercepting the dns. I'm watching my cache logs as i update it now

from cache-domains.

egguy avatar egguy commented on July 22, 2024

I think i've correctly configured the DNS:

image

I've also added lolstatic-a.akamaihd.net to the list of intercetpted DNS but it's still using lol.secure.dyn.riotcdn.net over HTTPS. The client has been downloaded this morning.

from cache-domains.

MathewBurnett avatar MathewBurnett commented on July 22, 2024

@egguy if you raise a separate issue with the details of your setup perhaps we can see where we can help.

from cache-domains.

egguy avatar egguy commented on July 22, 2024

It's seems to be only the launcher which stay in HTTPS (1.8g update), the game client downgrade to HTTP. Sorry for the noise.

from cache-domains.

xelaadryth avatar xelaadryth commented on July 22, 2024

Okay we've put in the code changes for Legends of Runeterra, if anyone wants to give this a spin!

from cache-domains.

MathewBurnett avatar MathewBurnett commented on July 22, 2024

This does appear to be hitting the cache
[riot] 10.20.60.222 / - - - [07/Mar/2022:09:23:59 +0000] "GET /channels/public/bundles/39AE50E469F896F3.bundle HTTP/1.1" 200 7008 "-" "RiotNetwork/1.0.0" "MISS" "bacon.dyn.riotcdn.net" "bytes=0-284345,328320-818291"

I'm closing this and concluding that LoR now caches by HTTP as designed

from cache-domains.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.