Login request with no email...

[ultracart]

Login request with no email...

[perrytew]

Dan,
I don't think it's a bug. It's more of a legacy feature we're working with. Please check the result for an "errors" array and you should see the "missing" messages. We did that for a few reasons. I agree that the 200 for a failed login is inappropriate, but it works really well with frameworks like backbone.js when you have views keying off changes in the cart.errors property.

Thanks,
Perry

[WriterDanGaidin]

Ah, sorry. I obviously didn't communicate myself well enough. I'm not getting any errors back at all. It's not the 200 that I'm suggesting is inappropriate (I think that's perfectly fine given what you're trying to accomplish with this api call). The issue is that the errors array inside the result is equal to null when I send a request that has empty values for email and password.

I get appropriate errors passed back to me (within the result's errors array) if either the email or the password are blank, but it comes back errorless if both the email and password are blank.

[perrytew]

Hmmm, I've reviewed the code. Are you passing in nulls or empty string? Perchance you could post me the snippet of your call?

[WriterDanGaidin]

Empty strings. I've checked the cart object prior to sending the request to verify this. Here's my code:

app.data.cart.set({
    'email' : jQuery.trim(jQuery('#email').val())
});
app.data.cart.set({
    'password' : jQuery.trim(jQuery('#myMemberAccountPassword').val())
});
jQuery.ajax({
    url : '/rest/cart/login',
    type : 'POST', // Notice
    async : false,
    headers : {
        "cache-control" : "no-cache"
    },
    contentType : 'application/json; charset=UTF-8',
    data : JSON.stringify(app.data.cart),
    dataType : 'json'
}).done(function(loggedInCart) {
    if(loggedInCart.errors && loggedInCart.errors.length) { // Log-in errors
        app.commonFunctions.displayCheckoutErrors(loggedInCart.errors);
        console.log(loggedInCart.errors);
    } else { // Customer logged in successfully
        app.data.cart.set(loggedInCart, {silent: true});
                app.data.cart.trigger('sync');
    }
});

[perrytew]

Dan,
The code was checking for nulls, not empty strings. ProdSupport pushed a fix to check for both. Would you kindly run your test again and report the results?

Thanks.

[WriterDanGaidin]

Bingo. :) Thanks.