Giter Site home page Giter Site logo

Comments (2)

HTV04 avatar HTV04 commented on June 26, 2024

Hi, sorry if I'm wrong, but while 0x0 is technically an invalid resolution, the pull request seems to add more of an enhancement rather than a bugfix. It would probably make more sense for push to detect whether windowWidth and windowHeight are nil and default to the desktop dimensions if so, instead of 0 or less which should probably throw an error instead.

I'll leave this open for a few days in case there's something I'm missing, though.

from push.

FormularSumo avatar FormularSumo commented on June 26, 2024

My thinking was to make push:setupScreen mirror the beheaviour of love.window.setMode, where if you give it a width/height of 0 it sets them to desktop resolution.
https://love2d.org/wiki/love.window.setMode
"If width or height is 0, setMode will use the width and height of the desktop."

At any rate the current beheaviour should probably be changed, where the window is launched at desktop resolution but can't be drawn to within push:start and push:finish.

Also my pull request is only checking for == 0, if you put in a value less than 0 (or nil) it returns an error.

from push.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.