umakoz/typetalk-rb

A Ruby wrapper for Typetalk

typetalk-rb's Issues

Can handling of access token be simpler?

I am finding it a bit confusing to have Typetalk::API instance have an instance method called “access_token” and an instance variable called “access_token”, both of which are not really the same.

The access_token method returns an access token. But before that, the access token value and all related values are manipulated and put into one Hashie::Mash object, which in turn is assigned to the access_token variable. And in there the access_token value can be found with a key called “access_token.”

And when it comes to testing, the expected and actual values of the access token are directly compared using the access_token method while those of the related values are indirectly compared using the access_token variable.

For example,
/typetalk-rb/spec/typetalk/api_spec.rb:13
expect(response).to eq('(ACCESS_TOKEN)')

/typetalk-rb/spec/typetalk/api_spec.rb:15
expect(api.instance_variable_get(:@access_token).expire_time).to eq(Time.now.to_i + 3600)

So I have a feeling there maybe a better way. I would appreciate it if you could shed some light on this.