undergroundwires/bump-everywhere

🚀 Automate versioning, changelog creation, README updates and GitHub releases using GitHub Actions,npm, docker or bash.

bump-everywhere's Issues

Deployment does not work from forked repository

The problem is that deploy.yaml depends on a secret that cannot be read when it's triggered by PR.

When you create a pull request from forked repository to base repository, the workflow will be triggered on base repository. (documentation)
It’s by designed that encrypted secrets are not passed to the runner when a workflow is triggered from a forked repository. (documentation)

However we need the secret there otherwise creating release does not trigger publish workflow deployment (as documented) here.

Need to solve that 🤔

New version is wrong and cause a fail of pipeline

Version of bump-everywhere 1.3.0
But as I remember it started before I updated version.

I had reading the shell scripts for several days, but no luck.

Cloning Intentop/love-forever
Cloning into '/tmp/tmp.KjNkCL'...
Latest commit sha: 251a4907968843ecfa0efeeffaf5ec0b86c88859
Checking if this run is a re-run
Setting up credentials
Bumping and tagging version
Updating "1.5.3" to "1 5 3..1"
Creating tag: "1 5 3..1"
fatal: '1 5 3..1' is not a valid tag name.
Could not tag: "1 5 3..1"
Could not bump & tag

I suppose it's on my side but where? Wrong dots? ;)

allow setting different release options

Allow user to customize the GitHub release behavior.
Introduce argument: release-type with following options:

• none: No release is created
• draft: Release draft is created
• prerelease: Pre-release is created
• release: Current behavior, a non-draft release is created and published

Monorepo support

Maybe add the possibility to do this also in monorepo.
If no package.json in root, check one folder layer down.

On first run of new project i get error

I added this workflow too the project:

name: Changelog
on:
  push:
    branches:
      - master
jobs:
  build:
    name: Bump version and release
    runs-on: ubuntu-latest
    steps:
      - name: Bump version and release
        uses: undergroundwires/[email protected]

Could not retrieve latest version. Version "404-tekst" is invalid (not in major.minor.patch format)
And this is the top of the package.json file:

{
  "package_name": "Mustasj webproject builder",
  "version": "1.3.0",
  "private": true,
  "description": "Gulp modules for an awesome front-end build tool",
  }

🎨 Usage of a prefix

I want to use a v for my version tags but this is currently not possible. One solution would be to extend the options and add a regex or extend the check to also expect v as possible parameter.

validate version in package.json

I made a release with version number 2.21 and when that version is added to the package.json i get an error in my build:
npm ERR! Invalid version: "2.21"

Maybe add node semver to the job to verify right format, from the npm documentation: https://docs.npmjs.com/files/package.json#version

Commit should be pushed before creating tag

First of all, thank you for creating this! I love the idea of bundling all of this boilerplate activity into an easy-to-use action.

My expectation is that the version bump in package.json and generated release notes should be included in the released version. However, it doesn't appear to be working that way. For example, in the last release of this project:

1.3.1...1.4.0

You can see that it includes the release notes and version bump from the previous release, rather than from 1.4.0. Looking at the code, I can see this is because the tag is created and pushed before the commit is made. I see two options:

1. Move the logic that creates and pushes the tag to after the commit is pushed or
2. Retag the tag after the commit is pushed to point to the hash of the commit

I prefer option 1 because it means that if the action ever fails to push the commit, there is no need to clean up the tags. Happy to submit a PR for this if this proposal is accepted.

FR: Allow setting for branch name

Right now it expects the main branch to be named master, but ours is main, so the build fails. It would be nice to have that setting alongside repository and user