unfold/eslint-config

Unfold's ESLint config

eslint-config's Issues

Update to work with latest version of ESLint

disable no-confusing-arrow

Allow bool => bool ? 'a' : 'b'instead of writing

bool => {
  if (bool) {
    return 'a'
  }
  return 'b'
}

Always bugged me, but since I'm not allowed to

const MemberPhotoImg = styled.img`
  width: 100%;
  height: 100%;
  display: ${props => props.src ? 'block' : 'none'};
`

without wiriting disables everywhere, I think we should disable it.

eslint-preset

There might be support for eslint-presets in the future, so that we won't need to explicitly add eslint-plugins as dependencies.

When eslint – Support having plugins as dependencies in shareable config is resolved, airbnb might do this work for us.

Disable "react/no-did-mount-set-state"

There's no way to do layout measuring or use async/await in componentDidMount with this rule in place. While it provides a nice safety net it's something you'd avoid by reflex after having worked with React a bit.

Add "no-restricted-globals"

The following won't produce an error because event and history among others are globally defined in the browser.

onClick() => {
  event.preventDefault()
  doStuff()
  history.replace('/')
}

Correct code (this example assumes withRouter from "react-router"):

onClick(event) => {
  event.preventDefault()
  doStuff()
  this.props.history.replace('/')
}

I'm suggesting that we introduce no-restricted-globals along with a list of global variables we don't consider "global".

"no-restricted-globals": ["error", "event", "history", "location"]

Increase or disable max-len

I frequently find myself adding // eslint-disable-line max-len after lines that are slightly too long but still perfectly readable.

My suggestion is to either increase it to 160 (80*2) characters or disable it completely.