ungap/event-target

An EventTarget polyfill

event-target's Issues

Event bubbling

What is the issue?

Currently when dispatching an event to a node, that event won't bubble up to parents.
This is also used in linkedom which is the reason I started looking at it.

What could be done?

I pulled the code and started an update:

    define(proto, 'dispatchEvent', function (event) {
      var secret = wm.get(this);
      if (secret[event.type]) {
        var listeners = secret[event.type].slice(0);
        define(event, 'target', this);
        define(event, 'currentTarget', this);

        // if an event listener invoke stopImmediatePropagation it should stop calling other listeners
        for (var i = 0; i < listeners.length && !event._stopImmediatePropagationFlag; i++) {
          dispatch.call(event, listeners[i]);
        }
        delete event.currentTarget;
        delete event.target;
      }

      // should probably be done differently: https://dom.spec.whatwg.org/#event-path
      // but should not be too much of an issue for now
      if (event.bubbles && !event._stopPropagationFlag) {
        if (this.parentNode) {
          this.parentNode.dispatchEvent(event);
        }
      }
      return true;
    });

This is a very simple bubbling but it should works fine and could be improved in more PR eventually.
I created a branch, maybe I could push it and create a PR?
Thanks!

TypeScript version

Hi

In the process of "typing" your event-target polyfill I came across the following issues:

The attempt to delete these fields produces errors as they are read-only. So are they in plain JS. Does this mean these lines could be safely removed from the code?

        delete event.currentTarget;
        delete event.target;

The last line of the addEventListener definition produces an error, as listeners is only declared locally in the for-loop. Into which context could the declaration for listeners be moved without breaking the code?

listeners.push({target: this, listener: listener, options: options});

Thanks for any suggestions
dsheyp

Unable to extend EventTarget

Unable to extend EventTarget in NodeJS and Jest

const EventTarget = require('@ungap/event-target')

class L extends EventTarget {}

const listener = new L();

const event = new CustomEvent('a');

listener.addEventListener('a', console.log);
listener.dispatchEvent(event);

Polyfill crashes because listener is undefined

Hello!

I'm using this polyfill in ie11 and it crashes sometimes at this line: https://github.com/ungap/event-target/blob/master/index.js#L68

I get the error: "Unable to get property 'handleEvent' of undefined or null reference". When I check the info object, it's listener and options are undefined. Anyone has a clue of why? And what I can do to fix it?

Update the module in a ESM/CJS compatible way.

In order to make modules importable/requirable via NodeJS, follow the dual module approach described in here so that latest NodeJS won't have issues.