unidaystudio/upbge-charactercontroller

This templates was created to help Blender Game Engine (UPBGE) users to create games or any kind of interactive things that requests a Character Controller. Easy to use, easy to attach to your project.

upbge-charactercontroller's Issues

Use SCA_InputEvent.active instead of SCA_InputEvent.values

UPBGE-CharacterController/Source/CharacterController.py

Line 75 in c039b17

if keyboard[bge.events.LEFTSHIFTKEY].values[-1]:

UPBGE-CharacterController/Source/CharacterController.py

Line 123 in c039b17

if keyTAP in keyboard[bge.events.SPACEKEY].queue:

SCA_InputEvent.values exists for keyboard events only because the mouse events need this field to store the mouse position or wheel rotation.

Also using the last item of values mean that item in the between are ignored, if the key is pressed and released and that a frame contain only these two actions, the last value will be 0 and you will miss the activation.

You should use the helpers:
https://pythonapi.upbge.org/bge.types.SCA_InputEvent.html#bge.types.SCA_InputEvent.active
https://pythonapi.upbge.org/bge.types.SCA_InputEvent.html#bge.types.SCA_InputEvent.inactive
https://pythonapi.upbge.org/bge.types.SCA_InputEvent.html#bge.types.SCA_InputEvent.activated
https://pythonapi.upbge.org/bge.types.SCA_InputEvent.html#bge.types.SCA_InputEvent.deactivated

if keyboard[bge.events.LEFTSHIFTKEY].values[-1]:
    speed = self.runSpeed

if keyboard[bge.events.LEFTSHIFTKEY].active:
    speed = self.runSpeed

can you post the source for the py modules (so we can view it without opening the blend)

There are security issues on upbge versions before recent commits 0.2.3

(py components run automatically without any asking for permission)

so it's a good idea to let the user build components with copy/paste into their own projects
and allow them to look over the code without opening a blend in upbge.

Use vector.xy

UPBGE-CharacterController/Source/CharacterController.py

Line 129 in c039b17

self.object.worldPosition[0] = self.__lastPosition[0]

These lines could be replaced by:

dst.xy = src.xy
``

mathutils normalize

UPBGE-CharacterController/Source/CharacterController.py

Line 87 in c039b17

# Normalizing the vector. For some reason, the mathutils normalize

What do you mean in this comment ? Should we leave it in the code ?

multiplying a matrix by a vector?

I can see this is quite an old project, it may just be to do with changes to the API, but it's full of lines that throw errors
eg.
self.character.walkDirection = self.object.worldOrientation * vec

this is because "self.object.worldOrientation" is a Matrix and vec is a Vector

sorry if this is a basic question, I'm more familiar with Quaternions than matrices

what is it meant to be doing?
should "vec" be converted to a matrix? this would allow for multiplication which accumulates (like a Quat)

Broken link

Link to the youtube channel in the file readme.md is broken.