unininja/mobile

React Native code base that produces the UniNinja iOS and Android applications

mobile's Issues

Firebase

Look into using Google Firebase to persist data (such as favourite unis and notes)

Android is not supported

At the moment it looks like only iOS is supported. Is there a build command we can run that allows us to build the Android version also?

CourseProfile

Following on from the Course List, a CourseProfile screen should be created to display information about a specific course.

This screen will be accessed when a user taps on a particular course in a Course List.

Implement Search

Implement the search functionality that will allow users to search for unis by name

Finish Implementing Favourites

In order to finish off the Favourites screen, the following three things should be done:

1. Tapping on a university should take you to its UniProfile page.
2. The dark blue background should not fill the entire screen.
3. When favouriting a uni (using the star button in its UniProfile screen), the star's state/fill does not indicate that the action has had an effect. Only once the UniProfile screen is reloaded does the state update. This needs to be fixed.

Implement unit testing

We must unit test the mobile application before it can be rolled out to production.

Move over to StandardJS

In order to maintain an easily scalable codebase, we should refactor our existing code to follow StandardJS style guidelines. From their website, there are a few changes we should make to our code to follow this style:

• 2 spaces – for indentation
• Single quotes for strings – except to avoid escaping
• No unused variables – this one catches tons of bugs!
• No semicolons – It's fine. Really!
• Never start a line with (, [, or `
  • This is the only gotcha with omitting semicolons – automatically checked for you!
  • More details
• Space after keywords if (condition) { ... }
• Space after function name function name (arg) { ... }
• Always use === instead of ==, but obj == null is allowed to check null || undefined.
• Always handle the node.js err function parameter
• Always prefix browser globals with window – except document and navigator are okay
  • Prevents accidental use of poorly-named browser globals like open, length, event, and name.

This may require a couple of PRs - one to refactor the codebase, and another to implement a check that StandardJS is used during the CI process.

We have recently implemented this on the server side thanks to @harrygcollins - if you have any questions then feel free to ask myself or him!

Courses List

When the Show Courses button in the UniProfile screen is pressed, a request to the API to retrieve a list of all courses offered by that university should be made, and the results should be displayed in a list.

Configure CI tools

According to GitHub, the build currently fails because a .travis.yml file has not been written. We should aim to get this file written asap to allow us to properly use continuous integration.

Display Map in UniProfile

The UniProfile screen should display some kind of map showing the location of the university (as supplied by the API).

Standard requires Node v4

StandardJS is not enforced at the moment as the Travis environment is using < Node v4

Implement My List

Allow users to add unis to their list of favourites for later viewing.