universexyz/auctioncontracts

Build the project

Run:

$ yarn
$ cp .envrc.example .envrc
$ source .envrc
$ yarn compile

Run Tests

$ npx hardhat test

Deploy to Ganache

$ ./start_ganache.sh
$ yarn deploy ganache

Deploy to live networks

Edit .envrc.example then copy it to .envrc

$ cp .envrc.example .envrc
$ source .envrc

Make sure to update the enviroment variables with suitable values.

Now enable the env vars using direnv

$ eval "$(direnv hook bash)"
$ direnv allow

Deploy to a network:

$ yarn deploy rinkeby

Verify smart contract on etherscan

To verify the deployed contract run:

$ yarn etherscan-verify rinkeby --address

Gas cost estimation

To get a gas estimation for deployment of contracts and functions calls, the REPORT_GAS env variable must be set to true. To estimate with certaing gas price update the hardhat.config.js file. Gas estimation happens during test, only functions specified in tests will get an estimation. run with:

$ yarn test

Rinkeby deployments

UniverseAuctionHouse - https://rinkeby.etherscan.io/address/0x2345164eFfE24EA125ECD0ec9C7539D5422c367f

UniverseERC721Factory - https://rinkeby.etherscan.io/address/0x26E84797880B6435861E8730171B75e6257bCBa0

UniverseERC721 - https://rinkeby.etherscan.io/address/0xF7B12892699D6c94E83d864805A381548cfB2A29

UniverseERC721Core - https://rinkeby.etherscan.io/address/0xfD7D165344a04241AB3Cd07d021eEC17F03ADc51

auctioncontracts's Issues

Create skeleton of contract and define base functions and fields

[Functional] Add minimum accepted bid for slot

[Reserach] Mint NFT directly to auction

[Functional] Support multiple deposits/withdrawals from individual slots to support ~100 NFTs in one slot

Currently, the slot limit for depositing NFTs is 40 NFTs for a single slot. This should be changed to support 100 NFTs in one slot. Also all respective functions for deposit/withdrawal/claiming should be adjusted for enabling this functionality.

[Functional] Allow withdrawing low bids before the auction is over

[Functional] Integrate linked list in auctions with keeping sorted position onchain

[Functional] Add possibility to withdraw ERC721

[Functional] Implement handling secondary sale fees in safe way

Create a Factory contract to deploy UniverseERC721 token collections

[Testing] Unit test - bid with ETH

[Test] Test cancel auction functionality

[Functional] Implement handling secondary sales fees in the auction sales

[Functional] Deposit ERC721 to slot

[Functional] Deposit multiple ERC721s

Change start and end time of auctions to use block.timestamp instead of block.number

[Functional] Bid increments

[Functional] Add possibility to withdraw ETH

Setup local dev environment for deployment and testing

[Functional][Optimism] Add finalize function to handle all rewards distribution

[Functional] Add possibility to withdraw ERC20

[Testing] Unit test - deposit erc721

[Functional] Implement general feedback

[Test] Add missing tests

[Functional] Bid to contract with ERC20

[Functional] Implement Ownable pattern

[Functional] Create Auction

Implement HasSecondarySalesFees standard

[Functional] Cancel Auction

[Functional] Claim rewards - ERC721

Define the logic for mapping bids to slots

[Functional] Bid to contract with ETH

[Functional] Implement Secondary Sale Splits on Auction layer

Decide on proper design pattern

[Issue] withdrawAuctionRevenue does not take into account SecondarySaleFees

Auction is finalized and revenue calculated but revenue can be withdrawn without withholding secondary sale fees

AuctionContracts/contracts/AuctionFactory.sol

Line 927 in af82332

function withdrawAuctionRevenue(uint256 auctionId)

Is this what #87 is for? If so, can close this issue.

[Functional] Implement whitelist addresses

[Functional] Finalize auction

Specify Specific Version of Solidity

I suggest specifying a specific version of Solidity to use, particularly in the main contract that is deployed. In the future this will make it very clear what version of Solidity was used and can be handy for verifying source code.

I also suggest using the latest production version of Solidity because it is the most capable and has the most bugs fixed. It is also recommended by the main developer of the Solidity language: https://twitter.com/mudgen/status/1449754962318213125

However I think Solidity 0.7.x is fine too if that is preferred.

Initialize repo with boilerplate hardhat project

[Testing] Unit test - createAuction

[Functional] Implement royalty fee functionality

[Test] Add missing tests and refactoring

[Functional] Claim winning bids

[Test] Testing whitelist functionality

[Functional] Extend auction logic

[Functional] Handle case when we have less bids than slots

[Functional] Add limits and requires where necessary

[Functional] Create UniverseERC721Core contract with single minting allowed for everyone

Currently, we have UniverseERC721 contract (deployed by factory), where only the contract owner can mint NFTs.

A new UniverseERC721Core contract should be created which implements the existing UniverseERC721, but allows single minting/ batch minting for the user.

[Functional] Set limits for slots and nfts in constructor

Fee sum can be overflowed

The sum variable in the _registerFees function can be overflowed by providing a very high fee.
This can be done to create a fee that is greater than 3000 and pass the require(sum <= 3000, "Fee should be less than 30%"); statement.

The batchMint function from UniverseERC721Core contract utilizes the _registerFees. Anybody can call the batchMint function to mint new NFTs with corrupted fees.

AuctionContracts/contracts/UniverseERC721.sol

Lines 99 to 116 in 8ce38cd

	function _registerFees(uint256 _tokenId, Fee[] memory _fees) internal returns (bool) {
	require(_fees.length <= 5, "No more than 5 recipients");
	address[] memory recipients = new address[](_fees.length);
	uint256[] memory bps = new uint256[](_fees.length);
	uint256 sum = 0;
	for (uint256 i = 0; i < _fees.length; i++) {
	require(_fees[i].recipient != address(0x0), "Recipient should be present");
	require(_fees[i].value != 0, "Fee value should be positive");
	sum += _fees[i].value;
	fees[_tokenId].push(_fees[i]);
	recipients[i] = _fees[i].recipient;
	bps[i] = _fees[i].value;
	}
	require(sum <= 3000, "Fee should be less than 30%");
	if (_fees.length > 0) {
	emit SecondarySaleFees(_tokenId, recipients, bps);
	}
	}

[Functional] Bid Increments