universityofhelsinkics/front-grappa2

GRadut Pikaisesti PAkettiin v2

front-grappa2's Issues

Semantic UI lokaaliksi

Tällä hetkellä CDN:n kautta tulevaa - turvallisuuden takia pitää saada lokaaliksi

Shippoletilla voi kirjautua Grappaan

Grader accepting is not working as intended

Graders can be reviewed even if they don't have a thesis.

Review should be about agreementPersons, and agreementPersons are linked to agreement and a personWithRole. There should never be agreementPerson without a thesis.

New table layout for thesis list

Columns

• Title
• Author
• Printed
• Checked by author
• Checked by resp-prof
• Council meeting

Gradusopimuksen lomakkeeseen voi lisätä pdf liitteitä

Update councilmeeting refreshes to old data

When updating a councilmeeting the "update councilmeeting" fields turn into the old information.
Double clicking update leads to problems.

Suggested fix: Hide update fields on click.

User manuals

Add user manuals to pages:

Role management page should tell the manager person what it's for and how to use it.
Grader accept page should tell the resp-professor what it's for and how to use it.

Navigointi baari fronttiin

ja elämä helpottuu!

Print-person rights 2

Move multiple theses to next meeting should be possible by selecting them and using a button.

Fix statistics page to work with real data

Import from old DB should be done first.

Redux broke NavBar

Steps to reproduce:

Pull master
npm install
npm start

Try changing pages. NavBar doesn't activate correctly.

Steps to tapefix:

Remove redux from NavBar.

Print-person rights

Thesis list shouldn't have download button and next councilmeeting should have.

When a printperson downloads documents for next councilmeeting ask them if they want to mark them as done.

Redirect on new thesis

Redirect user to thesis view page and show success message more clearly.

“thesis has now been saved. grappa will send email to….. you do not have to do anything…”

Thesis list filtering is broken

Refaktoroida Thesis Contract -> Agreement

Councilmeeting date select chooses incorrect date

Date saved is one before clicked (27.2 turns to 26.2 when saving)

Update works correctly, but saving a new councilmeeting does not.

Add confirm for attachment deletion

Role management does not update users nav-bar

If user gives themselves roles, they need to press F5 to see correct nav-bar (and everything else).

Suggested fix: Get everything again when user modifies their own roles.

Major for math

Use the new table in 'new thesis' form to filter programmes.

Thesis view page

Rewrite edit page.

Simplify layout for councilmeeting management page

Shippolet konfiguraatio HY:n kanssa

When creating a new councilmeeting "Name" field is displayed

"Name" created confusion, it is the header for the unit list.

Suggested fix: Display column header only when list has items.

Käyttäjä voi tarkastella näkymää arvostelutaulukosta

Improve downloading theses

Download should open window that asks "Open or download" rather than redirect to blob page.

Printed cover should have councilmeeting date

Requesting download is missing &cm(:id)

Add loading indicator for thesis printig

Sopimuksen muokkaus käskee backendiä lähettämään sähköpostin

Agreement.js refaktorointi

Contract.js on paisunu niin isoks että sitä on vaikea koodata/ymmärtää mitä siinä tapahtuu. Siitä vois eriyttää formin ja sen onnistumisviestin omiin moduuleihin jolloin niitä vois käyttää muuallakin.

Refactorointi helpottaa varmasti kun ruvetaan koodaa frontin validointeja et esim tyhjää formia ei voi lähettää . Testaaminenki helpottuu kun on monta pienempää osasta joita käytetään.

Simplify grader accepting for resp-prof

Disable user name & email fields from thesis editing page

Käyttäjä voi muokata sopimusta

Use full name of application

"Grappa" may give unfavorable impression, "Gradut Pikaisesti Pakettiin" would be preferable.

Wait for LOGIN_SUCCESS before sending other requests

We send 2-4 requests at the moment user opens the page. Only send requests if login is successful.

Hide unrelated information

Some pages still show unrelated information to users access rights.

Email draft page has button to create new email draft and manager can invite persons to be admins.

Frontend refaktoroidaan redux:iin sopivaksi

Pitää pyytää VPN yhteydet palvelimelle

Councilmeeting thesis list is empty if page is reloaded or direct url is used

Thesis abstract page chooser

Currently user has no way of choosing the abstract page (we just pick the first 4 pages of a thesis)

When uploading thesis user should choose which page is the abstract and we'd show the page.

Role management could show persons sorted in roles

When manager views "role management" page, show all roles in a list and show all the persons in that role ( in units where they are the manager )

"
Department of Computer Science:
Manager:
Dev Eloper

Grader:
Mmmm Nnnnn, Sssss Fffff, etc.
"

Otetaan käyttöön React 16

Käyttäjä voi luoda uuden supervisorin

Require two graders for thesis

Start using localization for components

https://github.com/ryandrewjohnson/react-localize-redux

Change councilmeeting deadlines to read 23:59 correctly

At the moment deadline is at 00:00 of the chosen day which is confusing users, change to 23:59.

Adding non-HY graders

New form to role management page: add non-HY grader.

Better labels to tools

Some tools do not have a name that indicates what it does.

Role management has person selector without any label or header.
Programme should be renamed to unit.

Hide OLD 'programme'

Hide OLD from list of units"on new thesis page

Käyttäjä voi mennä sivulle josta näkyy gradusopimuksen sisältö

New resp-prof access rights

Resp-professor is no longer the one responsible for accepting graders (in department of CS atleast)

Issue consists of 3 parts:

1. Hide grader accepting page.

2. Add "Thesis grading is approved" button to thesis view page.

3. Remove grader review page from print