unix-ninja/hackersandbox

The Hacker's Sandbox

hackersandbox's Issues

addUsers creates user on last vm created, not current vm.

The addUsers code doesn't track the current vm, any users created after the VM initialization process end up being created on the last vm initialized. Here is a quick mis pack for testing.

-- load test VM
newVM ("test")
setProperty( { ip = "1.1.1.1" })
addFile ({ name = "/bin/addu", content = garbage(10), exec="addu", acl="777"})
addUser ( "root", "toor" )

-- load test2 VM
newVM("test2")
setProperty ({ ip = "1.1.1.2" })
addService ({ port = "23", name = "telnetd", exec = "", start="true", poll="Login:" })
addUser ( "root", "go" )

function addu()
addUser ( "newguy", "password" )
end

function intro()
login ({ host = "test", user = "root"})
end

Running addu on test results i newguy on test2.
Super close to working I think, thanks!

Most recent update prevents addUsers from creating "root" users on VMs

Thanks for the update to fix the alloc error. This (or maybe the engine change) seems to introduce a bug where only the first VM created can add a root user. Can be seen in the destiny.mis pack. The only root user added is the one on the area6 VM.

adduser from function results in current user being replaced by random data - can cause segfault

Attempting to add a user to a vm through a function based on a file set as executable.
(function condensed to bare minimum to show issue)

-- load test VM
newVM ("test")
setProperty( { ip = "1.1.1.1" })
setProperty ({ on_root = "f_test_root", hint = "Test" })
addFile ({ name = "/bin/addu", content = garbage(10), exec="addu", acl="777"})
addUser ( "root", "toor" )

function f_test_root()
end

function addu()
addUser ( "jeff", "password" )
end

function intro()
login ({ host = "test", user = "root"})
end
--end mission pack

----- Terminal Sandbox Loading mission pack - steps to segfault
./sandbox function.mis
Loading mission pack (function.mis)...
$ whoami
root
$ /bin/addu
$ whoami
�R�
$ cd /home
$ ls
jeff/
$ cd jeff
Segmentation fault

The problem seems to be related to line 335 of vm.cpp when the new user is added to the user vector.
edit: the push_back to users vector can cause the reallocation of memory, breaking the pointer for the user_chain. Reserving the memory in the VM like users.reserve(64); fixes this issue.