unizend/lbtc-api

NodeJS Client Library for the LocalBitcoins API. Contributions are welcome.

lbtc-api's Issues

release_pin

A function for the release_pin endpoint needed

"myself" function not working

When I use the myself function, it doesn't return anything.

It seems the path is wrong. It is localbitcoins.com/api/account_info/myself but it should be /api/myself

Public market data pagination error

When I try to make a request to a page other than the first one, it throws an error from LocalBitcoins.

 Request to https://localbitcoins.com/sell-bitcoins-online/ve/venezuela/.json?page=2
{
   error: {
     message: 'HMAC authentication key and signature was given, but they are invalid.',
     error_code: 41
   }
 }

Problem with publicMarketData.bitcoinAvege()

When the LocalBitcoins API is generating the average price, the app breaks.

lbtc.publicMarketData.bitcoinAverage().then(async (response) => {
  console.log(response.VES)
})

I got this message

Request to https://localbitcoins.com/bitcoinaverage/ticker-all-currencies/
(node:16491) UnhandledPromiseRejectionWarning: FetchError: invalid json response body at https://localbitcoins.com/bitcoinaverage/ticker-all-currencies/ reason: Unexpected token T in JSON at position 0
    at /Users/desarrollomarkettech/unizend/unizend-live-rates/node_modules/node-fetch/lib/index.js:272:32
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Object.bitcoinAverage (/Users/desarrollomarkettech/unizend/unizend-live-rates/node_modules/unizend-localbtc/unizend-localbtc.js:446:18)
    at async getAverage (/Users/usuario/unizend/app/new.js:34:3)
(node:16491) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:16491) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Improve README.md

Change Install section
Add more to the usage section

Improved CONTRIBUTING.md

Add Questions/Help Section
Add Reporting Bugs / Requesting Features

Allow custom list for publicMarketData.bitcoinsAverage()

I need something like this:

lbtc.publicMarketData.bitcoinAverage({VES: '1h', COP: '6h', MXN: '12h'}).then(async (response) => {
    console.log(response)
})

[
  {
    VES.1h: 720968802.21
    COP.6h: 31108176.37
    MXN.12h: 195634.42
  }
]