Propagating business applications' exit code through Bootstrap

[hinca]

Propagating business applications' exit code through Bootstrap

[mordechaim]

I feel a bit uncomfortable adding such code to the core library.

With your setup, I think you could call System.exit() in the business application and have the launcher check the exit code. Does this make sense to you?

[mordechaim]

You could use the injection mechanism, pass a lambda to the business app which can be executed on completion. Something like this:

Bootstrap

@InjectSource
private Consumer<Integer> onExit = ...

Business

@InjectTarget
private Consumer<Integer> onExit;

Update4j will do the reference mapping automatically when launching.

[hinca]

Thanks for the response, @mordechaim. I can see how this would work between my updater and the business app, however, can this also be used through the Bootstrap? I mean, the launcher executes a separate java -jar update4j.jar etc... but the org.update4j.Bootstrap.main() doesn't return the business application's code.

Our setup is that launcher uses the default bootstrap to update the updater, and then updater has custom means of updating the business app. The missing link is between the updater and the launcher through update4j.jar.

[hinca]

If I can trickle down the launcher's exit code all the way through update4j and return it at the end of org.update4j.Bootstrap.main() using System.exit(), would you be interested in reviewing such a pull request?

[hinca]

I considered that somewhat dangerous and prone to side effects to exit rather than return cleanly from the business app, but I suppose you're right. Besides, update4j (or other frameworks) can set up shutdown hooks to clean up if necessary.

Tested a solution that works, and will keep it based on exit codes.