uportal-attic / uportal-home Goto Github PK

View Code? Open in Web Editor NEW

25.0 20.0 27.0 18.08 MB

Alternative UI for Apereo uPortal (originally built for MyUW)

Home Page: http://uportal-project.github.io/uportal-home/

License: Apache License 2.0

Shell 0.92% HTML 21.20% JavaScript 67.35% Dockerfile 0.42% Less 10.10%

uportal apereo apereo-incubating

uportal-home's People

Contributors

Stargazers

Watchers

uportal-home's Issues

An in-range update of eslint-plugin-angular is breaking the build 🚨

Version 3.2.0 of eslint-plugin-angular was just published.

Branch	Build failing 🚨
Dependency	eslint-plugin-angular
Current Version	3.1.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-angular is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Commits

The new version differs by 19 commits.

cd58df1 Merge pull request #527 from Gillespie59/development
ee0ae86 Merge branch 'master' into development
5f94b70 Remove --fix for tules
e92e5ff Update to 3.2.0
7b2c749 Update dependencies
24c45e8 Solve unit test
a45d407 Merge pull request #518 from joelchoo/master
7a36d61 Merge pull request #520 from Gillespie59/greenkeeper/gulp-mocha-5.0.0
0b2a11f Merge pull request #522 from Gillespie59/greenkeeper/gulp-eslint-4.0.1
8d27c82 Merge pull request #524 from Gillespie59/greenkeeper/shelljs-0.8.0
2e1a52b Merge pull request #523 from Arcanemagus/rule-docs-url
5ea66c3 chore(package): update shelljs to version 0.8.0
b07c974 Add URL to rule documentation to the metadata
b513875 chore(package): update gulp-eslint to version 4.0.1
cf73d9c chore(package): update gulp-mocha to version 5.0.0

There are 19 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Cannot render /web/apps when running with mock data

What happens:

Follow README instructions to run with Mock data i.e. mvn clean package && mvn jetty:run
Attempt to navigate to http://0.0.0.0:8080/web/apps e.g. via the "Add more to home" link in header.
Surprise: http://0.0.0.0:8080/web/expanded instead

What should have happened:

In (3) successfully navigate to app directory.

fix build master script

We need to update build master to incorporate the new override.js workflow.

Releasing is a bit of a pain

I just want to note all the little things that I'm constantly tripping over while running releases, so I can remember them next time, or we alleviate them.

The License Plugin picks up on files that are .gitignore'd, like endpoint.properties or src/main/webapps/META-INF/context.xml so basically you need a completely clean checkout for it to work.

The NOTICE file plugin will fail you if you don't have two empty lines at the end of your notice file.

Since the commitmsg hooks will fail a maven release, you need to remove the commitmsg line from package.json, then run mvn -DcheckModificationExcludeList=package.json release:prepare

Discussion: Attempt to merge stale branches?

Hey @uPortal-Project/uportal-home-committers! 👋

There are a couple of unmerged branches that have fallen over 300 commits behind the current master branch version.

Would it be worth while to attempt to merge these branches? Or should they be closed without merging?

Meaningful page titles (WCAG2:2.4.2)

uPortal-home should

Meet WCAG2:2.4.2 (meaningful page titles) for all pages in the product (compliant ootb)

Update Greenkeeper due to repo move

Error When Doing Maven Package

I cloned down the project

copied the endpoint.properties.example to endpoint.properties

Ran mvn clean package

Get this error:

INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] angularjs-portal ................................... SUCCESS [ 0.135 s]
[INFO] angularjs-portal-home .............................. FAILURE [ 8.187 s]
[INFO] Mock Portal ........................................ SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8.432 s
[INFO] Finished at: 2015-11-25T12:24:13-06:00
[INFO] Final Memory: 8M/245M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project angularjs-portal-home: Could not resolve dependencies for project edu.wisc.my.portal.angular:angularjs-portal-home:war:4.2.1.2-SNAPSHOT: Could not find artifact edu.wisc.my.apps:uw-frame:war:1.3.4-SNAPSHOT in internal (http://code.ku.edu:8082/archiva/repository/internal/) -> [Help 1]

Glitched CI code test coverage checking

Something is goofy about our code coverage computation, as evidenced by PR #630 's documentation change bumping code coverage by 2+%.

Credit to @davidmsibley for noticing.

update Appveyor windows build badge

one of our badges points to https://ci.appveyor.com/project/ChristianMurphy/angularjs-portal-npp5x/branch/master

Is this still useful? does it need to move due to the repo move?

rest-proxy service as a service

Idea: Make hosted rest-proxy a feature of the MyUW frame-based app hosting platform.

Bigger picture: enabling frame-based applications where the part running "in MyUW' is entirely

configuration at the httpd layer (as in, Shibboleth SP configuration)
static files served as is to the browser (that is, the client-side AngularJS/JavaScript/HTML5 application that runs in the end user's browser)
configuration at the application-in-MyUW layer

and is not any application-specific code running server-side "in MyUW'.

So instead of a frame-based app providing an instance of a rest-proxy, it provides a JSON file fulfilling a semantically versioned configuration API. MyUW the hosting platform reads that configuration file associated with the frame-based app and provides a platform-provided instance of rest-proxy fulfilling the configuration.

(The proxy would typically proxy to a back-end running elsewhere, in Shared Hosting or otherwise).

A similar idea for platform-provided KeyValueStore-as-a-service.

The modules running "in MyUW" get less individually custom, more supportable, simpler. They're just static resources to be served to the client and configuration, no server-side custom code.

Update Code Climate Badge due to repo move

Person Search result format with no fields filled in

If the "see more" fields aren't filled in, they shouldn't show up in the results. If no results are there at all, the "see more" button should hide.

Prefer sourcing additional app directory entry metadata from publishing parameters

Whereas up to this point uPortal-home has largely relied upon custom portlet-preferences exposed via ad-hoc hacks to uPortal,

now add support for sourcing that configuration from portlet publishing parameters (which are all exposed in the portlet registry JSON without requiring ad-hoc hacks to uPortal),

so that uPortal adopters can add uPortal-home-supporting metadata to their portlet publications without having to hack uPortal to make these effective.

And then make this the preferred approach, deprecating the hacky support for conveying this stuff via portlet-preferences.

angularjs-portal migration to uPortal-home

@UW-Madison-DoIT/uportal-home-committers

Within the next two weeks, uw-frame and angularjs-portal will be changing names to uPortal-app-framework and uPortal-home as part of our Apereo incubation process.

This will include:
changing the maven groupId and artifactId
moving the repository location to within the uPortal-Project organization in GitHub

As a developer, you may need to:
update your git remote if you have these projects cloned locally
update maven dependency information in your project's pom.xml

You'll receive more detailed information as we work through the process. If you have any questions or concerns about whether this affects you or how to update your project, please feel free to respond to this issue or email ~~the myuw-infra team at [email protected]~~ the uPortal-home committers at uportal-dev@.

Thanks!

Configurable basic tiles/widgets

As a developer, I would like to configure the color of the fa-icon in compact mode via the widgetConfig.

Based on convo on https://gitter.im/UW-Madison-DoIT/angularjs-portal?at=57e14adfc8af41d45f2f4cff

An in-range update of lint-staged is breaking the build 🚨

Version 6.0.1 of lint-staged was just published.

Branch	Build failing 🚨
Dependency	lint-staged
Current Version	6.0.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

lint-staged is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v6.0.1

6.0.1 (2018-01-19)

Bug Fixes

package: update cosmiconfig to version 4.0.0 (80596c3)

Commits

The new version differs by 15 commits.

e48402e refactor: Do not pass redundant param for searchPath
2d8981b chore(package): update lockfile
80596c3 fix(package): update cosmiconfig to version 4.0.0
8baab8c docs: Update inconsistent docs for filtering files (#374)
237d3f6 chore(package): upgrade to jest 22 (#367)
4cd6aef ci(travis): Update semantic-release config (#371)
8e3545c test: Use expect.assertions() to test async codes (#377)
e39d1de ci: Cache dependencies (#378)
a845bb2 chore(scripts): replace npm run with yarn (#370)
aeb4dfb chore: commit yarn.lock (#368)
3340357 chore(package): update prettier to version 1.9.2 (#359)
29c3715 chore(package): Update prettier to version 1.9.1 (#354)
f0c4686 chore(package): Update prettier to version 1.9.0 (#353)
cf87b61 docs(README): Add link to releases for changelog (#349)
023ad73 chore(github): Add issue template (#351)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Disable Coveralls comments

Currently for every commit Coveralls both:

Adds a comment for the commit:

And reports to the PR status:

Disabling the comment mechanism could keep PRs easier to read.

/cc @apetro

Automatically release on merge to master

It would be better if

Every merge to master automatically yielded a suitably versioned release

This ought to be possible with discipline, in that

Commits indicate what kind of change they bring
Changelog can be updated in the same changeset as the changes it logs

Let's spend none of our time manually running releases and more of our time composing changes worthy of release.

Bug: maintenance widget mode layer over top of priority notification layer

Adopt John Papa Angular Styleguide?

Context: #601 (comment)

https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md
https://github.com/dustinspecker/eslint-config-angular

Define the uPortal context name (e.g. 'portal/' or 'uPortal/') in one place

I see a bunch of these...

          'SERVICE_LOC': {
            'aboutURL': '/portal/api/session.json',
            'sessionInfo': '/portal/api/session.json',
            'sidebarInfo': '/web/staticFeeds/sidebar.json',
            'newstuffInfo': '/web/staticFeeds/new-stuff.json',
            'context': '/portal/',
            'base': '/portal/api/',
            ...

Travis CI MacOS build delay

Hey @UW-Madison-DoIT/uportal-home-committers 👋

Looking at the CI build lately, the CI appears to be consistently taking anywhere from 20 minutes to 2 hours to report back the full build matrix. 🐢
Each of the individual builds is under 5 minutes and can be run in parallel. 🐎
However the OSX build has a delay before starting due to limited infrastructure availability.

I am very grateful to both Travis CI and Appveyor for providing free infrastructure to open source projects. 🙇‍♂️
And it would be nice to keep MacOS builds around to verify that cross platform support is being maintained 🍎 ✅ , however productivity is also an important concern.

Any thoughts on how to balance cross platform support and still keep the CI turn around time down? 💭

Some options:

Remove MacOS from the build matrix
Allow failures on MacOS build and fast finish the build.
Leave the build as is
Other?

An in-range update of eslint is breaking the build 🚨

Version 4.16.0 of eslint was just published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.15.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v4.16.0

e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796) (Michael Ficarra)
af043eb Update: Add NewExpression support to comma-style (#9591) (Frazer McLean)
4f898c7 Build: Fix JSDoc syntax errors (#9813) (Matija Marohnić)
13bcf3c Fix: Removing curly quotes in no-eq-null report message (#9852) (Kevin Partington)
b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes #9526) (#9855) (PiIsFour)
8ccbdda Docs: Clarify that -c configs merge with .eslintrc.* (fixes #9535) (#9847) (Kevin Partington)
978574f Docs: Fix examples for no-useless-escape (#9853) (Toru Kobayashi)
cd5681d Chore: Deactivate consistent-docs-url in internal rules folder (#9815) (Kevin Partington)
2e87ddd Docs: Sync messageId examples' style with other examples (#9816) (Kevin Partington)
1d61930 Update: use doctrine range information in valid-jsdoc (#9831) (Teddy Katz)
133336e Update: fix indent behavior on template literal arguments (fixes #9061) (#9820) (Teddy Katz)
ea1b15d Fix: avoid crashing on malformed configuration comments (fixes #9373) (#9819) (Teddy Katz)
add1e70 Update: fix indent bug on comments in ternary expressions (fixes #9729) (#9818) (Teddy Katz)
6a5cd32 Fix: prefer-destructuring error with computed properties (fixes #9784) (#9817) (Teddy Katz)
601f851 Docs: Minor modification to code comments for clarity (#9821) (rgovind92)
b9da067 Docs: fix misleading info about RuleTester column numbers (#9830) (Teddy Katz)
2cf4522 Update: Rename and deprecate object-property-newline option (#9570) (Jonathan Pool)
acde640 Docs: Add ES 2018 to Configuring ESLint (#9829) (Kai Cataldo)
ccfce15 Docs: Minor tweaks to working with rules page (#9824) (Kevin Partington)
54b329a Docs: fix substitution of {{ name }} (#9822) (Andres Kalle)

Commits

The new version differs by 22 commits.

33ca1ea 4.16.0
1a9ddee Build: changelog update for 4.16.0
e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes #7567) (#9796)
af043eb Update: Add NewExpression support to comma-style (#9591)
4f898c7 Build: Fix JSDoc syntax errors (#9813)
13bcf3c Fix: Removing curly quotes in no-eq-null report message (#9852)
b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes #9526) (#9855)
8ccbdda Docs: Clarify that -c configs merge with .eslintrc.* (fixes #9535) (#9847)
978574f Docs: Fix examples for no-useless-escape (#9853)
cd5681d Chore: Deactivate consistent-docs-url in internal rules folder (#9815)
2e87ddd Docs: Sync messageId examples' style with other examples (#9816)
1d61930 Update: use doctrine range information in valid-jsdoc (#9831)
133336e Update: fix indent behavior on template literal arguments (fixes #9061) (#9820)
ea1b15d Fix: avoid crashing on malformed configuration comments (fixes #9373) (#9819)
add1e70 Update: fix indent bug on comments in ternary expressions (fixes #9729) (#9818)

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of greenkeeper-lockfile is breaking the build 🚨

Version 1.13.0 of greenkeeper-lockfile was just published.

Branch	Build failing 🚨
Dependency	greenkeeper-lockfile
Current Version	1.12.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

greenkeeper-lockfile is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v1.13.0

1.13.0 (2018-01-19)

Features

add basic Codeship CI Integration (258e9c0)

Commits

The new version differs by 3 commits.

258e9c0 feat: add basic Codeship CI Integration
b290b64 Align git username
dcdbb5c closes #81

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Update TravisCI due to repo move

I think it auto-updated for app-framework, here it's still calling itself uPortal-Project/angularjs-portal

I may have tried renaming the repo too soon after transferring ownership? I'm not sure how to get it to rename itself.

Generalize search configuration

Change the search configuration to be generic so you can have n search result sections of various formats.

Braindump from UWSP convo.

{
  "group" : "UWRF",
  "searches" : [
    {
      "title" : "wisc.edu",
      "url" : "https://google.com/custom/search/url/that/i/donot/know",
      "searchFormat" : {
        "title" : "searchitem.title",
        "desc" : "searchitem.description",
        "link" : "searchitem.googleurl"
      }
    }
  ]
}

Prefer material icons in app directory entries

Update documentation to recommend, prefer using material icons rather than font-awesome icons, documenting just how to do so.

Fix Lint Errors For TravisCI

I'm creating This issue to notify any developers currently working on this repository that I'm working on a wide-reaching pull request to fix lint errors. This will touch most of the controllers, directives and services within the repository, and cause merge conflicts with any concurrent work.

(Hopefully you're not in the middle of anything @ChristianMurphy!)

Greenkeeper

Angular js portal is leveraging NPM and SemVer.
This combination opens up the opportunity for a lot of tooling that can help support managing depedencies.
Tools like David-DM, Depenency CI, etc. Offer passive assistance, giving a highlight of when potential upgrades or fixes are needed.

Tooling could alternatively take a more active approach.
Greenkeeper could be added to a repository to automatically open Pull Requests when upgrades to libraries happen.
It can even retest the repository after a version has been updated, and update shrinkwrap/lock files automatically.

Thoughts? 💭

Remove ESLint plugin JSON?

When running the lint scripts I've been noticing they run unusually slow ~20 seconds on a development machine, longer on CI.
I did some digging, it appears to come from eslint-plugin-json.
So far that plugin has not detected any warnings, and removing the plugin takes the full eslint run time down to ~2 seconds on my development machine.
This plugin may be worth removing for the lint time speedup.

Relax Coveralls threshhold and suppress Code Climate PR status failures

We should improve test coverage someday.

In the meantime, Coveralls delivering red Xs to pull requests is demoralizing and distracting without being helpful.

Therefore reconfigured Coveralls with cartoonishly low standards about test coverage. Should always pass. We still get the automatic calc, we can choose to engage with test coverage any time we want, but we stop with the annoyance in the meantime.

(Logged as GitHub issue for transparency.)

Implement pa11y for automated WCAG checking

Set up an automated process for running pa11y on the project

Locally backlogged within MyUW Scrum as MUMMNG-4056.

Discussion: Scoped npm package naming

Hey @UW-Madison-DoIT/uportal-home-committers! 👋
I'm excited for the moves to official Apereo naming and to an official Apereo repo. 😄

One thing that could be worth discussing before it is set in stone is the scope package naming convention. 💬
⌨️ when typing

@uportal/uportal-home
 ^^^^^^^^^^^^^^^
 this feels awkward to type

@uportal/uportal-app-framework
 ^^^^^^^^^^^^^^^
 same here

I'm wondering if we may want to consider @angular style scoped naming

Where angular cli is @angular/cli rather than @angular/angular-cli.

➡️ Meaning uPortals projects would be packaged as

@uportal/home

@uportal/app-framework

Thoughts? 💭

Enable Travis CI for PRs

Currently it looks like Travis only builds for commits made on the main repository.
Travis CI can also build for each PR opened on the repository.

Pros of change:
External contributions are run through CI.

Cons of change:
PRs from internal branches would be built twice.

Thoughts? 💭

Enable layout reordering via keyboard

To hit WCAG 2.0 A 2.1.1 we'd like to enable the user to reorder their layout via keyboard.

Add an example of campus search json format to documentation

For schools that want to use the campus search and aren't using the latest google search api, an example would help to be able to know what format the code is expecting

Widget creator broken

Intended to include a "Widget Creator" such that https://public.my.wisc.edu/web/widget-creator would be a thing. But it's broken.

(This public GitHub issue tracker issue shadows MyUW-local MUMUP-2914; this shadowing is a small step toward experimenting with better tracking product issues publicly rather than in private MyUW JIRA.)

An in-range update of jasmine-core is breaking the build 🚨

Version 2.9.1 of jasmine-core was just published.

Branch	Build failing 🚨
Dependency	jasmine-core
Current Version	2.9.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

jasmine-core is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

2.9.1

Please see the release notes

Commits

The new version differs by 2 commits.

70bce55 Bump version to 2.9.1
53529bd Clear timeouts when starting to process a milli instead of at the end

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

Alphabetical app directory sort isn't

...

Upgrade to rest-proxy

We should migrate to the new rest-proxy service and get rid of json-proxy-service

Add error handling for edge case of announcement with bad fname reference to widget

Summary

When a mascot announcement references a widget that doesn't actually exist, there's no error acknowledgement when the user tries to add the nonexistent widget to their home.

How to reproduce:

Given:

have a mascot announcement that references a widget by an fname
have that fname not actually map to anything (no portlet-definition with that fname

Then:

access the mascot announcement
click its inviting "Add to home" button
observe mascot dismisses, with indication of failure
inspect announcement again
observe it now reports the widget as "On your home"

What should have happened:

when the user attempts to add the widget to home, fail with a clear user-facing message
do not incorrectly report widget as "On your home"

Credit where credit is due

Nonetheless: kudos on this already failing kind of gracefully. The page successfully renders, it doesn't fail out into the JavaScript console. It could fail gracelessly, rather than just silently. It's this graceful because developers are taking care.

An in-range update of jasmine-core is breaking the build 🚨

Version 2.9.0 of jasmine-core was just published.

Branch	Build failing 🚨
Dependency	jasmine-core
Current Version	2.8.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

✅ dependency-ci Dependencies checked Details
❌ coverage/coveralls Coverage pending from Coveralls.io Details
✅ continuous-integration/appveyor/branch AppVeyor build succeeded Details
❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

2.9.0

Please see the release notes

Commits

The new version differs by 61 commits.

c82e594 Version bump to 2.9.0
f76b452 Correctly check for Symbols, not Sets in AnythingSpec
91aab8e Merge branch 'Volox-ie11-sets-support'
486a646 Added complete support for Set also for IE11.
1dfdc89 Merge branch 'ie11-maps-support' of https://github.com/Volox/jasmine into Volox-ie11-maps-support
085a1f8 Added complete support for Map also for IE11.
aeeb5b7 Bumped copyright dates
cb6de64 Fixed DelayedFunctionScheduler IE 8 compatibility issue
f69949e Merge branch 'fix-1426' of https://github.com/leahciMic/jasmine
1136fdd Remove .sort() and fix logic in test
b943f6b Fixed SPEC HAS NO EXPECTATIONS warning in HTML reporter
b439e2f Extracted results state management out of the HTML reporter
c79ce12 Merge branch 'node-timeouts' of https://github.com/chris--young/jasmine
62b815c Use timeout objects when in node
65b4499 In Jasmine's own tests, don't leak between jasmine and jasmineUnderTest

There are 61 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Do we really need this many badges?

Implement AppLauncher portlet-definitions as equivalent widgets

uPortal has an "App Launcher" portlet, typically configured with a title, icon, target URL, ... . There's a nice conceptual mapping to be had to an equivalent widget. Add sugar, support so that AppLauncher portlet-definitions are treated as link widgets when displayed in uPortal-home.

This might be an opportunity to refactor to use the AppLauncher configuration idioms so that these things are less different and more interchangeable.

Static Analysis and Linting

Static analysis and linters are a great way to detect code smells and errors before releasing code.

Apereo uPortal has been moving over to validating code with the Google code style, angularjs-uportal and uw-frame could also benefit from the lint checking goodness.

Most of the languages used in this project have linters.
If there is interest I could put together a Pull Request to setup some static analysis tooling.

For Java Checkstyle configured with Google code style is a reliable linter.

For JavaScript ESLint is a great option, it has a Google code style configuration, as well as plugins to better check specific use cases and libraries (Angular, Jasmine, RequireJS, Promise, Browser Compatibility, JavaScript in Markdown, and JSON)

For Less checking Stylelint with a standard config (based off google css style) has been fairly reliable.

For Markdown remark lint with recommended and consistent configuration can produce good results.

For Angular HTML templates HTMLHint can have okay-ish results, angular templates are difficult to lint properly.

update Coveralls due to repo move

new project wants to point to https://coveralls.io/github/uPortal-Project/uportal-home?branch=master

Implement Selective for a11y testing

https://github.com/ChristianMurphy/selective

Maven release plugin conflicts with commit message hook

the commit messages generated by the maven release plugin, cause the conventional commit check on commit messages to fail.
In order to release currently, the hook needs to be removed, then the release happens, then the hook is readded.
This is both frustrating and causes unneeded churn.

Some possible solutions:

configure the maven release plugin to use commit messages that align with conventional commits
configure the maven release plugin to skip the commitlint check when committing
configure commit lint to accept the messages autogenerated by the maven release plugin

uportal-attic / uportal-home Goto Github PK

uportal-home's People

Contributors

Stargazers

Watchers

Forkers

uportal-home's Issues

Version 3.2.0 of eslint-plugin-angular was just published.

What happens:

What should have happened:

Version 6.0.1 of lint-staged was just published.

6.0.1 (2018-01-19)

Bug Fixes

Version 4.16.0 of eslint was just published.

Version 1.13.0 of greenkeeper-lockfile was just published.

1.13.0 (2018-01-19)

Features

Version 2.9.1 of jasmine-core was just published.

Summary

How to reproduce:

Credit where credit is due

Version 2.9.0 of jasmine-core was just published.

Recommend Projects

Recommend Topics

Recommend Org