Giter Site home page Giter Site logo

Comments (24)

titanism avatar titanism commented on May 26, 2024 1

Of course @AnandChowdhary , thank you . This is what OSS is all about 🙏

from upptime.

titanism avatar titanism commented on May 26, 2024 1

oh goodness @AnandChowdhary this is broken 🤦

https://community.cloudflare.com/t/cloudflare-warp-not-routing-smtp-to-internal-addresses/335898

it blocks ports like 25 outbound... can you revert? we need to find another IPv6 alternative

from upptime.

titanism avatar titanism commented on May 26, 2024 1

@AnandChowdhary please revert when you can 😢

Screen Shot 2024-01-25 at 10 43 28 AM

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

We got this from actions/runner-images#668.

@titanism, perhaps it should be v1 instead of v2?

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

We got this from actions/runner-images#668.

@titanism, perhaps it should be v1 instead of v2?

Not really. I've modified the files where it's present and I get this:

Error: Unable to resolve action `fscarmen/warp-on-actions@v1`, unable to find version `v1`

from upptime.

titanism avatar titanism commented on May 26, 2024

Prob should just directly put this in, so we're not dependent on 3rd party https://github.com/fscarmen/warp-on-actions/blob/7c3bf29e14b71882e4ff62138da4a663fdd74c4a/action.yml#L15-L26

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

@titanism
I think I fixed it. I looked at the repo and the version that is available is v1.0.

From the repo:

Usage:

client warp+doh mode

 - uses: fscarmen/[email protected]
   with:
     mode: client  # Optional, default

wireguard

 - uses: fscarmen/[email protected]
   with:
     mode: wireguard

In Releases there's only the v1.0. I'll make a PR if you want.

RN. I've tried this and it works for me as of now.

PS: Since it works now I can go and figure out why the jobs are running avery +- 15 minutes instead of 5 (and sometimes 30m or even hours). Hopefully I've fixed it by modifying the files but we'll see. I've just found this project few days ago so I'm still figuring stuff out.

PPS: Looks like everything now runs as it should. Even on time - yesterday I didn't have any uptime checks for 12 hours - probably the bug got pulled in an update and the installation broke. I've disabled the update workflows until this one's figured out and then I'll turn them on again - the file says that manual changes to it will get overwritten in an update so it should be fine.

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

Thank you for the fix, I'll make sure this goes live ASAP!

Since it works now I can go and figure out why the jobs are running avery +- 15 minutes instead of 5 (and sometimes 30m or even hours)

This is documented here: https://upptime.js.org/blog/2021/01/22/github-actions-schedule-not-working

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

I've just shipped this, can you please test this by manually running "Update Template CI" and then running "Setup CI" after the template has been updated? Thanks!

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

It's still failing with the same issue @AnandChowdhary

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

I can see that the v2 tag is still present in the files instead of v1.0:

- name: Setup WARP
uses: fscarmen/warp-on-actions@v2

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

I recreated the repo since I broke something and I got the upptime/upptime README instead of mine. I modified the setup.yml to use v1.0 and after running the warp-on-actions completely disappeared from all files. Is this what was supposed to happen?

from upptime.

jiriks74 avatar jiriks74 commented on May 26, 2024

(I also noticed that response time is ran at 11pm instead of every 6 hours)

schedule:
- cron: "0 23 * * *"

(just an FYI, I'll create a new issue if you think it's more appropriate)

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

As you can see from the commit c1a25af, the expected output is that fscarmen/warp-on-actions will be completed removed and instead we've hardcoded the step "Install WARP to support IPv6".

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

I'll reopen this issue until we have verification that it works! ✅

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

@jiriks74 This new "Install WARP to support IPv6" step is only added for workflows that have an ipv6: true site, since your Upptime repository (jiriks74/upptime@f2ae9ae) does not have that, this step is unnecessary. Same as yours, @titanism, if you add a site with IPv6 now, I think it should work :)

from upptime.

Iliya5digital avatar Iliya5digital commented on May 26, 2024

Where paste token into GH_PAT secret? Which file? Show me the path.

from upptime.

titanism avatar titanism commented on May 26, 2024

@AnandChowdhary I don't think this is going to work because inputs.mode is not defined? See my comment at upptime/uptime-monitor@47e177b#r137581722.

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

You're right :( Would you like to make a PR with what's correct? This is where we have to change it - https://github.com/upptime/uptime-monitor/blob/3e32e513ff5d36837223efb82957b67ee5768f42/src/helpers/workflows.ts#L43

from upptime.

Iliya5digital avatar Iliya5digital commented on May 26, 2024

friends!
check with me what's wrong https://github.com/Iliya5digital/sites

error Unable to resolve action fscarmen/warp-on-actions@v2, unable to find version v2

from upptime.

titanism avatar titanism commented on May 26, 2024

@AnandChowdhary the easiest thing you can do is remove all the conditional IPv6 stuff and just add this globally for all installations. It would actually be a ➕ feature that users would love, as they wouldn't rely on whatever trash DNS GitHub CI is using. You'd simply add this to the CI yaml:

sudo apt-get -y update
curl -fsSL https://pkg.cloudflareclient.com/pubkey.gpg | sudo gpg --yes --dearmor --output /usr/share/keyrings/cloudflare-warp-archive-keyring.gpg
echo "deb [arch=amd64 signed-by=/usr/share/keyrings/cloudflare-warp-archive-keyring.gpg] https://pkg.cloudflareclient.com/ $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/cloudflare-client.list
sudo apt-get update
sudo apt-get install -y cloudflare-warp
sudo warp-cli --accept-tos register
sudo warp-cli --accept-tos set-mode warp+doh
sudo warp-cli --accept-tos connect

from upptime.

titanism avatar titanism commented on May 26, 2024

But if you want to just fix that WARP_ACTIONS snippet @AnandChowdhary all you need is the code shared in my previous comment

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

Added globally!

from upptime.

AnandChowdhary avatar AnandChowdhary commented on May 26, 2024

Thanks for all your help @titanism, looks like IPv6 is working after adding this - b560b6f

from upptime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.