Dup marks

[urbainvaes]

Dup marks

[noboruma]

I encountered the exact same issue and I think I have reproduction steps.
Create a folder such as "c++" and mark it:
$ mkdir c++ && cd c++ && mark
Then select it (via C-g) and it will be duplicated every time it is accessed.
Maybe it has something to do with the special character '+'?

@urbainvaes : good catch, think I lost control of my zsh, let fight :)

Thanks, that's awesome, now I can live in peace :)

[urbainvaes]

Thanks, but there isn't much I can do without additional information. Could you provide details about the shell you use, the version of the plugin, and possibly paste a copy of your marks file?

Thanks, that's latest fzf-marks, manually installed, Z-shell latest, os: archlinux.

I re-map ^g to ^] and re-name ~/.fzf-marks to ~/.marks, this issue raise with just using only ^] and mark command to create new marks, especially happens when create new map and then select that newly created with ^] and enter to select.

[urbainvaes]

Many thanks for the bug reports. You're right, it had to do with special characters. I have pushed a commit that should fix this, 14c2e40.

@noboruma Does this fix your issue?

Another issue: this https://github.com/urbainvaes/fzf-marks/blob/master/fzf-marks.plugin.zsh#L26 does not expand $HOME in my case if it's a symlink. I have to hardcode, maybe it's not a problem.

[urbainvaes]

Is the environment $HOME variable set, though? By hardcode, you mean you need to export FZF_MARKS_FILE=...?

@urbainvaes : It cannot expand variable $HOME somehow, yes I have HOME set:

touch: cannot touch '$HOME/.marks': No such file or directory

I had to set it to: export FZF_MARKS_FILE='/home/user/.marks', I might set a env variable wrong somewhere, Is there any special en var needs to check?

Should we use emulate to bring back to default zsh?

[urbainvaes]

Many thanks for your reply. Before using export FZF_MARKS_FILE='/home/user/.marks', what were you using exactly? If you were using export FZF_MARKS_FILE='$HOME/.marks', then the reason it didn't work is the presence of single quotes. If you weren't, then we could use emulate to bring back to default zsh, but it would be nice to identify the problem more clearly beforehand. ;)

[noboruma]

@urbainvaes I can confirm the fix works. Thanks for your hard work & this amazing plugin!

[urbainvaes]

@noboruma Thanks for the kind words. :)

@urbainvaes : I believe this is symlink problem, when I have .marks is a symlink instead of a real-file, fzf-marks fail to locate it.

Can't open abc/def/.marks: No such file or directory

~/.marks is linked to ~/abc/def/.marks

[urbainvaes]

Ah, good catch. Somehow this was fixed for bash but not for zsh. Can you see if it works now? And thank you again for reporting the bugs!

@urbainvaes : Another issue, my .marks is in git repo and then the touch command somehow always run when use and select candidate from fzf menu, that trigger git as the file is modified and require me to add to the repo.

EDIT: with latest version, it still touching like madness :)

[urbainvaes]

Thanks. :) That's because the plugin sorts the marks from the least recently to the most recently accessed. f5370fe adds the option FZF_MARKS_KEEP_ORDER, which you can set to 1 to prevent this from happening.

My favorite plugin ever, thanks.