readlink -f is not portable

[urbainvaes]

readlink -f is not portable

[urbainvaes]

Many thanks for reporting this. Hopefully things should work fine with both relative and absolute symlinks now.

[cdlm]

Hmm… unfortunately it's still not jumping anywhere 🙁

I don't think I have symlinks in the bookmarks I tried, so I suspect there is another problem introduced by the commits of this weekend (I update many tools quasi-daily, and used fzf-marks without noticing problems after Oct. 4).

[urbainvaes]

Thank you. Hmm, that is strange. Are there any special characters in your bookmarks or in your directories that could be the cause of this issue? And is there an error message? I'd be happy to look into it, but at this point I have no idea what might be causing this.

Perhaps the problem is with the perl regular expressions, which now contain the \Q and \E quotemeta characters?

[cdlm]

Nothing funny with my paths, I believe. I’ll investigate later tonight or tomorrow, when I get a chance.

[urbainvaes]

Thank you very much, and sorry for the inconvenience.

[cdlm]

It seems that the \? in the sed call at 382e990 doesn't work. I'm guessing it's for matching a space before the colon, but that's not really needed in that case. I tried a couple variants, and got a fix by matching the bookmark name and colon with [^:]*:. That would be a problem if colons are allowed in bookmark names, though, but there should be some sanitizing of the inputs anyway. Rewriting into modern regular expressions with sed -E would work with BSD sed as well.

Also in that line, the -n flag to sed and the /p substitution flag seem to be contradictory, but maybe I'm missing a corner case… could you explain?

[urbainvaes]

Thank you very much for tracking down the error! The \? was added in the bash version of the script in the pull request #20. But you're right, and using .* \? was equivalent to using just .* anyway.

About the -n flag, I don't remember why I wrote it like this originally. It doesn't make much sense to me either now; I'll fix it straight away.

[urbainvaes]

I have changed the regex for the bookmark, colon and space to .*:_, so that bookmarks can contain colons. The downside is that this will lead to problems when the directory contains the sequence :_, but at least the behaviour is the same as in previous versions of the plugin. In fact, the best regular expression would probably be .*_:_, given that the plugin adds _:_ between the bookmark and the directory when mark is used, but I know from the pull request linked above the at least one person uses a bookmarks file with lines starting with just :_, i.e. with no leading space. Here _ was used to mean the blank character, for clarity.