usgs-r/drb-temp-data-release

Data release in support of water temperature modeling in the Delaware River Basin

drb-temp-data-release's Issues

add test/train splits to SB

To share broadly with the modeling group, let's add test/train split info to this Scienbase release.

Fix spatial metadata passed to SB so that polylines (and polygons?) are displayed

• Right now, we are only pushing river_metadata to SB when building all of the xmls, since when we pass both river_metadata and reservoir_metadata only the bounding box for reservoir_metadata is displayed on SB:

  

• In addition, the map displayed when we push river_metadata only displays the bounding box for river_metadata:

  

  not the actual polylines, like the map in Jordan's PGMTL data release:

  

  • This may, in part, be due to the fact that river_metadata is built by calling extract_feature() on network_vertices_sf rather than modeled_network_sf, but calling it on the latter generates the following error:

  Error in UseMethod("feature_type") : 
    no applicable method for 'feature_type' applied to an object of class "c('sfc_LINESTRING', 'sfc')"
  

• Finally, when we upload the zipped shapefiles:

    command: sb_replace_files(sbid_01_spatial,
      "out_data/01_spatial_network.zip",
      "out_data/01_reservoir_polygons.zip")

The data release shows them as attached files, as expected:

But doesn't identify that the zipped folders contain shapefiles, as is the case in Jordan's PGMTL data release, which uses nearly identical commands to build and push the spatial data and metadata, though the sf object in that data release contains multi-polygons:

NOTICE: upcoming default branch name change

The master branch of this repository will soon be renamed from master to main, as part of a coordinated change across the USGS-R and USGS-VIZLAB organizations. This is part of a broader effort across the git community to use more inclusive language. For instance, git, GitHub, and GitLab have all changed or are in the process of changing their default branch name.

We will make this change early in the week of February 6, 2022. The purpose of this issue is to give notification of the change and provide information on how to make it go smoothly.

When this change is made, forks and clones of the repository will need to be updated as well. Here are instructions for making the necessary changes.

• On GitHub, change the default branch name from master to main (<your repository> -> Settings -> Branches).
• Change the default branch on any forks you have, as well as local clones. (See details below)
• If you have collaborators on this repository, let them know that they will need to change their forked/local repos. Point them to this issue to facilitate the process!
• Search within your repository for "master" so that you can change references (e.g. URLs pointing to specific commit points of files) to point to "main" instead.
• When you are done, feel free to close this issue!

Changing default branches on forks and local clones

First, update your local git configuration so that new repositories created locally will have the correct default branch: git config --global init.defaultBranch main.

Now, for any forks, do the following:

1. Go to <your fork> -> Settings -> Branches and edit the default branch from master to main.
2. Update the settings for your local clone of this fork to match this change.

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a