ushiday/pullreq-study-20231119

ushiday pull request study 20231119

_{^{Thanks to WebTigers for the logo}}

Zend Framework 1 now for PHP 8.1!

Classic ZF1 Reborn

Zend may have abandoned the original Zend Framework, but the global Zend Framework Community has not! Since Zend sentenced ZF1 to EOL, the Zend Framework community around the globe has continued to work and build on what we consider to be one of the best PHP frameworks of all time.

ZF1-Future Sponsors

Products and Projects built with ZF1-Future:

Creators of the Tiger Development Platform featuring ZF1-Future

Creators of CommunityPlus+ PHP for IBM i featuring ZF1-Future

ZF1 is Now Version 1.21!

Over 200 updates and bug fixes since 1.12!

The ZF1 community has been hard at work updating Zend Framework with all of the latest features of PHP 8 and 8.1.

Documentation

New ZF1-Future Manual: ZF1-Future Docs

Original Docs

The original docs can be found here: https://framework.zend.com/manual/1.12/en/manual.html

Installation

Installable through git clone or through
composer require shardj/zf1-future https://packagist.org/packages/shardj/zf1-future

System Requirements

ZF1 Future runs on any version of PHP between 7.1 and 8.1! (see composer.json)

License

The files in this archive are released under the Zend Framework license. You can find a copy of this license in LICENSE.txt.

Related Projects

• ZF1 Extras Future
• ZF1s - Another community supported continuation of ZF1, with a focus on splitting the frameworks original components into individual packages

Known issues and solutions

• Bootstrap error: Unable to resolve plugin "useragent"; no corresponding plugin with that name
  See comments in: Shardj/zf1-future#92

pullreq-study-20231119's Issues

Zend_Db_Adapter_Db2 limit does not work

In the IBM i DB2 environment, when using "order by", the limit method of Zend_Db_Adapter_Db2 does not work in the following code section.(I can't try it with DB2 LUW in my environment)

        /**
         * DB2 does not implement the LIMIT clause as some RDBMS do.
         * We have to simulate it with subqueries and ROWNUM.
         * Unfortunately because we use the column wildcard "*",
         * this puts an extra column into the query result set.
         */
        return "SELECT z2.*
            FROM (
                SELECT ROW_NUMBER() OVER() AS \"ZEND_DB_ROWNUM\", z1.*
                FROM (
                    " . $sql . "
                ) z1
            ) z2
            WHERE z2.zend_db_rownum BETWEEN " . ($offset+1) . " AND " . ($offset+$count);

I think the problem is that ORDER BY is not included in OVER(). I also think this method is especially complicated because the LIMIT,OFFSET function was not implemented in previous versions of DB2, and the method was to emulate it.
Modern versions implement LIMIT,OFFSET, so it may be possible to write it simply. However, this method comes at the expense of some older version users...
Therefore, I will be posting two proposed code patterns in a pull request.

cs2 issue test

This is cs2 issue post test.