uship/uship.logging

Fluent log4net logging library

uship.logging's Issues

Minimal Logger invalid JSON breaks future messages

To reproduce with a fresh Elastic Search index:

var logger = Logger.GetInstance();

logger.WriteMinimalDataLog("invalid json data");

const string json = "{\"property\":\"value\"}";
logger.WriteMinimalDataLog(json, Severity.Info);

The first message makes it into the index. The type of "properties.data" is now a string because of the JSON deserialization fallback in MinimalLogDataBuilder.cs. When the second message is sent, it is silently dropped since it does not match the type (since it converted into an object since it is valid JSON).

Proposed solution:
Wrap all invalid JSON in a object as shown below

const string json = "{\"message\":\"invalid json data\"}";

Doing .Data() over a "logged already/logged for free" property makes the logger fail in a silent fashion.

Doing something like...

_logger.Message('mah message').Data('RequestBody', requestBody).Info().Write();

Causes the logger to log an INFO message with "Error Building Log Properties".

No exception is thrown/bubbled up, so the programmer is pretty much left at a loss / assumes it never may be logged.

Possible fixes/Proposals:

Just allowing users to override these required properties/already logged properties could be bad (per the advice of @digitalpacman ) due to possible differences in data types/etc, that might cause true silent failure in the logger.

we could change the Error Building Log Properties to ERROR, but apparently this bugs people (personally, I think it should. Let's fix our logs instead of just ignoring them...)

@digitalpacman proposes the .Data() method utilize a prefix on custom fields.